Skip to content

Chrome DevTools for coding agents

test: reduce type casting in tests (#2251)

Nikolay Vitkovfecef2698d79
diff --git a/tests/McpResponse.test.ts b/tests/McpResponse.test.ts
index 89920362..6aaf9ed7 100644
--- a/tests/McpResponse.test.ts
+++ b/tests/McpResponse.test.ts
@@ -1102,7 +1102,7 @@ describe('third-party developer tools', () => {
t.assert.snapshot(JSON.stringify(structuredContent, null, 2));
},
undefined,
- {categoryExperimentalThirdParty: true} as ParsedArguments,
+ {categoryExperimentalThirdParty: true},
);
});
@@ -1153,7 +1153,7 @@ describe('third-party developer tools', () => {
);
},
undefined,
- {categoryExperimentalThirdParty: true} as ParsedArguments,
+ {categoryExperimentalThirdParty: true},
);
}
@@ -1462,7 +1462,7 @@ describe('replaceHtmlElementsWithUids', () => {
describe('webmcp', () => {
async function testIncludesWebmcpTools(
t: it.TestContext,
- parseArguments: ParsedArguments,
+ parseArguments: Partial<ParsedArguments>,
handlerAction: (
response: McpResponse,
context: McpContext,
@@ -1510,7 +1510,7 @@ describe('webmcp', () => {
it('includes webmcp tools in list_pages response', async t => {
await testIncludesWebmcpTools(
t,
- {categoryExperimentalWebmcp: true} as ParsedArguments,
+ {categoryExperimentalWebmcp: true},
async (response, context) => {
await listPages().handler({params: {}}, response, context);
},
@@ -1521,7 +1521,7 @@ describe('webmcp', () => {
it('includes webmcp tools in select_page response', async t => {
await testIncludesWebmcpTools(
t,
- {categoryExperimentalWebmcp: true} as ParsedArguments,
+ {categoryExperimentalWebmcp: true},
async (response, context) => {
const pageId =
context.getPageId(context.getSelectedMcpPage().pptrPage) ?? 1;
@@ -1534,7 +1534,7 @@ describe('webmcp', () => {
it('includes webmcp tools in navigate_page response', async t => {
await testIncludesWebmcpTools(
t,
- {categoryExperimentalWebmcp: true} as ParsedArguments,
+ {categoryExperimentalWebmcp: true},
async (response, context) => {
await navigatePage().handler(
{
@@ -1568,14 +1568,14 @@ describe('webmcp', () => {
);
},
{args: ['--enable-features=WebMCP,DevToolsWebMCPSupport']},
- {categoryExperimentalWebmcp: true} as ParsedArguments,
+ {categoryExperimentalWebmcp: true},
);
});
it('list no webmcp tools if experimentalWebmcp is false', async t => {
await testIncludesWebmcpTools(
t,
- {categoryExperimentalWebmcp: false} as ParsedArguments,
+ {categoryExperimentalWebmcp: false},
async (response, context) => {
await navigatePage().handler(
{
diff --git a/tests/tools/extensions.test.ts b/tests/tools/extensions.test.ts
index d760be15..bb0440a0 100644
--- a/tests/tools/extensions.test.ts
+++ b/tests/tools/extensions.test.ts
@@ -143,7 +143,7 @@ describe('extension', () => {
{},
{
categoryExtensions: true,
- } as ParsedArguments,
+ },
);
});
it('triggers an extension action', async () => {
@@ -176,7 +176,7 @@ describe('extension', () => {
{},
{
categoryExtensions: true,
- } as ParsedArguments,
+ },
);
});
@@ -218,7 +218,7 @@ describe('extension', () => {
{},
{
categoryExtensions: true,
- } as ParsedArguments,
+ },
);
});
});
diff --git a/tests/tools/pages.test.ts b/tests/tools/pages.test.ts
index 99f44bb8..343b49f8 100644
--- a/tests/tools/pages.test.ts
+++ b/tests/tools/pages.test.ts
@@ -99,7 +99,7 @@ describe('pages', () => {
{},
{
categoryExtensions: true,
- } as ParsedArguments,
+ },
);
});
@@ -152,7 +152,7 @@ describe('pages', () => {
{},
{
categoryExtensions,
- } as ParsedArguments,
+ },
);
});
}
@@ -202,7 +202,7 @@ describe('pages', () => {
{},
{
categoryExtensions: true,
- } as ParsedArguments,
+ },
);
});
diff --git a/tests/tools/script.test.ts b/tests/tools/script.test.ts
index 5f69e5de..1302586a 100644
--- a/tests/tools/script.test.ts
+++ b/tests/tools/script.test.ts
@@ -357,7 +357,7 @@ describe('script', () => {
assertNoServiceWorkerReported(targets, extensionId);
},
{},
- {categoryExtensions: true} as ParsedArguments,
+ {categoryExtensions: true},
);
});
@@ -384,7 +384,7 @@ describe('script', () => {
);
},
{},
- {categoryExtensions: true} as ParsedArguments,
+ {categoryExtensions: true},
);
});
@@ -412,7 +412,7 @@ describe('script', () => {
);
},
{},
- {categoryExtensions: true} as ParsedArguments,
+ {categoryExtensions: true},
);
});
});
diff --git a/tests/tools/thirdPartyDeveloper.test.ts b/tests/tools/thirdPartyDeveloper.test.ts
index 27c7905d..0c70caf4 100644
--- a/tests/tools/thirdPartyDeveloper.test.ts
+++ b/tests/tools/thirdPartyDeveloper.test.ts
@@ -9,7 +9,6 @@ import {describe, it} from 'node:test';
import sinon from 'sinon';
-import type {ParsedArguments} from '../../src/bin/chrome-devtools-mcp-cli-options.js';
import type {McpContext} from '../../src/McpContext.js';
import type {McpResponse} from '../../src/McpResponse.js';
import {TextSnapshot} from '../../src/TextSnapshot.js';
@@ -82,7 +81,7 @@ describe('thirdPartyDeveloperTools', () => {
});
},
undefined,
- {categoryExperimentalThirdParty: true} as ParsedArguments,
+ {categoryExperimentalThirdParty: true},
);
});
@@ -119,7 +118,7 @@ describe('thirdPartyDeveloperTools', () => {
);
},
undefined,
- {categoryExperimentalThirdParty: true} as ParsedArguments,
+ {categoryExperimentalThirdParty: true},
);
});
@@ -155,7 +154,7 @@ describe('thirdPartyDeveloperTools', () => {
);
},
undefined,
- {categoryExperimentalThirdParty: true} as ParsedArguments,
+ {categoryExperimentalThirdParty: true},
);
});
@@ -185,7 +184,7 @@ describe('thirdPartyDeveloperTools', () => {
);
},
undefined,
- {categoryExperimentalThirdParty: true} as ParsedArguments,
+ {categoryExperimentalThirdParty: true},
);
});
@@ -247,7 +246,7 @@ describe('thirdPartyDeveloperTools', () => {
assert.strictEqual(actualGroups[1].name, 'group-2');
},
undefined,
- {categoryExperimentalThirdParty: true} as ParsedArguments,
+ {categoryExperimentalThirdParty: true},
);
});
@@ -301,7 +300,7 @@ describe('thirdPartyDeveloperTools', () => {
assert.strictEqual(groupsLength, 1);
},
undefined,
- {categoryExperimentalThirdParty: true} as ParsedArguments,
+ {categoryExperimentalThirdParty: true},
);
});
});
@@ -368,7 +367,7 @@ describe('thirdPartyDeveloperTools', () => {
);
},
undefined,
- {categoryExperimentalThirdParty: true} as ParsedArguments,
+ {categoryExperimentalThirdParty: true},
);
});
@@ -451,7 +450,7 @@ describe('thirdPartyDeveloperTools', () => {
);
},
undefined,
- {categoryExperimentalThirdParty: true} as ParsedArguments,
+ {categoryExperimentalThirdParty: true},
);
});
@@ -494,7 +493,7 @@ describe('thirdPartyDeveloperTools', () => {
);
},
undefined,
- {categoryExperimentalThirdParty: true} as ParsedArguments,
+ {categoryExperimentalThirdParty: true},
);
});
@@ -633,7 +632,7 @@ describe('thirdPartyDeveloperTools', () => {
);
},
undefined,
- {categoryExperimentalThirdParty: true} as ParsedArguments,
+ {categoryExperimentalThirdParty: true},
);
});
@@ -680,7 +679,7 @@ describe('thirdPartyDeveloperTools', () => {
);
},
undefined,
- {categoryExperimentalThirdParty: true} as ParsedArguments,
+ {categoryExperimentalThirdParty: true},
);
});
@@ -733,7 +732,7 @@ describe('thirdPartyDeveloperTools', () => {
);
},
undefined,
- {categoryExperimentalThirdParty: true} as ParsedArguments,
+ {categoryExperimentalThirdParty: true},
);
});
@@ -792,7 +791,7 @@ describe('thirdPartyDeveloperTools', () => {
stub.restore();
},
undefined,
- {categoryExperimentalThirdParty: true} as ParsedArguments,
+ {categoryExperimentalThirdParty: true},
);
});
@@ -860,7 +859,7 @@ describe('thirdPartyDeveloperTools', () => {
stubSnapshot.restore();
},
undefined,
- {categoryExperimentalThirdParty: true} as ParsedArguments,
+ {categoryExperimentalThirdParty: true},
);
});
@@ -920,7 +919,7 @@ describe('thirdPartyDeveloperTools', () => {
stubSnapshot.restore();
},
undefined,
- {categoryExperimentalThirdParty: true} as ParsedArguments,
+ {categoryExperimentalThirdParty: true},
);
});
});
diff --git a/tests/tools/webmcp.test.ts b/tests/tools/webmcp.test.ts
index 09b7524e..15d67caa 100644
--- a/tests/tools/webmcp.test.ts
+++ b/tests/tools/webmcp.test.ts
@@ -7,7 +7,6 @@
import assert from 'node:assert';
import {describe, it} from 'node:test';
-import type {ParsedArguments} from '../../src/bin/chrome-devtools-mcp-cli-options.js';
import type {McpPage} from '../../src/McpPage.js';
import {listPages, navigatePage, selectPage} from '../../src/tools/pages.js';
import {executeWebMcpTool} from '../../src/tools/webmcp.js';
@@ -78,7 +77,7 @@ describe('webmcp', () => {
);
},
{args: ['--enable-features=WebMCP,DevToolsWebMCPSupport']},
- {categoryExperimentalWebmcp: true} as ParsedArguments,
+ {categoryExperimentalWebmcp: true},
);
});
@@ -100,7 +99,7 @@ describe('webmcp', () => {
);
},
{args: ['--enable-features=WebMCP,DevToolsWebMCPSupport']},
- {categoryExperimentalWebmcp: true} as ParsedArguments,
+ {categoryExperimentalWebmcp: true},
);
});
@@ -125,7 +124,7 @@ describe('webmcp', () => {
);
},
{args: ['--enable-features=WebMCP,DevToolsWebMCPSupport']},
- {categoryExperimentalWebmcp: true} as ParsedArguments,
+ {categoryExperimentalWebmcp: true},
);
});
});
diff --git a/tests/utils.ts b/tests/utils.ts
index 98e20512..71597903 100644
--- a/tests/utils.ts
+++ b/tests/utils.ts
@@ -122,11 +122,11 @@ export async function withMcpContext(
blockedUrlPattern?: string[];
allowedUrlPattern?: string[];
} = {},
- args: ParsedArguments = {} as ParsedArguments,
+ args: Partial<ParsedArguments> = {},
) {
await withBrowser(async browser => {
TextSnapshot.resetCounter();
- const response = new McpResponse(args);
+ const response = new McpResponse(args as ParsedArguments);
if (context) {
context.dispose();
}