Skip to content

Self-hosted personal gallery application with online photo management and albums, supporting Live/Motion Photos, EXIF parsing, geolocation recognition, and an explore map.

fix(albums): keep slug-less albums visible and linkable

Ahmet Ömer5b03dbac03a2
diff --git a/packages/database/src/dto.ts b/packages/database/src/dto.ts
index e0a3d529..3ceb4546 100644
--- a/packages/database/src/dto.ts
+++ b/packages/database/src/dto.ts
@@ -53,7 +53,7 @@ export function toPhotoDto(photo: PhotoRow): Photo {
export function toAlbumDto(album: AlbumRow, slug: string | null): Album {
return {
id: album.id,
- slug,
+ ...(slug === null ? {} : { slug }),
title: album.title,
description: album.description,
coverPhotoId: album.coverPhotoId,
diff --git a/tests/album-slugless-fallback.test.ts b/tests/album-slugless-fallback.test.ts
new file mode 100644
index 00000000..b6f6f871
--- /dev/null
+++ b/tests/album-slugless-fallback.test.ts
@@ -0,0 +1,48 @@
+import assert from 'node:assert/strict'
+import test from 'node:test'
+import Database from 'better-sqlite3'
+import { drizzle } from 'drizzle-orm/better-sqlite3'
+import { migrate } from 'drizzle-orm/better-sqlite3/migrator'
+import { DEFAULT_SITE, createResourceReader } from '@chronoframe/core'
+import { resolveAlbumPath } from '../packages/database/src/album-slugs.ts'
+import { createSqliteResourceRepository } from '../packages/database/src/sqlite-resources.ts'
+import * as schema from '../packages/database/src/schema.ts'
+import { albumPagePath } from '../packages/gallery/shared/utils/albumPath.ts'
+
+test('slug-less albums remain visible and use their numeric URL', async () => {
+ const sqlite = new Database(':memory:')
+ sqlite.pragma('foreign_keys = ON')
+ const db = drizzle(sqlite, { schema })
+ migrate(db, { migrationsFolder: './packages/database/migrations' })
+ try {
+ const album = db
+ .insert(schema.albums)
+ .values({ title: 'Missing Slug' })
+ .returning({ id: schema.albums.id })
+ .get()
+ const reader = createResourceReader(
+ createSqliteResourceRepository(db, DEFAULT_SITE),
+ )
+ const access = { admin: true, canAccess: () => true }
+
+ const listed = (await reader.listAlbums(access)).find(
+ (item) => item.id === album.id,
+ )
+ assert.ok(listed)
+ assert.equal('slug' in listed, false)
+ assert.equal(albumPagePath(listed, true), `/albums/${album.id}`)
+
+ const detail = await reader.getAlbum(album.id, access)
+ assert.equal(detail.id, album.id)
+ assert.equal('slug' in detail, false)
+ assert.equal(albumPagePath(detail, true), `/albums/${album.id}`)
+ assert.deepEqual(resolveAlbumPath(db, DEFAULT_SITE, String(album.id)), {
+ albumId: album.id,
+ slug: String(album.id),
+ isCanonical: true,
+ isHidden: false,
+ })
+ } finally {
+ sqlite.close()
+ }
+})
diff --git a/tests/resource-contracts.test.ts b/tests/resource-contracts.test.ts
index 77ec07f7..ac5509b4 100644
--- a/tests/resource-contracts.test.ts
+++ b/tests/resource-contracts.test.ts
@@ -38,6 +38,7 @@ test('user and album boundaries remove password material and serialize dates', (
assert.equal('passwordHash' in dto, false)
assert.equal(dto.createdAt, date.toISOString())
assert.deepEqual(JSON.parse(JSON.stringify(dto)), dto)
+ assert.equal('slug' in toAlbumDto(album, null), false)
})
test('photo boundary excludes future internal columns without changing nullable fields', () => {
diff --git a/tests/sqlite-resource-read.test.ts b/tests/sqlite-resource-read.test.ts
index b66c86b8..5a118bac 100644
--- a/tests/sqlite-resource-read.test.ts
+++ b/tests/sqlite-resource-read.test.ts
@@ -93,15 +93,16 @@ test('SQLite reader preserves migrated data, ordering and legacy album visibilit
db.insert(schema.albums)
.values({ id: 4, title: 'Missing slug', position: 3 })
.run()
- assert.equal(
- (await reader.listAlbums({ admin: true })).find((album) => album.id === 4)
- ?.slug,
- null,
- )
- assert.equal(
- (await reader.getAlbum(4, { admin: true, canAccess: () => true })).slug,
- null,
+ const sluglessListItem = (await reader.listAlbums({ admin: true })).find(
+ (album) => album.id === 4,
)
+ assert.ok(sluglessListItem)
+ assert.equal('slug' in sluglessListItem, false)
+ const sluglessDetail = await reader.getAlbum(4, {
+ admin: true,
+ canAccess: () => true,
+ })
+ assert.equal('slug' in sluglessDetail, false)
} finally {
sqlite.close()
}