Skip to content

Self-hosted personal gallery application with online photo management and albums, supporting Live/Motion Photos, EXIF parsing, geolocation recognition, and an explore map.

fix(social-links): align validation copy with URL checks

Ahmet Ömerbf943129532a
diff --git a/packages/contracts/src/social-links.ts b/packages/contracts/src/social-links.ts
index 937bcab5..b4a60026 100644
--- a/packages/contracts/src/social-links.ts
+++ b/packages/contracts/src/social-links.ts
@@ -25,7 +25,7 @@ export class SocialLinkError extends Error {
}
}
-/** Validate public profile URLs without requesting or resolving their hosts. */
+/** Validate HTTPS profile URL syntax without checking host reachability. */
export function parseSocialLink(value: unknown): URL {
if (
typeof value !== 'string' ||
diff --git a/packages/gallery/i18n/locales/en.json b/packages/gallery/i18n/locales/en.json
index 5b273342..1e8e2fc7 100644
--- a/packages/gallery/i18n/locales/en.json
+++ b/packages/gallery/i18n/locales/en.json
@@ -1227,7 +1227,7 @@
"visit": "Visit {platform}",
"shape": "Invalid social links data",
"limit": "Add no more than four links",
- "invalid": "Enter a valid HTTPS link to a public website",
+ "invalid": "Enter a valid HTTPS URL",
"duplicate": "This link is already listed"
},
"title": {
diff --git a/packages/gallery/i18n/locales/ja.json b/packages/gallery/i18n/locales/ja.json
index b8d33c93..f3d32cad 100644
--- a/packages/gallery/i18n/locales/ja.json
+++ b/packages/gallery/i18n/locales/ja.json
@@ -1149,7 +1149,7 @@
"visit": "{platform} を開く",
"shape": "ソーシャルリンクのデータが無効です",
"limit": "リンクは最大4件までです",
- "invalid": "公開サイトの有効な HTTPS リンクを入力してください",
+ "invalid": "有効な HTTPS URL を入力してください",
"duplicate": "このリンクは既に追加されています"
},
"title": {
diff --git a/packages/gallery/i18n/locales/ru.json b/packages/gallery/i18n/locales/ru.json
index 88896fad..c738330d 100644
--- a/packages/gallery/i18n/locales/ru.json
+++ b/packages/gallery/i18n/locales/ru.json
@@ -1227,7 +1227,7 @@
"visit": "Открыть {platform}",
"shape": "Неверные данные социальных ссылок",
"limit": "Можно добавить не более четырёх ссылок",
- "invalid": "Введите действительную ссылку HTTPS на общедоступный сайт",
+ "invalid": "Введите корректный URL-адрес HTTPS",
"duplicate": "Эта ссылка уже добавлена"
},
"title": {
diff --git a/packages/gallery/i18n/locales/zh-Hans.json b/packages/gallery/i18n/locales/zh-Hans.json
index ea8229e4..e459cc64 100644
--- a/packages/gallery/i18n/locales/zh-Hans.json
+++ b/packages/gallery/i18n/locales/zh-Hans.json
@@ -1227,7 +1227,7 @@
"visit": "访问 {platform}",
"shape": "社交链接数据无效",
"limit": "最多添加四个链接",
- "invalid": "请输入指向公开网站的有效 HTTPS 链接",
+ "invalid": "请输入有效的 HTTPS URL",
"duplicate": "此链接已添加"
},
"title": {
diff --git a/packages/gallery/i18n/locales/zh-Hant-HK.json b/packages/gallery/i18n/locales/zh-Hant-HK.json
index 5508994e..75910f34 100644
--- a/packages/gallery/i18n/locales/zh-Hant-HK.json
+++ b/packages/gallery/i18n/locales/zh-Hant-HK.json
@@ -1149,7 +1149,7 @@
"visit": "瀏覽 {platform}",
"shape": "社交連結資料無效",
"limit": "最多只能加入四個連結",
- "invalid": "請輸入指向公開網站的有效 HTTPS 連結",
+ "invalid": "請輸入有效的 HTTPS URL",
"duplicate": "此連結已加入"
},
"title": {
diff --git a/packages/gallery/i18n/locales/zh-Hant-TW.json b/packages/gallery/i18n/locales/zh-Hant-TW.json
index 46956a40..348a5dad 100644
--- a/packages/gallery/i18n/locales/zh-Hant-TW.json
+++ b/packages/gallery/i18n/locales/zh-Hant-TW.json
@@ -1149,7 +1149,7 @@
"visit": "前往 {platform}",
"shape": "社群連結資料無效",
"limit": "最多只能新增四個連結",
- "invalid": "請輸入指向公開網站的有效 HTTPS 連結",
+ "invalid": "請輸入有效的 HTTPS URL",
"duplicate": "此連結已新增"
},
"title": {
diff --git a/tests/social-links.test.ts b/tests/social-links.test.ts
index 514ea3c1..a381aaef 100644
--- a/tests/social-links.test.ts
+++ b/tests/social-links.test.ts
@@ -2,6 +2,7 @@ import assert from 'node:assert/strict'
import test from 'node:test'
import {
parseSocialLinks,
+ parseSocialLink,
resolveSocialPlatform,
socialLinkIdentity,
} from '@chronoframe/contracts/social-links'
@@ -48,6 +49,16 @@ test('rejects unsafe, malformed and duplicate social links', () => {
)
})
+test('validates HTTPS URL syntax without requiring a reachable public host', () => {
+ for (const link of [
+ 'https://evil.test/profile',
+ 'https://example.example/profile',
+ 'https://foo.onion/profile',
+ ]) {
+ assert.equal(parseSocialLink(link).href, link)
+ }
+})
+
test('duplicate identity ignores query, fragment and trailing slash but keeps the hostname', () => {
const first = 'https://example.com/a?x=1#top'
const queryVariant = 'https://example.com/a/?x=2#bottom'