Skip to content

Self-hosted personal gallery application with online photo management and albums, supporting Live/Motion Photos, EXIF parsing, geolocation recognition, and an explore map.

fix(albums): repair missing slugs when editing albums

Ahmet Ömerfc6c203e9a7b
diff --git a/packages/database/src/sqlite-mutations.ts b/packages/database/src/sqlite-mutations.ts
index f23bf023..cd303676 100644
--- a/packages/database/src/sqlite-mutations.ts
+++ b/packages/database/src/sqlite-mutations.ts
@@ -101,7 +101,8 @@ export function createSqliteAlbumWriteRepository(
}
const slug =
requestedSlug === undefined
- ? getCurrentAlbumSlug(tx, site, id)
+ ? (getCurrentAlbumSlug(tx, site, id) ??
+ claimAlbumSlug(tx, site, id, data.title ?? exists.title, ''))
: claimAlbumSlug(
tx,
site,
diff --git a/tests/album-slug-persistence.test.ts b/tests/album-slug-persistence.test.ts
index 1321b056..c69dd75e 100644
--- a/tests/album-slug-persistence.test.ts
+++ b/tests/album-slug-persistence.test.ts
@@ -196,6 +196,54 @@ test('untransliteratable titles use a stable album-id slug', async () => {
}
})
+test('editing a slug-less album claims a slug from its updated or existing title', async () => {
+ const sqlite = new Database(':memory:')
+ sqlite.pragma('foreign_keys = ON')
+ const db = drizzle(sqlite, { schema })
+ migrate(db, { migrationsFolder: './packages/database/migrations' })
+ try {
+ const writer = createAlbumWriter({
+ repository: createSqliteAlbumWriteRepository(db, DEFAULT_SITE),
+ clock: { now: () => new Date() },
+ hashPassword: async (value) => value,
+ })
+ const [first, second] = db
+ .insert(schema.albums)
+ .values([{ title: 'Old Title' }, { title: 'Existing Title' }])
+ .returning({ id: schema.albums.id })
+ .all()
+ assert.equal(getCurrentAlbumSlug(db, DEFAULT_SITE, first!.id), null)
+ assert.deepEqual(resolveAlbumPath(db, DEFAULT_SITE, String(first!.id)), {
+ albumId: first!.id,
+ slug: String(first!.id),
+ isCanonical: true,
+ isHidden: false,
+ })
+
+ const updated = await writer.update(
+ first!.id,
+ { title: 'New Title' },
+ access,
+ )
+ assert.equal(updated.slug, 'new-title')
+ assert.equal(getCurrentAlbumSlug(db, DEFAULT_SITE, first!.id), 'new-title')
+ assert.equal(
+ (await writer.update(second!.id, { description: 'Edited' }, access)).slug,
+ 'existing-title',
+ )
+ assert.equal(
+ getCurrentAlbumSlug(db, DEFAULT_SITE, second!.id),
+ 'existing-title',
+ )
+ assert.equal(
+ (await writer.update(first!.id, { description: 'Edited' }, access)).slug,
+ 'new-title',
+ )
+ } finally {
+ sqlite.close()
+ }
+})
+
test('migration replaces tombstones and retains live slug history', () => {
const oldMigrations = mkdtempSync(join(tmpdir(), 'album-slugs-0020-'))
cpSync('./packages/database/migrations', oldMigrations, { recursive: true })