Skip to content

armgit / cindy

Public Imported from GitHub
0

Consider it done. The open-source AI agent that works out of the box · 想到,就能做到。开源、开箱即用的 AI Agent。

12.1 KB
Raw Blame
// @vitest-environment jsdom

/**
 * IssueTrackerFeatureLayout —— 内容区分支的回归。
 *
 * 重点钉住「刷新失败不得盖掉已加载的列表」:useMyIssues 刷新失败时刻意保留旧 data,
 * 但 error 分支一旦优先于 hasItems,用户点一次刷新就会丢失整页内容。
 */

import { cleanup, fireEvent, render, screen, waitFor } from '@testing-library/react';
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';

import type { MyIssueItem, MyIssuesResult } from '@/../shared/myIssues';

const useMyIssuesMock = vi.fn();

vi.mock('../hooks/useMyIssues', () => ({
  useMyIssues: () => useMyIssuesMock(),
}));
vi.mock('@/features/cc-agent/useRegisterCCAgentSidebar', () => ({
  useRegisterCCAgentSidebar: () => undefined,
}));
vi.mock('@/components/layout/windowDrag', () => ({
  InvisibleWindowDragStrip: () => null,
  WINDOW_DRAG_STYLE: {},
  WINDOW_NO_DRAG_STYLE: {},
}));
vi.mock('react-router-dom', () => ({ useNavigate: () => vi.fn() }));
vi.mock('react-i18next', () => ({
  useTranslation: () => ({
    t: (key: string, vars?: Record<string, unknown>) =>
      vars && 'count' in vars ? `${key}:${String(vars.count)}` : key,
    i18n: { language: 'zh-CN' },
  }),
}));

const { IssueTrackerFeatureLayout } = await import('../IssueTrackerFeatureLayout');
const { useMyIssues: realUseMyIssues } =
  await vi.importActual<typeof import('../hooks/useMyIssues')>('../hooks/useMyIssues');

function item(over: Partial<MyIssueItem> = {}): MyIssueItem {
  return {
    number: 1061,
    url: 'https://github.com/makecindy/cindy/issues/1061',
    title: '已经加载出来的那条 issue',
    type: 'feature',
    state: 'open',
    createdAt: '2026-07-30T09:12:49Z',
    updatedAt: null,
    commentCount: null,
    sources: ['cindy-tool'],
    ...over,
  };
}

function result(items: MyIssueItem[], over: Partial<MyIssuesResult> = {}): MyIssuesResult {
  return {
    items,
    githubEnhancement: null,
    githubEnhancementFailed: false,
    degraded: null,
    truncated: false,
    ...over,
  };
}

/**
 * 默认 hasFreshData=true("这一轮查过了"),因为多数用例断言的是查完之后的形态。
 * 首屏 / 快照顶上来的场景要显式传 false。
 */
function state(over: Record<string, unknown> = {}) {
  return {
    data: null,
    hasFreshData: true,
    loading: false,
    refreshing: false,
    error: null,
    refresh: vi.fn(),
    ...over,
  };
}

beforeEach(() => {
  useMyIssuesMock.mockReset();
  Object.defineProperty(window, 'electronAPI', {
    configurable: true,
    value: { openExternal: vi.fn() },
  });
});

afterEach(() => {
  cleanup();
});

describe('IssueTrackerFeatureLayout 内容区分支', () => {
  it('keeps connect hidden when search fails for a resolved GitHub account', () => {
    const connected = result([], { githubEnhancement: { login: 'test', source: 'gh-cli' } });
    useMyIssuesMock.mockReturnValue(state({ data: connected }));
    const { rerender } = render(<IssueTrackerFeatureLayout />);
    expect(screen.queryByText('ccAgent.gitContext.pr.setup.stages.login.title')).toBeNull();
    useMyIssuesMock.mockReturnValue(
      state({ data: { ...connected, githubEnhancementFailed: true } }),
    );
    rerender(<IssueTrackerFeatureLayout />);
    expect(screen.queryByText('ccAgent.gitContext.pr.setup.stages.login.title')).toBeNull();
    useMyIssuesMock.mockReturnValue(state({ data: result([], { githubEnhancementFailed: true }) }));
    rerender(<IssueTrackerFeatureLayout />);
    expect(screen.getByText('ccAgent.gitContext.pr.setup.stages.login.title')).toBeTruthy();
  });
  it('connects GitHub without hiding existing issues and refreshes after success', async () => {
    useMyIssuesMock.mockImplementation(realUseMyIssues);
    const list = vi
      .fn()
      .mockResolvedValueOnce({ success: true, ...result([item()]) })
      .mockResolvedValue({
        success: true,
        ...result([item()], { githubEnhancement: { source: 'gh-cli', login: 'test' } }),
      });
    let connected!: () => void;
    Object.assign(window.electronAPI, {
      maker: { listMyIssues: list, getMyIssuesSnapshot: async () => null },
      gitContext: {
        onGithubConnected: (listener: () => void) => {
          connected = listener;
          return () => {};
        },
        githubSetupStatus: async () => ({ phase: 'connected' }),
        startGithubSetup: async () => {
          connected();
          return { phase: 'connected' };
        },
      },
    });
    render(<IssueTrackerFeatureLayout />);
    await screen.findByText('已经加载出来的那条 issue');
    fireEvent.click(screen.getByText('ccAgent.gitContext.pr.setup.stages.login.title'));
    fireEvent.click(await screen.findByText('ccAgent.gitContext.pr.setup.connect'));
    await waitFor(() => expect(list).toHaveBeenCalledTimes(2));
    expect(list).toHaveBeenLastCalledWith({ force: true });
    expect(screen.getByText('已经加载出来的那条 issue')).toBeTruthy();
    expect(screen.queryByText('ccAgent.gitContext.pr.setup.stages.login.title')).toBeNull();
    // Hiding the entry must not tear down the success dialog before Done is clicked.
    fireEvent.click(screen.getByText('ccAgent.gitContext.pr.setup.done'));
    expect(screen.queryByRole('dialog')).toBeNull();
    expect(list).toHaveBeenCalledTimes(2);
  });
  it('刷新失败但已有数据:保留列表,错误降级成提示条', () => {
    useMyIssuesMock.mockReturnValue(state({ data: result([item()]), error: 'ECONNRESET' }));
    render(<IssueTrackerFeatureLayout />);

    // 列表还在,用户不丢内容。
    expect(screen.getByText('已经加载出来的那条 issue')).toBeTruthy();
    // 失败信息以提示条形式出现,而且不是整页错误态。
    expect(screen.getAllByText('issueTracker.list.loadFailed').length).toBe(1);
    expect(screen.getAllByText('issueTracker.list.retry').length).toBe(1);
  });

  it('重试进行中:保留失败提示但禁用重试按钮(不清 error,避免消失又出现两次跳变)', () => {
    useMyIssuesMock.mockReturnValue(
      state({ data: result([item()]), error: 'unexpected', refreshing: true }),
    );
    render(<IssueTrackerFeatureLayout />);

    // 提示条仍在 —— 清掉它会让界面在刷新期间变一次、失败后再变回来。
    expect(screen.getByText('issueTracker.list.loadFailed')).toBeTruthy();
    // 但按钮不可再点:否则它看着可点、点了却被 in-flight 静默挡掉。
    expect(screen.getByText('issueTracker.list.retry').hasAttribute('disabled')).toBe(true);
  });

  it('从未加载成功过:才用整页错误态', () => {
    useMyIssuesMock.mockReturnValue(state({ data: null, error: 'ECONNRESET' }));
    render(<IssueTrackerFeatureLayout />);

    expect(screen.getByText('issueTracker.list.loadFailed')).toBeTruthy();
    expect(screen.queryByText('已经加载出来的那条 issue')).toBeNull();
  });

  it('首屏取数期间保留引导内容,不换成 loading 文案(engineering-conventions §7)', () => {
    // 平台通道总 deadline 可达 12s。换成一行「加载中」会造成 引导 → loading → 列表
    // 两次跳变;而一条都没有的用户(最常见)看到的引导页本该从头到尾没动过。
    useMyIssuesMock.mockReturnValue(state({ loading: true, data: null, hasFreshData: false }));
    render(<IssueTrackerFeatureLayout />);

    // 引导正文与 CTA 在场,但**一个标题都不渲染** —— 标题是结论,这时还没查完。
    // 上一版这里显示「暂时查不到你的 Issue」,GitHub 上有几十条的用户会先被这句话骗一次。
    expect(screen.getByRole('button', { name: 'issueTracker.mine.startIssueChat' })).toBeTruthy();
    expect(screen.queryByText('issueTracker.mine.emptyTitle')).toBeNull();
    expect(screen.queryByText('issueTracker.mine.emptyTitleUnverified')).toBeNull();
    expect(screen.queryByText('issueTracker.detail.loading')).toBeNull();
  });

  it('落盘快照顶上来时同样不下结论 —— 快照的空列表不算查证过', () => {
    // useMyIssues 用快照合成 data(degraded/failed 都填「没问题」),但 hasFreshData 仍为
    // false。若标题只看 canTrustEmptyList,这里会冒出「还没有提交过 Issue」。
    useMyIssuesMock.mockReturnValue(state({ data: result([]), hasFreshData: false }));
    render(<IssueTrackerFeatureLayout />);

    expect(screen.queryByText('issueTracker.mine.emptyTitle')).toBeNull();
    expect(screen.queryByText('issueTracker.mine.emptyTitleUnverified')).toBeNull();
  });

  it('首屏取数完成后引导原子切成列表 —— 中间不经过第三种形态', () => {
    useMyIssuesMock.mockReturnValue(state({ loading: true, data: null, hasFreshData: false }));
    const view = render(<IssueTrackerFeatureLayout />);
    expect(screen.getByRole('button', { name: 'issueTracker.mine.startIssueChat' })).toBeTruthy();

    useMyIssuesMock.mockReturnValue(state({ loading: false, data: result([item()]) }));
    view.rerender(<IssueTrackerFeatureLayout />);
    expect(screen.getByText('已经加载出来的那条 issue')).toBeTruthy();
  });

  it('有快照时首屏直接出列表 —— 常见路径上不存在等待态', () => {
    useMyIssuesMock.mockReturnValue(
      state({ loading: true, data: result([item()]), hasFreshData: false }),
    );
    render(<IssueTrackerFeatureLayout />);

    expect(screen.getByText('已经加载出来的那条 issue')).toBeTruthy();
    // 快照态不显示任何降级提示(快照刻意不含本次查询的健康状况)。
    expect(screen.queryByText('issueTracker.mine.platformUnavailableHint')).toBeNull();
  });

  it('空列表:三路都真查过且成功才敢说「还没有提交过」', () => {
    // githubEnhancement 必须非 null —— 没配增强时 GitHub 账号那一路根本没查过,
    // 不能确证(判据见 canTrustEmptyList)。
    useMyIssuesMock.mockReturnValue(
      state({
        data: result([], { githubEnhancement: { login: 'octocat', source: 'ghost' } }),
      }),
    );
    render(<IssueTrackerFeatureLayout />);
    expect(screen.getByText('issueTracker.mine.emptyTitle')).toBeTruthy();
  });

  it('空列表但没配增强:改说「暂时查不到」', () => {
    useMyIssuesMock.mockReturnValue(state({ data: result([], { githubEnhancement: null }) }));
    render(<IssueTrackerFeatureLayout />);
    expect(screen.getByText('issueTracker.mine.emptyTitleUnverified')).toBeTruthy();
    expect(screen.queryByText('issueTracker.mine.emptyTitle')).toBeNull();
  });

  it('空列表 + 任一路没查成:改说「暂时查不到」,不断言用户从未提交', () => {
    // 用户在 GitHub 上有几十条 issue、只是这次没查到,页面却说「还没有提交过」——
    // 这正是本次要修的现场(平台接口未上线 + 插件 PAT 搜不动本仓)。
    for (const over of [
      { degraded: 'platform-unavailable' as const },
      { degraded: 'fetch-failed' as const },
      { githubEnhancementFailed: true },
    ]) {
      useMyIssuesMock.mockReturnValue(state({ data: result([], over) }));
      const view = render(<IssueTrackerFeatureLayout />);
      expect(screen.getByText('issueTracker.mine.emptyTitleUnverified')).toBeTruthy();
      expect(screen.queryByText('issueTracker.mine.emptyTitle')).toBeNull();
      view.unmount();
    }
  });

  it('一条都没有:显示空态引导,不显示常驻说明条(避免与引导里的说明重复)', () => {
    useMyIssuesMock.mockReturnValue(
      state({
        data: result([], { githubEnhancement: { login: 'octocat', source: 'ghost' } }),
      }),
    );
    render(<IssueTrackerFeatureLayout />);

    expect(screen.getByText('issueTracker.mine.emptyTitle')).toBeTruthy();
    // 空态与常驻条都含可点击的 /issue;空态时只应有一个。
    expect(screen.getAllByRole('button', { name: 'issueTracker.mine.startIssueChat' }).length).toBe(
      1,
    );
  });

  it('有数据:顶部常驻说明条在场', () => {
    useMyIssuesMock.mockReturnValue(state({ data: result([item()]) }));
    render(<IssueTrackerFeatureLayout />);

    expect(screen.getAllByRole('button', { name: 'issueTracker.mine.startIssueChat' }).length).toBe(
      1,
    );
    expect(screen.queryByText('issueTracker.mine.emptyTitle')).toBeNull();
  });
});