Skip to content

armgit / cindy

Public Imported from GitHub
0

Consider it done. The open-source AI agent that works out of the box · 想到,就能做到。开源、开箱即用的 AI Agent。

fix(orca): 修正繁体提示并验证模型行展示

DavidShen0638a1963b20
diff --git a/apps/desktop/src/renderer/features/cc-agent/__tests__/workerEffortLabel.test.ts b/apps/desktop/src/renderer/features/cc-agent/__tests__/workerEffortLabel.test.ts
index 5e5a1e1f6d..9bc5b2588d 100644
--- a/apps/desktop/src/renderer/features/cc-agent/__tests__/workerEffortLabel.test.ts
+++ b/apps/desktop/src/renderer/features/cc-agent/__tests__/workerEffortLabel.test.ts
@@ -1,8 +1,5 @@
// @vitest-environment jsdom
-import { readFileSync } from 'node:fs';
-import { resolve } from 'node:path';
-
import { cleanup, fireEvent, render, screen } from '@testing-library/react';
import { createElement } from 'react';
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
@@ -10,11 +7,6 @@ import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
import type { WorkerInfo } from '../hooks/useWorkers';
import { RolePillDropdown, WorkerListToolbar } from '../RolePillDropdown';
-const source = readFileSync(resolve(__dirname, '..', 'RolePillDropdown.tsx'), 'utf8').replace(
- /\r\n?/g,
- '\n',
-);
-
vi.mock('react-i18next', () => ({
useTranslation: () => ({ t: (key: string) => key }),
}));
@@ -77,30 +69,74 @@ describe('RolePillDropdown worker effort label', () => {
expect(screen.queryByLabelText(/^effort /)).toBeNull();
});
- it('uses the same model line in the summary, tabs menu, and dropdown list', () => {
- const current = worker();
+ it.each(
+ ['summary', 'tabs menu', 'dropdown list'].flatMap((surface) =>
+ ['local', 'remote', 'offline remote'].map((kind) => ({ surface, kind })),
+ ),
+ )('shows a consistent model line for a $kind worker in the $surface', async ({ surface, kind }) => {
+ const current = worker({
+ executionDevice:
+ kind === 'local'
+ ? undefined
+ : {
+ deviceId: 'mac-mini',
+ remoteSessionId: 'remote-a',
+ deviceName: 'Mac mini',
+ reachable: kind !== 'offline remote',
+ workingDir: null,
+ },
+ });
+ const props = {
+ worker: current,
+ workers: [current],
+ selectedWorkerId: current.workerId,
+ activeWorkerCount: 1,
+ onSwitchFocus: vi.fn(),
+ onArchiveWorker: vi.fn(),
+ };
render(
- createElement(WorkerListToolbar, {
- worker: current,
- workers: [current],
- selectedWorkerId: current.workerId,
- activeWorkerCount: 1,
- softLimit: 5,
- hardLimit: 8,
- onSwitchFocus: vi.fn(),
- onOpenCreate: vi.fn(),
- onOpenSettings: vi.fn(),
- onArchiveWorker: vi.fn(),
- }),
+ surface === 'dropdown list'
+ ? createElement(RolePillDropdown, props)
+ : createElement(WorkerListToolbar, {
+ ...props,
+ softLimit: 5,
+ hardLimit: 8,
+ onOpenCreate: vi.fn(),
+ onOpenSettings: vi.fn(),
+ }),
);
- fireEvent.click(screen.getByRole('button', { name: 'orca.rolePill.layoutMenuLabel' }));
- expect(screen.getByText('gpt-5.6-sol')).toBeTruthy();
- expect(screen.getByText('· effortLevels.xhigh')).toBeTruthy();
+ if (surface === 'tabs menu') {
+ fireEvent.click(screen.getByRole('button', { name: 'orca.rolePill.layoutMenuLabel' }));
+ } else if (surface === 'summary') {
+ fireEvent.focus(screen.getByRole('button', { name: /developer/ }));
+ } else {
+ fireEvent.click(screen.getByRole('button', { name: /developer/ }));
+ }
+
+ if (kind === 'offline remote') {
+ await screen.findAllByText('orca.rolePill.deviceUnreachable');
+ expect(screen.queryByText('gpt-5.6-sol')).toBeNull();
+ expect(screen.queryByText('· effortLevels.xhigh')).toBeNull();
+ } else {
+ const models = await screen.findAllByText('gpt-5.6-sol');
+ const efforts = screen.getAllByText('· effortLevels.xhigh');
+ expect(models).toHaveLength(efforts.length);
+ models.forEach((model, index) => {
+ expect(model.parentElement).toBe(efforts[index]!.parentElement);
+ expect(model.classList.contains('truncate')).toBe(true);
+ expect(efforts[index]!.classList.contains('shrink-0')).toBe(true);
+ expect(model.parentElement?.classList.contains('text-12')).toBe(true);
+ expect(model.parentElement?.classList.contains('text-[var(--text-secondary)]')).toBe(true);
+ });
+ expect(screen.queryByText('orca.rolePill.deviceUnreachable')).toBeNull();
+ }
+ if (kind !== 'local') {
+ expect(screen.getAllByText('Mac mini').length).toBeGreaterThan(0);
+ } else {
+ expect(screen.queryByText('Mac mini')).toBeNull();
+ }
expect(screen.queryByLabelText(/^effort /)).toBeNull();
-
- expect(source.match(/<WorkerModelLine\b/g)).toHaveLength(3);
- expect(source).toContain('<WorkerModelLine model={worker.model} effort={worker.effort} />');
});
it('hides unknown or missing effort instead of falling back to medium', () => {
diff --git a/apps/desktop/src/renderer/i18n/locales/zh-TW/common.json b/apps/desktop/src/renderer/i18n/locales/zh-TW/common.json
index 95abf3dd73..7ad052c9a3 100644
--- a/apps/desktop/src/renderer/i18n/locales/zh-TW/common.json
+++ b/apps/desktop/src/renderer/i18n/locales/zh-TW/common.json
@@ -13407,7 +13407,7 @@
"remoteDirLabel": "{{device}} 上的工作目錄",
"remoteDirChat": "對話",
"remoteDirPath": "指定目錄",
- "remoteDirChatHint": "在 {{device}} 上建立對話任務,不綁定專案。",
+ "remoteDirChatHint": "在 {{device}} 上建立對話任務,不連結專案。",
"remoteDirPathHint": "在 {{device}} 上檢查;不存在時報錯,不會換成這台電腦的目錄。",
"remoteDirInvalid": "請輸入 {{device}} 上的絕對路徑。",
"errors": {