Skip to content

armgit / cindy

Public Imported from GitHub
0

Consider it done. The open-source AI agent that works out of the box · 想到,就能做到。开源、开箱即用的 AI Agent。

fix(plugins): 隐藏缺失共享统计并调整使用次数图标

nana08595f4ae79d
diff --git a/apps/desktop/src/renderer/features/plugin/PluginSharedUsage.tsx b/apps/desktop/src/renderer/features/plugin/PluginSharedUsage.tsx
index ecd69a5db0..ed07da9b7c 100644
--- a/apps/desktop/src/renderer/features/plugin/PluginSharedUsage.tsx
+++ b/apps/desktop/src/renderer/features/plugin/PluginSharedUsage.tsx
@@ -1,4 +1,4 @@
-import { PackageCheck, Zap } from 'lucide-react';
+import { PackageCheck, Tally5 } from 'lucide-react';
import { useTranslation } from 'react-i18next';
import { Tip } from '@/components/ui/tooltip';
import type { PluginMarketItem } from '../../../shared/pluginMarket';
@@ -8,10 +8,11 @@ export function PluginSharedUsage({ detail }: { detail: PluginMarketItem }) {
const { t } = useTranslation();
if (detail.sourceType !== 'server' || detail.scope === 'personal') return null;
const stats = detail.usageStatistics;
+ if (!stats) return null;
const explanation =
t('settings.ghosts.usage.sharedExplanation', {
scope: t(`settings.ghosts.usage.sharedScope.${detail.scope}`),
- }) + (stats ? ` ${t('settings.ghosts.usage.asOf', { time: stats.asOf })}` : '');
+ }) + ` ${t('settings.ghosts.usage.asOf', { time: stats.asOf })}`;
return (
<>
<span aria-hidden="true">·</span>
@@ -23,7 +24,7 @@ export function PluginSharedUsage({ detail }: { detail: PluginMarketItem }) {
<PackageCheck size={12} aria-hidden="true" />
<span>
{t('settings.ghosts.usage.installs')}{' '}
- {stats?.installationCount ?? t('settings.ghosts.usage.sharedUnavailable')}
+ {stats.installationCount}
</span>
</button>
</Tip>
@@ -32,10 +33,10 @@ export function PluginSharedUsage({ detail }: { detail: PluginMarketItem }) {
type="button"
className="inline-flex min-h-7 items-center gap-1 rounded-full focus-visible:ring-2 focus-visible:ring-[var(--focus-ring)]"
>
- <Zap size={12} aria-hidden="true" />
+ <Tally5 size={12} aria-hidden="true" />
<span>
{t('settings.ghosts.usage.uses')}{' '}
- {stats?.usageCount ?? t('settings.ghosts.usage.sharedUnavailable')}
+ {stats.usageCount}
</span>
</button>
</Tip>
diff --git a/apps/desktop/src/renderer/features/plugin/__tests__/PluginUsageCard.test.tsx b/apps/desktop/src/renderer/features/plugin/__tests__/PluginUsageCard.test.tsx
index 573aec8b33..6655f5ab11 100644
--- a/apps/desktop/src/renderer/features/plugin/__tests__/PluginUsageCard.test.tsx
+++ b/apps/desktop/src/renderer/features/plugin/__tests__/PluginUsageCard.test.tsx
@@ -65,10 +65,10 @@ it('distinguishes unavailable from actual zero with no invented usage', async ()
await screen.findByText('settings.ghosts.usage.never');
expect(screen.getByText('0')).toBeTruthy();
});
-it('only shows authorized server aggregates and keeps missing fields distinct from zero', () => {
+it('hides missing shared statistics and preserves an explicitly reported zero', () => {
const detail = { sourceType: 'server', scope: 'public' } as PluginMarketItem;
const view = render(<PluginSharedUsage detail={detail} />);
- expect(screen.getAllByText(/sharedUnavailable/)).toHaveLength(2);
+ expect(view.container.childElementCount).toBe(0);
view.rerender(
<PluginSharedUsage
detail={{
@@ -83,6 +83,24 @@ it('only shows authorized server aggregates and keeps missing fields distinct fr
/>,
);
expect(screen.getByText('settings.ghosts.usage.installs 0')).toBeTruthy();
- view.rerender(<PluginSharedUsage detail={{ ...detail, sourceType: 'git-market' }} />);
+ expect(screen.getByText('settings.ghosts.usage.uses 10')).toBeTruthy();
+ view.rerender(<PluginSharedUsage detail={detail} />);
+ expect(view.container.childElementCount).toBe(0);
+});
+it.each([
+ ['git-market', 'public'],
+ ['server', 'personal'],
+])('hides aggregates outside the authorized scope (%s, %s)', (sourceType, scope) => {
+ const detail = {
+ sourceType,
+ scope,
+ usageStatistics: {
+ installationCount: '12',
+ usageCount: '10',
+ usageCountLast7Days: '5',
+ asOf: '2026-10-12T00:00:00.000Z',
+ },
+ } as PluginMarketItem;
+ const view = render(<PluginSharedUsage detail={detail} />);
expect(view.container.textContent).toBe('');
});
diff --git a/docs/plugin-usage-statistics-implementation.md b/docs/plugin-usage-statistics-implementation.md
index 00fdac3b9e..e197ac3373 100644
--- a/docs/plugin-usage-statistics-implementation.md
+++ b/docs/plugin-usage-statistics-implementation.md
@@ -18,8 +18,8 @@
最近任务先过滤删除,再去重排序 LIMIT 3,标题实时读取。跳转复用现有伙伴/普通/Orca 任务入口。
卡片以账户代际为 key,避免切号后保留旧账户的显示结果。
- 未安装详情在版本后展示带图标的共享安装/使用指标及口径说明;公共与企业插件只使用服务端
- 已授权响应,custom/public 标记不扩大共享范围。缺失字段显示暂不可用,真实字符串 `"0"`
- 才显示 0。Light/Dark 均走语义 token,五种语言同步。
+ 已授权响应,custom/public 标记不扩大共享范围。缺失统计时整段隐藏(含分隔点),真实字符串
+ `"0"` 才显示 0;使用次数采用用户选定的 `Tally5` 计数刻度图标。Light/Dark 均走语义 token,五种语言同步。
## 服务端依赖与协议
@@ -39,7 +39,7 @@
}
```
-计数是非负十进制字符串;非法或缺失的可选统计视为暂不可用,不让整个市场响应失败。
+计数是非负十进制字符串;非法或缺失的可选统计隐藏,不让整个市场响应失败。
安装次数必须来自成功安装回执:普通升级不增加,成功重装新增,卸载不倒扣。
使用次数为已接收的派发事件。企业响应必须沿原有 visibilityAudience/部门/角色授权过滤。
服务端仍需实现成功安装回执、幂等调用批量接收和授权聚合查询,接口建议见原方案第 12 节。
@@ -74,3 +74,12 @@ outbox 文件、定时发送器、联网重试或对历史个人记录的补传
- 异步数据库写入在崩溃、磁盘故障或绑定尚未就绪时可能漏记,未承诺计费级 exactly-once。
- 普通退出、切号和企业下架沿原有生命周期;未扩展账户删除系统,未声称注销已物理擦除数据库。
- 本次仅本地交付;没有 push、创建 PR、合并或部署。插件基座变更仍需指定维护者 Approve 才能合并。
+
+## 2026-10-12 展示修订
+
+- 根据用户反馈,市场头部无统计数据时隐藏整段指标和分隔点;已有明确的 0 仍正常显示。
+ 用户选择 `Tally5` 替换快速模式已使用的 `Zap`。不改变个人卡片的空记录呈现。
+- 两个相关组件测试文件共 12 项通过,Desktop 类型检查、相关文件 ESLint 和 diff 检查通过。
+- 在本 worktree 独立 Electron 开发版中通过前端热更新查看真实 TapTap Maker 详情,Light/Dark
+ 均已目检无统计时的头部;截图位于 `apps/desktop/logs/plugin-usage-acceptance/shared-usage-followup/`。
+ 服务端当前未提供统计,带数字与新图标的真实市场状态尚未实机验证;没有伪造市场数字。