Skip to content

armgit / cindy

Public Imported from GitHub
0

Consider it done. The open-source AI agent that works out of the box · 想到,就能做到。开源、开箱即用的 AI Agent。

fix(remote-agent): normalize empty agent device IDs

MagicLizi094d212a8b47
diff --git a/packages/maker-core/src/maker.agentDevice.test.ts b/packages/maker-core/src/maker.agentDevice.test.ts
index 276b26b507..348125a57a 100644
--- a/packages/maker-core/src/maker.agentDevice.test.ts
+++ b/packages/maker-core/src/maker.agentDevice.test.ts
@@ -140,6 +140,19 @@ describe('Maker: agent on another computer', () => {
await maker.shutdown();
});
+ it('treats an empty agent device id as local at the send boundary', async () => {
+ const agent = localAgent();
+ const startDeviceAgentSession = vi.fn(async () => handle('remote-sdk'));
+ const maker = new Maker({ agents: { pi: agent }, storage: storage(), logger, startDeviceAgentSession });
+ const session = await maker.createSession({
+ id: 'task-empty-device', agentKind: 'pi', workingDir: '/repo', model: 'm', agentDeviceId: '',
+ });
+ expect(startDeviceAgentSession).not.toHaveBeenCalled();
+ expect(agent.startSession).toHaveBeenCalledTimes(1);
+ expect(session.agentDeviceId).toBeNull();
+ await maker.shutdown();
+ });
+
it('refuses to mix with SSH hosts and reports a missing starter instead of running here', async () => {
const maker = new Maker({ agents: { pi: localAgent() }, storage: storage(), logger });
await expect(maker.createSession({ id: 't2', agentKind: 'pi', workingDir: '/repo', model: 'm', agentDeviceId: 'dev-b' }))
diff --git a/packages/maker-core/src/maker.ts b/packages/maker-core/src/maker.ts
index 576042c8cd..ea3b2fde95 100644
--- a/packages/maker-core/src/maker.ts
+++ b/packages/maker-core/src/maker.ts
@@ -1065,7 +1065,7 @@ export class Maker {
// (不用每次 send 回 DB 读 SessionMeta — register.ts checkWorkDirExists 走这条)。
remoteHostId: meta.remoteHostId ?? null,
// 取实际决定启动分支的 startOpts:任务记录事后读回的旧值不能把本机启动的会话标成远端。
- agentDeviceId: startOpts.agentDeviceId ?? null,
+ agentDeviceId: startOpts.agentDeviceId || null,
// 层 B:视觉桥钩子(per-session 优先,否则全局默认;缺省不传 = 零干扰)。
visionBridge: startOpts.visionBridge ?? this.visionBridge,
toolLoopReviewer: this.toolLoopReviewer,