Consider it done. The open-source AI agent that works out of the box · 想到,就能做到。开源、开箱即用的 AI Agent。
TypeScript agentai-agentai-assistantandroidclaude-codecodexelectroniosllmmacosreact-nativetypescriptwindows
fix(mobile): 文件预览翻页后相邻页音视频还在后台继续播
MagicLizi11220e87de6e
diff --git a/apps/mobile/app/files/preview/[sessionId].tsx b/apps/mobile/app/files/preview/[sessionId].tsxindex 329ae1c5e9..c502a89e1e 100644--- a/apps/mobile/app/files/preview/[sessionId].tsx+++ b/apps/mobile/app/files/preview/[sessionId].tsx@@ -767,7 +767,7 @@ function FilePreviewPage({}const avKind = avKindFor(item.relPath);if (avKind) {- return <AvPreviewPage active={active} exportToUrl={exportToUrl} item={item} kind={avKind} onDownload={onDownload} workdir={workdir} />;+ return <AvPreviewPage active={active} exportToUrl={exportToUrl} item={item} kind={avKind} onDownload={onDownload} visible={visible} workdir={workdir} />;}if (item.thumb === 'doc') {return (@@ -794,13 +794,14 @@ function FilePreviewPage({return <UnsupportedPage item={item} onDownload={onDownload} reason={t('files.preview.unsupportedType')} />;}-/** 音视频页:导出→presign→复用消息同款播放器(切后台/换页自动暂停)。 */+/** 音视频页:导出→presign→复用消息同款播放器(切后台/翻页失活自动暂停,回到本页不自动续播)。 */function AvPreviewPage({active,exportToUrl,item,kind,onDownload,+ visible,workdir,}: {active: boolean;@@ -808,6 +809,8 @@ function AvPreviewPage({item: FileBrowserGridItem;kind: 'video' | 'audio';onDownload(): void;+ /** 是否真正可见的当前页:失活(翻页/压栈)时暂停播放,见 RemoteMediaPlayerWebView。 */+ visible: boolean;workdir: string;}) {const styles = useThemedStyles(makeStyles);@@ -864,6 +867,7 @@ function AvPreviewPage({testID="filePreview.avPlayer"title={item.name}url={url}+ visible={visible}/></View>);diff --git a/apps/mobile/src/__tests__/filePreviewPagerWiring.test.ts b/apps/mobile/src/__tests__/filePreviewPagerWiring.test.tsindex 8d3e282513..26bf9e0c7b 100644--- a/apps/mobile/src/__tests__/filePreviewPagerWiring.test.ts+++ b/apps/mobile/src/__tests__/filePreviewPagerWiring.test.ts@@ -70,6 +70,35 @@ describe('remote file preview pager wiring', () => {expect(source).toMatch(/avPlayer: \{[^}]*\bflex: 1\b[^}]*\}/);expect(source).toContain('style={styles.avPlayer}');});++ it('pins every link of the player height chain, not just avPlayer (review P2)', () => {+ // 上一条只看 avPlayer 自己的 flex: 1 —— 外层 avPage / 分页容器一旦失去高度约束,+ // 用例照样绿,播放器又会塌成 0(review P2)。高度链每一环都要钉住:+ // 1) 分页 cell 只定宽,高度靠横向 FlatList 的行向拉伸(默认 alignItems: stretch+ // 把 cell 拉到 pager 高度)+ RN ScrollView 的隐式 flexGrow 填满 safeArea;+ // cell 改成按内容收高即破。+ expect(source).toContain('<View style={{ width: pageWidth }}>');+ // 2) avPlayer 的父级 avPage 以 flex: 1 占满 cell。+ expect(source).toMatch(/avPage: \{[^}]*\bflex: 1\b[^}]*\}/);+ // 3) 预览屏根容器把高度传给 pager。+ expect(source).toMatch(/safeArea: \{[^}]*\bflex: 1\b[^}]*\}/);+ // 4) 链条最里层:WebView 以 flex: 1 填满 RemoteMediaPlayerWebView 的样式外层。+ const playerSource = readSource('src/session/mediaPlayerWebView.tsx');+ expect(playerSource).toContain("style={{ backgroundColor: 'transparent', flex: 1 }}");+ });++ it('pauses the audio/video player when its preview page becomes inactive', () => {+ // pager 用 windowSize={3} 保留相邻页,相邻页的 active 仍为 true —— 可见性(visible+ // = screenFocused && 当前页)必须一路传进播放器,翻页失活时暂停,否则上一页的+ // 媒体在后台继续播(review P1)。+ const filePage = source.slice(source.indexOf('function FilePreviewPage('), source.indexOf('function AvPreviewPage('));+ expect(filePage).toMatch(/<AvPreviewPage[^>]*visible=\{visible\}[^>]*\/>/);+ const avPage = source.slice(source.indexOf('function AvPreviewPage('), source.indexOf('function PdfPreviewPage('));+ expect(avPage).toMatch(/<RemoteMediaPlayerWebView[^>]*visible=\{visible\}[^>]*\/>/);+ // 判定落在纯生命周期模块(行为级用例在 mediaPlayerWebView.test.ts),载体只发 pause。+ const playerSource = readSource('src/session/mediaPlayerWebView.tsx');+ expect(playerSource).toContain('if (lifecycleRef.current.onVisibilityChange(visible)) pausePlayback();');+ });});const htmlReaderSource = readSource('src/session/HtmlFileReader.tsx');diff --git a/apps/mobile/src/__tests__/mediaPlayerWebView.test.ts b/apps/mobile/src/__tests__/mediaPlayerWebView.test.tsindex 7ff264afa4..f250a78b46 100644--- a/apps/mobile/src/__tests__/mediaPlayerWebView.test.ts+++ b/apps/mobile/src/__tests__/mediaPlayerWebView.test.ts@@ -24,6 +24,20 @@ describe('mediaPlayerWebView', () => {expect(lifecycle.consumeReloadOnActive()).toBe(true);});+ it('pauses when its page becomes inactive and never auto-resumes on return', () => {+ const lifecycle = createMediaPlayerWebViewLifecycle();++ // 翻到本页 / 重复可见:无动作 —— 不代用户播放。+ expect(lifecycle.onVisibilityChange(true)).toBe(false);+ // 滑到相邻页 / 屏被压栈:暂停一次。+ expect(lifecycle.onVisibilityChange(false)).toBe(true);+ // 持续失活不重复发暂停。+ expect(lifecycle.onVisibilityChange(false)).toBe(false);+ // 回到本页不自动续播(播放权交还用户),下次失活再暂停。+ expect(lifecycle.onVisibilityChange(true)).toBe(false);+ expect(lifecycle.onVisibilityChange(false)).toBe(true);+ });+it('builds a video player document with controls and source metadata', () => {const html = buildMediaPlayerWebViewHtml({kind: 'video',diff --git a/apps/mobile/src/session/mediaPlayerWebView.tsx b/apps/mobile/src/session/mediaPlayerWebView.tsxindex 7d4ec651d5..9087c13da7 100644--- a/apps/mobile/src/session/mediaPlayerWebView.tsx+++ b/apps/mobile/src/session/mediaPlayerWebView.tsx@@ -22,6 +22,7 @@ export function RemoteMediaPlayerWebView({testID,title,url,+ visible = true,}: {kind: MobileMediaPlayerKind;mimeType?: string;@@ -30,6 +31,8 @@ export function RemoteMediaPlayerWebView({testID?: string;title?: string;url: string;+ /** 所在页是否为当前可见页:失活(翻页/压栈)时暂停播放,回到本页不自动续播。缺省 true(消息卡片等无翻页场景)。 */+ visible?: boolean;}) {const { colors } = useTheme();const webViewRef = useRef<ComponentRef<typeof WebView>>(null);@@ -58,6 +61,14 @@ export function RemoteMediaPlayerWebView({webViewRef.current?.stopLoading();}, [pausePlayback]);+ // 失活即暂停(review P1):预览 pager 用 windowSize={3} 保留相邻页,相邻页的+ // active 仍为 true,不把可见性接进播放器的话,用户滑走后上一页的媒体还在后台+ // 继续播。判定在纯生命周期模块(行为级用例在 mediaPlayerWebView.test.ts),+ // 这里只发 pause 命令;回到本页不自动续播,播放权交还用户。+ useEffect(() => {+ if (lifecycleRef.current.onVisibilityChange(visible)) pausePlayback();+ }, [pausePlayback, visible]);+useEffect(() => {const subscription = AppState.addEventListener('change', state => {if (state !== 'active') {diff --git a/apps/mobile/src/session/mediaPlayerWebViewLifecycle.ts b/apps/mobile/src/session/mediaPlayerWebViewLifecycle.tsindex 647e3fc2b1..80999a82dc 100644--- a/apps/mobile/src/session/mediaPlayerWebViewLifecycle.ts+++ b/apps/mobile/src/session/mediaPlayerWebViewLifecycle.ts@@ -1,6 +1,7 @@export function createMediaPlayerWebViewLifecycle() {let loading = true;let reloadOnActive = false;+ let visible = true;return {onLoadStart() {@@ -18,5 +19,14 @@ export function createMediaPlayerWebViewLifecycle() {loading = true;return true;},+ /**+ * 页面可见性沿(翻页 / 屏被压栈失活)。返回 true 表示该暂停一次:+ * 只在「可见 → 失活」沿触发,持续失活不重复暂停,回到本页也不代用户续播。+ */+ onVisibilityChange(next: boolean) {+ const becameHidden = visible && !next;+ visible = next;+ return becameHidden;+ },};}