Skip to content

armgit / cindy

Public Imported from GitHub
0

Consider it done. The open-source AI agent that works out of the box · 想到,就能做到。开源、开箱即用的 AI Agent。

fix(desktop): render managed markdown videos as previews

Lizi300682437fb3
diff --git a/apps/desktop/src/renderer/components/chat/MarkdownRenderer.tsx b/apps/desktop/src/renderer/components/chat/MarkdownRenderer.tsx
index db0a5afb61..cf6ecef558 100644
--- a/apps/desktop/src/renderer/components/chat/MarkdownRenderer.tsx
+++ b/apps/desktop/src/renderer/components/chat/MarkdownRenderer.tsx
@@ -113,6 +113,8 @@ import { ProjectLinkChip } from './ProjectLinkChip';
import { ImageLightbox } from './ImageLightbox';
import { ImageHoverPreview } from './ImageHoverPreview';
import { ImageMissingPlaceholder } from './ImageMissingPlaceholder';
+import { ChatVideoView } from './ChatVideoView';
+import { isManagedMarkdownVideoUrl, markdownMediaFilename } from './markdownMedia';
import { MarkdownDiffBlock } from './MarkdownDiffBlock';
import { MarkdownMermaidBlock } from './MarkdownMermaidBlock';
import { TextLightbox } from './TextLightbox';
@@ -294,14 +296,16 @@ const INLINE_CODE_CLASS = 'font-mono text-14 rounded-[6px] px-[0.4em] py-[0.2em]
const WINDOWS_ABSOLUTE_HREF_RE = /^[A-Za-z]:[\\/]/;
// react-markdown's defaultUrlTransform whitelists only http(s)/ircs/mailto/xmpp
-// and strips everything else to "" (broken <img>). We render local-cache images
-// via the privileged xdt-image:// and xdt-file:// schemes registered in main.
+// and strips everything else to "" (broken <img>). We render local-cache media
+// via the privileged xdt-image:// / xdt-video:// and xdt-file:// schemes
+// registered in main.
// cindy:// (+ 历史 xdt-maker://) is our internal deep-link protocol (session /
// project navigation), handled in-renderer by the <a> onClick below — must pass
// through unsanitized so href reaches the click handler intact.
const trustedUrlTransform: UrlTransform = (url, key) => {
if (
url.startsWith('xdt-image://') ||
+ url.startsWith('xdt-video://') ||
url.startsWith('cindy-media://') ||
url.startsWith('xdt-file://') ||
url.startsWith('xdt-audio://') ||
@@ -1763,6 +1767,16 @@ export const MarkdownRenderer = memo(function MarkdownRenderer({
workingDir,
allowPrivilegedLinks,
);
+ if (isManagedMarkdownVideoUrl(normalized)) {
+ return (
+ <ChatVideoView
+ src={normalized}
+ filename={markdownMediaFilename(normalized, alt)}
+ variant="tool-output"
+ sessionId={currentSessionId}
+ />
+ );
+ }
const imageProps = { ...props };
delete (imageProps as Record<string, unknown>)[RAW_LOCAL_IMAGE_SRC_PROP];
return (
diff --git a/apps/desktop/src/renderer/components/chat/__tests__/markdownImageTargets.test.ts b/apps/desktop/src/renderer/components/chat/__tests__/markdownImageTargets.test.ts
index 498b4a17d2..ab5b50f7e2 100644
--- a/apps/desktop/src/renderer/components/chat/__tests__/markdownImageTargets.test.ts
+++ b/apps/desktop/src/renderer/components/chat/__tests__/markdownImageTargets.test.ts
@@ -73,4 +73,12 @@ describe('extractRenderedMarkdownImageTargets', () => {
empty,
);
});
+
+ it('does not count managed video Markdown targets as images', () => {
+ expect(
+ extractRenderedMarkdownImageTargets(
+ '![video](cindy-media://blobs/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa.mp4)',
+ ),
+ ).toEqual([]);
+ });
});
diff --git a/apps/desktop/src/renderer/components/chat/__tests__/markdownMedia.test.ts b/apps/desktop/src/renderer/components/chat/__tests__/markdownMedia.test.ts
new file mode 100644
index 0000000000..27d9f900db
--- /dev/null
+++ b/apps/desktop/src/renderer/components/chat/__tests__/markdownMedia.test.ts
@@ -0,0 +1,32 @@
+import { describe, expect, it } from 'vitest';
+
+import { isManagedMarkdownVideoUrl, markdownMediaFilename } from '../markdownMedia';
+
+describe('managed Markdown media', () => {
+ it.each([
+ 'cindy-media://blobs/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa.mp4',
+ 'xdt-video://local/generated.webm',
+ 'cindy-remote-media://device/generated.mov?range=0-1',
+ ])('recognizes %s as a video target', (url) => {
+ expect(isManagedMarkdownVideoUrl(url)).toBe(true);
+ });
+
+ it.each([
+ 'cindy-media://blobs/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa.png',
+ 'https://example.com/generated.mp4',
+ 'cindy-media://blobs/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa',
+ undefined,
+ ])('does not upgrade %s to a video target', (url) => {
+ expect(isManagedMarkdownVideoUrl(url)).toBe(false);
+ });
+
+ it('prefers the Markdown alt text and falls back to the managed filename', () => {
+ const url = 'cindy-media://blobs/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa.mp4';
+ expect(markdownMediaFilename(url, 'Seedance 雪景版 KV 动态预览')).toBe(
+ 'Seedance 雪景版 KV 动态预览',
+ );
+ expect(markdownMediaFilename(url)).toBe(
+ 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa.mp4',
+ );
+ });
+});
diff --git a/apps/desktop/src/renderer/components/chat/__tests__/markdownVideoRenderer.test.tsx b/apps/desktop/src/renderer/components/chat/__tests__/markdownVideoRenderer.test.tsx
new file mode 100644
index 0000000000..df53152eda
--- /dev/null
+++ b/apps/desktop/src/renderer/components/chat/__tests__/markdownVideoRenderer.test.tsx
@@ -0,0 +1,43 @@
+// @vitest-environment jsdom
+
+import { render, screen } from '@testing-library/react';
+import { describe, expect, it, vi } from 'vitest';
+
+vi.mock('../ChatVideoView', () => ({
+ ChatVideoView: ({
+ src,
+ filename,
+ }: {
+ src: string;
+ filename: string;
+ variant: string;
+ sessionId?: string;
+ }) => <video data-testid="markdown-video" data-src={src} aria-label={filename} />,
+}));
+
+vi.mock('react-i18next', async (importOriginal) => ({
+ ...(await importOriginal<typeof import('react-i18next')>()),
+ useTranslation: () => ({ t: (key: string) => key }),
+}));
+
+import { MarkdownRenderer } from '../MarkdownRenderer';
+
+describe('MarkdownRenderer managed video targets', () => {
+ it.each([
+ 'cindy-media://blobs/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa.mp4',
+ 'xdt-video://lizi-art-media-videos/generated.webm',
+ ])('routes managed video %s in Markdown image syntax to the video preview', (src) => {
+
+ render(
+ <MarkdownRenderer
+ workingDir="C:\workspace"
+ content={'![Seedance 雪景版 KV 动态预览](' + src + ')'}
+ />,
+ );
+
+ const video = screen.getByTestId('markdown-video');
+ expect(video.getAttribute('data-src')).toBe(src);
+ expect(video.getAttribute('aria-label')).toBe('Seedance 雪景版 KV 动态预览');
+ expect(screen.queryByRole('img')).toBeNull();
+ });
+});
diff --git a/apps/desktop/src/renderer/components/chat/markdownImageTargets.ts b/apps/desktop/src/renderer/components/chat/markdownImageTargets.ts
index e0d389518b..edd512ee49 100644
--- a/apps/desktop/src/renderer/components/chat/markdownImageTargets.ts
+++ b/apps/desktop/src/renderer/components/chat/markdownImageTargets.ts
@@ -6,6 +6,7 @@ import {
normalizeMarkdownRendererContent,
REMARK_PLUGINS_PRIVILEGED,
} from './MarkdownRenderer';
+import { isManagedMarkdownVideoUrl } from './markdownMedia';
const markdownImageParser = unified()
.use(remarkParse)
@@ -33,7 +34,10 @@ export function extractRenderedMarkdownImageTargets(markdown: string): string[]
const urls: string[] = [];
const seen = new Set<string>();
visit(tree, 'image', (node: Image) => {
- if (!node.url || seen.has(node.url)) return;
+ // Markdown image syntax can carry generated videos. Those targets are
+ // rendered by ChatVideoView and must not be counted as images for inline
+ // image fallback / delivery decisions.
+ if (!node.url || isManagedMarkdownVideoUrl(node.url) || seen.has(node.url)) return;
seen.add(node.url);
urls.push(node.url);
});
diff --git a/apps/desktop/src/renderer/components/chat/markdownMedia.ts b/apps/desktop/src/renderer/components/chat/markdownMedia.ts
new file mode 100644
index 0000000000..8100d704d9
--- /dev/null
+++ b/apps/desktop/src/renderer/components/chat/markdownMedia.ts
@@ -0,0 +1,26 @@
+const MANAGED_MEDIA_SCHEME_RE = /^(?:cindy-media|xdt-video|cindy-remote-media):\/\//i;
+const VIDEO_EXTENSION_RE = /\.(?:mp4|webm|mov|m4v)(?:[?#]|$)/i;
+
+/**
+ * Markdown image syntax is also used by generated-media replies. Keep the
+ * video upgrade limited to Cindy-managed media so an arbitrary remote image
+ * URL cannot silently become an autoplay-capable video surface.
+ */
+export function isManagedMarkdownVideoUrl(src: string | undefined): src is string {
+ return Boolean(src && MANAGED_MEDIA_SCHEME_RE.test(src) && VIDEO_EXTENSION_RE.test(src));
+}
+
+/** Use the alt text for the preview label, with the managed URL as fallback. */
+export function markdownMediaFilename(src: string, alt?: string): string {
+ const label = alt?.trim();
+ if (label) return label;
+
+ try {
+ const pathname = new URL(src).pathname;
+ const filename = decodeURIComponent(pathname.split('/').pop() ?? '').trim();
+ if (filename) return filename;
+ } catch {
+ // Keep the stable fallback below for malformed or legacy media URLs.
+ }
+ return 'video';
+}
diff --git a/apps/desktop/src/renderer/lib/localPathResolver.ts b/apps/desktop/src/renderer/lib/localPathResolver.ts
index 06da07591d..dd218c2aa3 100644
--- a/apps/desktop/src/renderer/lib/localPathResolver.ts
+++ b/apps/desktop/src/renderer/lib/localPathResolver.ts
@@ -643,6 +643,7 @@ export function normalizeMarkdownImageSrc(
src.startsWith('http://') ||
src.startsWith('https://') ||
src.startsWith('xdt-image://') ||
+ src.startsWith('xdt-video://') ||
src.startsWith('cindy-media://') ||
src.startsWith('cindy-remote-media://')
) {