Skip to content

armgit / cindy

Public Imported from GitHub
0

Consider it done. The open-source AI agent that works out of the box · 想到,就能做到。开源、开箱即用的 AI Agent。

fix(design): 只剔除已删除文档自己的名字,不连带删除紧挨着的有效引用

kirozeng44c4508a0ecd
diff --git a/scripts/__tests__/check-pr-design-basis.test.mjs b/scripts/__tests__/check-pr-design-basis.test.mjs
index dc3f32e1f2..60865f169b 100644
--- a/scripts/__tests__/check-pr-design-basis.test.mjs
+++ b/scripts/__tests__/check-pr-design-basis.test.mjs
@@ -23,3 +23,9 @@ test("只引用已删除的 figma-component-spec,不论哪种写法都不算
test("同时引用现行文档时,顺带提到已删除文档不影响通过", () => {
assert.equal(passes("DESIGN.md §16.5;旧 figma-component-spec §11 已迁入"), true);
});
+
+test("与已删除文档无空格连写的现行引用不会被连带剔除", () => {
+ assert.equal(passes("[现行](docs/design-rules/DESIGN.md);[旧](docs/design-rules/figma-component-spec.md)"), true);
+ assert.equal(passes("DESIGN.md§16;figma-component-spec.md§4"), true);
+ assert.equal(passes("[旧](docs/design-rules/figma-component-spec.md);[现行](docs/design-rules/token-decision-table.md)"), true);
+});
diff --git a/scripts/check-pr-design-basis.mjs b/scripts/check-pr-design-basis.mjs
index fa956601c7..867e99829c 100644
--- a/scripts/check-pr-design-basis.mjs
+++ b/scripts/check-pr-design-basis.mjs
@@ -34,9 +34,10 @@ const FIELD_LABEL = '引用的设计规范';
// 设计规范文档引用特征:docs/design-rules/ 目录或其下具体文档名。
const DESIGN_DOC_PATTERN =
/(docs\/design-rules\/|DESIGN\.md|cindy-design-system|token-decision-table)/i;
-// 已删除的设计文档:连同它所在的整段写法(裸文件名、完整路径、Markdown 链接)一起先剔除再判断,
+// 已删除的设计文档:只剔除它自己的名字或路径(可带 docs/design-rules/ 前缀和 .md 后缀)再判断,
// 否则 `docs/design-rules/figma-component-spec.md §4` 仍会因目录前缀被当作有效依据。
-const REMOVED_DESIGN_DOC_PATTERN = /\S*figma-component-spec\S*/gi;
+// 不能按整段非空白字符剔除:中文 Markdown 常把链接无空格连写,会连带删掉紧挨着的有效引用。
+const REMOVED_DESIGN_DOC_PATTERN = /(?:docs\/design-rules\/)?figma-component-spec(?:\.md)?/gi;
// 「不涉及」豁免在去掉该词与标点后至少要剩这么多字符,才算附了理由
// (放到 4 是为了让「纯逻辑重构」「无 UI 变化」这类最短合理理由能过)。
const MIN_EXEMPT_REASON_CHARS = 4;