Skip to content

armgit / cindy

Public Imported from GitHub
0

Consider it done. The open-source AI agent that works out of the box · 想到,就能做到。开源、开箱即用的 AI Agent。

fix(downloader): clear corrupt size-mismatch sidecars

Dash4f17f3cc3c23
diff --git a/apps/desktop/src/main/downloader/__tests__/transport.test.ts b/apps/desktop/src/main/downloader/__tests__/transport.test.ts
new file mode 100644
index 0000000000..4ee0cf9ed2
--- /dev/null
+++ b/apps/desktop/src/main/downloader/__tests__/transport.test.ts
@@ -0,0 +1,62 @@
+import { EventEmitter } from 'node:events';
+import { createHash } from 'node:crypto';
+import fs from 'node:fs/promises';
+import os from 'node:os';
+import path from 'node:path';
+import { expect, it, vi } from 'vitest';
+
+const mocks = vi.hoisted(() => ({ request: vi.fn() }));
+vi.mock('electron', () => ({ net: { request: mocks.request } }));
+
+import { executeOnce } from '../transport';
+
+it('removes corrupt size-mismatch sidecars and permits a fresh retry', async () => {
+ const root = await fs.mkdtemp(path.join(os.tmpdir(), 'download-size-test-'));
+ const targetPath = path.join(root, 'artifact');
+ const expectedBody = Buffer.from('valid body');
+ let body = Buffer.from('short');
+ const requests: Array<Record<string, string>> = [];
+ mocks.request.mockImplementation(() => {
+ const request = new EventEmitter() as EventEmitter & {
+ setHeader: (key: string, value: string) => void;
+ end: () => void;
+ abort: () => void;
+ };
+ const headers: Record<string, string> = {};
+ requests.push(headers);
+ request.setHeader = (key, value) => {
+ headers[key] = value;
+ };
+ request.abort = vi.fn();
+ request.end = () =>
+ queueMicrotask(() => {
+ const response = Object.assign(new EventEmitter(), { statusCode: 200, headers: {} });
+ request.emit('response', response);
+ response.emit('data', body);
+ response.emit('end');
+ });
+ return request;
+ });
+ const context = () => ({
+ opts: {
+ url: 'https://example.invalid/artifact',
+ targetPath,
+ expectedSize: expectedBody.length,
+ sha256: createHash('sha256').update(expectedBody).digest('hex'),
+ },
+ logger: {},
+ resumedFromBytes: 0,
+ });
+ try {
+ await expect(executeOnce(context())).rejects.toMatchObject({ code: 'CHECKSUM' });
+ for (const file of [targetPath, targetPath + '.part', targetPath + '.meta.json']) {
+ await expect(fs.stat(file)).rejects.toMatchObject({ code: 'ENOENT' });
+ }
+ body = expectedBody;
+ await expect(executeOnce(context())).resolves.toMatchObject({ size: expectedBody.length });
+ expect(requests).toEqual([{}, {}]);
+ expect(await fs.readFile(targetPath)).toEqual(expectedBody);
+ } finally {
+ await fs.rm(root, { recursive: true, force: true });
+ }
+});
diff --git a/apps/desktop/src/main/downloader/transport.ts b/apps/desktop/src/main/downloader/transport.ts
index 9a88438920..00bef113b6 100644
--- a/apps/desktop/src/main/downloader/transport.ts
+++ b/apps/desktop/src/main/downloader/transport.ts
@@ -334,7 +334,12 @@ export async function executeOnce(ctx: TransportContext): Promise<TransportResul
const finalSize = tracker.getLoaded();
if (settled || opts.signal?.aborted) return;
- if (opts.expectedSize !== undefined && finalSize !== opts.expectedSize) { safeReject(new DownloadError('CHECKSUM', 'Downloaded size mismatch')); return; }
+ if (opts.expectedSize !== undefined && finalSize !== opts.expectedSize) {
+ deletePart(opts.targetPath);
+ deleteMeta(opts.targetPath);
+ safeReject(new DownloadError('CHECKSUM', 'Downloaded size mismatch'));
+ return;
+ }
if (finalHash !== opts.sha256) {
// Corrupt body — wipe both .part and .meta so a future attempt
// starts truly fresh (CHECKSUM is not retried inside withRetry).