Skip to content

armgit / cindy

Public Imported from GitHub
0

Consider it done. The open-source AI agent that works out of the box · 想到,就能做到。开源、开箱即用的 AI Agent。

fix(feishu): don't queue the offline notice when lifecycle announcements are off (#7521)

Zhao Dengfeng59c5f54de01d
diff --git a/packages/lizi-im/src/feishu/__tests__/lifecycleAnnouncements.test.ts b/packages/lizi-im/src/feishu/__tests__/lifecycleAnnouncements.test.ts
index e322371a69..b12982ba2e 100644
--- a/packages/lizi-im/src/feishu/__tests__/lifecycleAnnouncements.test.ts
+++ b/packages/lizi-im/src/feishu/__tests__/lifecycleAnnouncements.test.ts
@@ -152,6 +152,21 @@ describe('Feishu lifecycle announcements across shared-profile instances', () =>
expect(host.secrets.write).not.toHaveBeenCalled();
});
+ // 关闭生命周期通知后,停止再重连不应在下一条私聊里补发「我之前离线过」提醒;
+ // 停止时还开着、随后才关闭的情况也一样。
+ it.each([
+ ['disabled before stop', false],
+ ['disabled after stop', true],
+ ] as const)('does not send the offline-history notice once announcements are off (%s)', async (_case, enabledAtStop) => {
+ const host = makeHost('', enabledAtStop);
+ const primary = await connect(host, { ipc: false, shouldAnnounceLifecycle: () => true });
+ await runInScope(primary.scope, () => stop({ reason: 'test-logical-stop' }));
+ if (enabledAtStop) primary.setLifecycleAnnouncement(false);
+ await primary.reconnect();
+ await receive(1, 'om_after_disabled_reconnect');
+ expect(sentTexts()).not.toContain(messages.lifecycle.offlineNotice);
+ });
+
it('primary still respects a saved disabled announcement preference', async () => {
const host = makeHost('', false);
const primary = await connect(host, { ipc: false, shouldAnnounceLifecycle: () => true });
diff --git a/packages/lizi-im/src/feishu/wsClient.ts b/packages/lizi-im/src/feishu/wsClient.ts
index c9565e397a..0cd3813dd3 100644
--- a/packages/lizi-im/src/feishu/wsClient.ts
+++ b/packages/lizi-im/src/feishu/wsClient.ts
@@ -218,6 +218,7 @@ export function getCurrentBotAppId(): string | null {
export function setLifecycleAnnouncement(enabled: boolean): void {
S().lifecycleAnnouncementEnabled = enabled;
+ if (!enabled) S().pendingOfflineNotice = false;
getLog().info(`[feishu/wsClient] lifecycleAnnouncement set to ${enabled}`);
}
@@ -697,13 +698,14 @@ async function announceLifecycle(phase: 'online' | 'offline'): Promise<void> {
return;
}
- if (phase === 'offline') S().pendingOfflineNotice = true;
-
if (!S().lifecycleAnnouncementEnabled) {
log.info(`[feishu/wsClient] announceLifecycle ${phase}: message suppressed by setting`);
return;
}
+ // 离线补发提醒属于同一类生命周期通知:关闭后不记待发标记(与 Discord 口径一致)。
+ if (phase === 'offline') S().pendingOfflineNotice = true;
+
const text =
phase === 'online' ? transportMessages.lifecycle.online : transportMessages.lifecycle.offline;
try {