Skip to content

armgit / cindy

Public Imported from GitHub
0

Consider it done. The open-source AI agent that works out of the box · 想到,就能做到。开源、开箱即用的 AI Agent。

perf(file-browser): 隐藏 tab 不再渲染文件树行(展开 node_modules 阻塞减半)

Zhang Yunjin96e14a735f7c
diff --git a/apps/desktop/src/renderer/features/cc-agent/workdir-browse/FileTreeView.tsx b/apps/desktop/src/renderer/features/cc-agent/workdir-browse/FileTreeView.tsx
index 66094317e5..b21d9bb3e7 100644
--- a/apps/desktop/src/renderer/features/cc-agent/workdir-browse/FileTreeView.tsx
+++ b/apps/desktop/src/renderer/features/cc-agent/workdir-browse/FileTreeView.tsx
@@ -126,6 +126,12 @@ export interface FileTreeViewProps {
onRename?: (entry: DirEntry) => void;
/** Inline 输入态:有值时在 parentRel 下方插临时行。 */
pendingCreate?: PendingCreate | null;
+ /** 宿主是否处于激活状态。false = **不渲染行**(RSB 多标签的隐藏 tab):
+ * 每行有图标 + i18n + DOM 创建成本,node_modules 展开后单棵树上千行 ——
+ * 隐藏 tab 并行渲染会把展开的主线程阻塞翻倍(实测 1373 行/树 ≈ 350ms,
+ * 两棵树 ≈ 570-740ms)。数据层在父组件(useFileTree 的 store / watcher),
+ * 这里只是不产出 DOM。不传 = 始终渲染(doc 侧栏等单宿主场景)。 */
+ active?: boolean;
/** 用户敲了非空 name + 回车 / 失焦时调用。 */
onPendingSubmit?: (name: string) => void;
/** Esc / 空内容失焦 / 父层主动取消。 */
@@ -223,6 +229,7 @@ export const FileTreeView = forwardRef<FileTreeViewHandle, FileTreeViewProps>(fu
renamingPath,
onRenameSubmit,
onRenameCancel,
+ active,
},
ref,
) {
@@ -281,6 +288,13 @@ export const FileTreeView = forwardRef<FileTreeViewHandle, FileTreeViewProps>(fu
[],
);
+ // 非激活 tab 不渲染行:RSB 多标签是 keep-alive(同时挂载、CSS hidden 切换),
+ // 而每行(图标 + i18n wrapper + DOM)实测约 0.25ms —— node_modules 展开后单棵树
+ // 就有上千行,两份并行渲染把展开的主线程阻塞直接翻倍。数据层(useFileTree 的
+ // store / watcher / 展开态持久化)都在父组件,这里只是不产出 DOM;切回来时按
+ // 当前 store 一次性渲染,不重新拉盘、不丢展开态。
+ if (active === false) return null;
+
if (tree.initialLoading) {
// 本地首个 listDir <50ms,门控内保持空白(规则 7);远程慢通道超过阈值
// 后浮现 spinner + 提示,避免长空白被读成"项目是空的 / 坏了"。
diff --git a/apps/desktop/src/renderer/features/cc-agent/workdir-browse/__tests__/FileTreeView.activeTab.test.tsx b/apps/desktop/src/renderer/features/cc-agent/workdir-browse/__tests__/FileTreeView.activeTab.test.tsx
new file mode 100644
index 0000000000..553f9d0e15
--- /dev/null
+++ b/apps/desktop/src/renderer/features/cc-agent/workdir-browse/__tests__/FileTreeView.activeTab.test.tsx
@@ -0,0 +1,68 @@
+// @vitest-environment jsdom
+
+/**
+ * FileTreeView 的 active prop —— RSB 多标签是 keep-alive(同时挂载、CSS hidden
+ * 切换可见性),隐藏 tab 的树此前照常渲染全部行。
+ *
+ * 起因(实测):每行(lucide 图标 + i18n wrapper + DOM 创建)约 0.25ms,`node_modules`
+ * 展开后单棵树就有上千行 —— 两份并行渲染把展开时的主线程阻塞从 ~312-360ms 抬到
+ * 570-740ms。数据层留在父组件(useFileTree 的 store / watcher / 展开态持久化),
+ * 这里只规定「隐藏宿主不产出 DOM」。
+ */
+
+import { cleanup, render } from '@testing-library/react';
+import { afterEach, describe, expect, it, vi } from 'vitest';
+
+vi.mock('react-i18next', () => ({
+ useTranslation: () => ({ t: (key: string) => key }),
+}));
+
+import { FileTreeView } from '../FileTreeView';
+import type { DirEntry, UseFileTreeReturn } from '../hooks/useFileTree';
+
+const entries: DirEntry[] = [
+ { name: 'index.ts', relPath: 'index.ts', type: 'file', size: 10, mtimeMs: 1 },
+ { name: 'src', relPath: 'src', type: 'directory', size: 0, mtimeMs: 2 },
+];
+
+function makeTree(): UseFileTreeReturn {
+ return {
+ entries: new Map([['', entries]]),
+ expanded: new Set(['']),
+ loadingPaths: new Set(),
+ initialLoading: false,
+ loadError: null,
+ storeKey: 'test-store',
+ showIgnoredDirsSupported: true,
+ toggleFolder: vi.fn(),
+ collapseAll: vi.fn(),
+ refresh: vi.fn(async () => undefined),
+ expandToPath: vi.fn(async () => undefined),
+ };
+}
+
+afterEach(() => cleanup());
+
+describe('FileTreeView active prop(隐藏 tab 不渲染行)', () => {
+ it('active=false 时不产出任何行 DOM', () => {
+ const { container } = render(
+ <FileTreeView active={false} tree={makeTree()} selectedPath={null} onSelectFile={vi.fn()} />,
+ );
+
+ expect(container.querySelectorAll('[data-relpath]')).toHaveLength(0);
+ expect(container.firstChild).toBeNull();
+ });
+
+ it('不传 active(doc 侧栏等单宿主场景)与 active=true 都照常渲染', () => {
+ const defaulted = render(
+ <FileTreeView tree={makeTree()} selectedPath={null} onSelectFile={vi.fn()} />,
+ );
+ expect(defaulted.container.querySelectorAll('[data-relpath]')).toHaveLength(2);
+ cleanup();
+
+ const explicit = render(
+ <FileTreeView active tree={makeTree()} selectedPath={null} onSelectFile={vi.fn()} />,
+ );
+ expect(explicit.container.querySelectorAll('[data-relpath]')).toHaveLength(2);
+ });
+});
diff --git a/apps/desktop/src/renderer/features/cc-agent/workdir-browse/__tests__/FileTreeView.horizontalScroll.test.tsx b/apps/desktop/src/renderer/features/cc-agent/workdir-browse/__tests__/FileTreeView.horizontalScroll.test.tsx
index a78e714e63..d3f2a58cbc 100644
--- a/apps/desktop/src/renderer/features/cc-agent/workdir-browse/__tests__/FileTreeView.horizontalScroll.test.tsx
+++ b/apps/desktop/src/renderer/features/cc-agent/workdir-browse/__tests__/FileTreeView.horizontalScroll.test.tsx
@@ -53,6 +53,8 @@ function makeTree(): UseFileTreeReturn {
loadingPaths: new Set(),
initialLoading: false,
loadError: null,
+ showIgnoredDirsSupported: true,
+ storeKey: 'test-store',
toggleFolder: vi.fn(),
collapseAll: vi.fn(),
refresh: vi.fn(async () => undefined),
diff --git a/apps/desktop/src/renderer/features/cc-agent/workdir-browse/__tests__/FileTreeView.imagePreview.test.tsx b/apps/desktop/src/renderer/features/cc-agent/workdir-browse/__tests__/FileTreeView.imagePreview.test.tsx
index ee38040042..f0a42db676 100644
--- a/apps/desktop/src/renderer/features/cc-agent/workdir-browse/__tests__/FileTreeView.imagePreview.test.tsx
+++ b/apps/desktop/src/renderer/features/cc-agent/workdir-browse/__tests__/FileTreeView.imagePreview.test.tsx
@@ -23,6 +23,8 @@ function makeTree(): UseFileTreeReturn {
loadingPaths: new Set(),
initialLoading: false,
loadError: null,
+ showIgnoredDirsSupported: true,
+ storeKey: 'test-store',
toggleFolder: vi.fn(),
collapseAll: vi.fn(),
refresh: vi.fn(async () => undefined),
diff --git a/apps/desktop/src/renderer/features/right-sidebar/plugins/file-browser/FileBrowserBody.tsx b/apps/desktop/src/renderer/features/right-sidebar/plugins/file-browser/FileBrowserBody.tsx
index ee38115582..30225cc03a 100644
--- a/apps/desktop/src/renderer/features/right-sidebar/plugins/file-browser/FileBrowserBody.tsx
+++ b/apps/desktop/src/renderer/features/right-sidebar/plugins/file-browser/FileBrowserBody.tsx
@@ -104,14 +104,19 @@ const BODY_MIN_RESERVE = 100;
interface FileBrowserBodyProps {
state: FileBrowserState;
ctx: TabKindHostContext;
+ /** 宿主 tab 是否激活(PluginBodyHost 传入)。隐藏 tab 下不渲染文件树 DOM,
+ * 避免多标签 keep-alive 时并行渲染上千行(见 FileTreeView 的 active)。 */
+ active?: boolean;
}
-export function FileBrowserBody({ state, ctx }: FileBrowserBodyProps) {
+export function FileBrowserBody({ state, ctx, active }: FileBrowserBodyProps) {
const { workdir } = ctx;
if (!workdir) {
return <NoWorkdirPlaceholder />;
}
- return <FileBrowserBodyWithWorkdir state={state} ctx={ctx} workdir={workdir} />;
+ return (
+ <FileBrowserBodyWithWorkdir state={state} ctx={ctx} workdir={workdir} active={active} />
+ );
}
/**
@@ -123,6 +128,7 @@ function FileBrowserBodyWithWorkdir({
state,
ctx,
workdir,
+ active,
}: FileBrowserBodyProps & { workdir: string }) {
const { t } = useTranslation();
// 会话归属三路:local / SSH(remoteHostId)/ device-link(deviceId)。
@@ -674,6 +680,7 @@ function FileBrowserBodyWithWorkdir({
<FileTreeView
ref={fileTreeRef}
tree={tree}
+ active={active}
selectedPath={state.selectedFilePath}
onSelectFile={handleSelectFile}
onPreviewImage={handlePreviewImage}