Skip to content

armgit / cindy

Public Imported from GitHub
0

Consider it done. The open-source AI agent that works out of the box · 想到,就能做到。开源、开箱即用的 AI Agent。

feat(desktop): add task remote desktop shortcut (#6267)

Lizia0bb2c83be93
diff --git a/apps/desktop/src/renderer/components/layout/ContentHeader.tsx b/apps/desktop/src/renderer/components/layout/ContentHeader.tsx
index 76ba6e88a5..88e5b02d4f 100644
--- a/apps/desktop/src/renderer/components/layout/ContentHeader.tsx
+++ b/apps/desktop/src/renderer/components/layout/ContentHeader.tsx
@@ -71,6 +71,8 @@ interface ContentHeaderProps {
rightSidebarAvailable: boolean;
/** MainLayout 经 useContentHeaderHidden 预判的结果(与 --content-header-h 同源)。 */
hidden: boolean;
+ /** 右端占位左侧、紧挨 mac 右栏开关的按钮(任务所在电脑的远程桌面等);按钮自挖 no-drag。 */
+ trailing?: ReactNode;
}
export function ContentHeader({
@@ -79,6 +81,7 @@ export function ContentHeader({
isSidebarRail,
rightSidebarAvailable,
hidden,
+ trailing,
}: ContentHeaderProps) {
const { isMac, isFullscreen } = useMacFullscreen();
const headerContent = useFeatureContentHeader();
@@ -169,6 +172,8 @@ export function ContentHeader({
元素自行 no-drag。 */}
<div className="flex h-full min-w-0 flex-1 items-center">{headerContent}</div>
+ {trailing}
+
{/* 右端占位 —— 平台分流(两端都只留占位,不再放交互按钮):
- mac:全屏聊天视图在场时(rightSidebarAvailable)留出固定唤起按钮等宽占位。
按钮本身已 hoist 到 MainLayout 顶层浮层(钉窗口右上角);这里仅占位防注入
@@ -198,6 +203,7 @@ export function ContentHeaderSlot({
showCollapsedActions,
isSidebarRail,
rightSidebarAvailable,
+ trailing,
children,
}: Omit<ContentHeaderProps, 'hidden'> & { children: ReactNode }) {
const hidden = useContentHeaderHidden({ sidebarVisible, rightSidebarAvailable });
@@ -209,6 +215,7 @@ export function ContentHeaderSlot({
isSidebarRail={isSidebarRail}
rightSidebarAvailable={rightSidebarAvailable}
hidden={hidden}
+ trailing={trailing}
/>
<div
style={{ display: 'contents', ['--content-header-h' as string]: hidden ? '0px' : '46px' }}
diff --git a/apps/desktop/src/renderer/components/layout/MainLayout.tsx b/apps/desktop/src/renderer/components/layout/MainLayout.tsx
index 5777a0cfc1..93b24b7b0f 100644
--- a/apps/desktop/src/renderer/components/layout/MainLayout.tsx
+++ b/apps/desktop/src/renderer/components/layout/MainLayout.tsx
@@ -1,7 +1,7 @@
import { drainPendingDeepLinks } from '@/lib/pendingDeepLinks';
import { ChatInviteHost, reportMalformedChatInvite, requestChatInvite } from '@/features/bots/ChatInviteHost';
import { useCallback, useEffect, useLayoutEffect, useMemo, useRef, useState } from 'react';
-import { buildSharedTaskInvitationLink } from '@cindy/device-link';
+import { buildSharedTaskInvitationLink, isSharedTaskPeer } from '@cindy/device-link';
import { JoinSharedTaskDialog } from '@/features/device-link/JoinSharedTaskDialog';
import { Outlet, useLocation, useNavigate } from 'react-router-dom';
import { useRememberMainEntry } from './MainEntryRedirect';
@@ -33,6 +33,7 @@ import { FeishuConflictDialogHost } from '@/components/feishuBot/FeishuConflictD
import { GlobalDropImportListener } from '@/components/layout/GlobalDropImportListener';
import { SessionShareImportWizard } from '@/components/settings/SessionShareImportWizard';
import { ControlledBanner } from '@/features/remote-device/ControlledBanner';
+import { TaskRemoteDesktopButton } from '@/features/remote-desktop/TaskRemoteDesktopButton';
import { CredentialStoreBanner } from '@/components/layout/CredentialStoreBanner';
import { useDeviceLinkRemoteProjects } from '@/features/device-link/useDeviceLinkRemoteProjects';
import { useAgentIslandRemoteSessionsSync } from '@/features/device-link/agentIslandRemoteSessions';
@@ -349,6 +350,16 @@ export function MainLayout() {
),
[],
);
+ // 当前任务所在的同账号另一台电脑:右栏开关旁给远程桌面入口(mac 顶栏右端 / Windows
+ // 内容区右上 chip 栈)。共享任务的对方电脑不是自己的电脑,不能远程。
+ const remoteDesktopDeviceId =
+ rightSidebarWorkdirInfo.deviceLinkDeviceId &&
+ !isSharedTaskPeer(rightSidebarWorkdirInfo.deviceLinkDeviceId)
+ ? rightSidebarWorkdirInfo.deviceLinkDeviceId
+ : null;
+ // Windows 内容区右上的右栏唤起 chip:仅面板收起或分离时在场。
+ const showWindowsRightSidebarTrigger =
+ rightSidebarAvailable && rsbWindow.loaded && (rsbDetached || isRightSidebarCollapsed);
const rowRef = useRef<HTMLDivElement>(null);
const mainRef = useRef<HTMLElement>(null);
// B1a(去方位化):左侧占位块(pinning spacer + Sidebar)的 wrapper。
@@ -1506,6 +1517,14 @@ export function MainLayout() {
// RSB Maximize(Phase 6):主区彻底 display:none,把整个非左栏空间让给 RSB。
isRightSidebarMaximized && 'hidden',
)}
+ // Windows 浮动入口每个占 28px + 4px 间距;分屏工具条使用同一占位,
+ // 避免远程桌面 / 面板入口盖住关闭分屏等操作。mac 与左侧入口无需右端让位。
+ style={{
+ ['--content-top-right-actions-inset' as string]:
+ !isMac && rightSidebarSide === 'right'
+ ? `${(showWindowsRightSidebarTrigger ? 32 : 0) + (remoteDesktopDeviceId ? 32 : 0)}px`
+ : '0px',
+ }}
>
{/* showCollapsedActions: 完全隐藏(isSidebarCollapsed)**和** rail 态(isRailMode)
都要为浮动 ChromeActions 簇预留 68px 占位 —— rail 下侧栏仅 64px,chrome 簇
@@ -1520,6 +1539,17 @@ export function MainLayout() {
// M2(2026-07-09 口径修订):mac 右上浮层随面板在场常驻(折叠
// toggle 永远钉窗口右上角),ContentHeader 右端占位不再分侧别。
rightSidebarAvailable={rightSidebarAvailable}
+ // mac:远程桌面入口落在顶栏右端,紧挨窗口右上角的右栏开关(右栏展开时
+ // 仍在聊天区顶栏右端)。Windows 走下方内容区 chip 栈。
+ trailing={
+ isMac && remoteDesktopDeviceId ? (
+ <TaskRemoteDesktopButton
+ key={remoteDesktopDeviceId}
+ deviceId={remoteDesktopDeviceId}
+ className={rightSidebarAvailable ? 'mr-1' : 'mr-2'}
+ />
+ ) : undefined
+ }
>
{/* key 取 feature 段(pathname 第一段)而非完整 pathname:
跨 Feature 切换(/issues → /cc-agent)触发 FadeSwitcher 重挂跑淡入动画;
@@ -1532,31 +1562,38 @@ export function MainLayout() {
shrink-0 在 main 的 flex 列里独占一行把内容推下(不遮盖)。放在
FadeSwitcher 之外 —— 它是全局状态提示,不参与路由切换动画。 */}
<CredentialStoreBanner />
- {!isMac &&
- rightSidebarAvailable &&
- rsbWindow.loaded &&
- (rsbDetached || isRightSidebarCollapsed) && (
- <div
- data-testid="right-sidebar-fixed-trigger"
- className={cn(
- 'pointer-events-none absolute z-50',
- rightSidebarSide === 'left' ? 'left-2' : 'right-2',
- )}
- style={
- {
- top: 'calc(var(--content-header-h) + 0.25rem)',
- WebkitAppRegion: 'no-drag',
- } as React.CSSProperties
- }
- >
+ {/* Windows chip 栈:远程桌面入口贴着右栏唤起 chip(唤起 chip 在面板一侧);
+ 右栏展开时唤起 chip 不在,远程桌面入口留在同一角。 */}
+ {!isMac && (showWindowsRightSidebarTrigger || remoteDesktopDeviceId) && (
+ <div
+ data-testid="right-sidebar-fixed-trigger"
+ className={cn(
+ 'pointer-events-none absolute z-50 flex items-center gap-1',
+ rightSidebarSide === 'left' ? 'left-2 flex-row-reverse' : 'right-2',
+ )}
+ style={
+ {
+ top: 'calc(var(--content-header-h) + 0.25rem)',
+ WebkitAppRegion: 'no-drag',
+ } as React.CSSProperties
+ }
+ >
+ {remoteDesktopDeviceId && (
+ <TaskRemoteDesktopButton
+ key={remoteDesktopDeviceId}
+ deviceId={remoteDesktopDeviceId}
+ />
+ )}
+ {showWindowsRightSidebarTrigger && (
<RightSidebarToggle
action="show"
collapsed
onToggle={handleOpenRightSidebar}
side={rightSidebarSide}
/>
- </div>
- )}
+ )}
+ </div>
+ )}
<FadeSwitcher key={location.pathname.split('/')[1] || 'root'}>
<Outlet
context={{
diff --git a/apps/desktop/src/renderer/features/cc-agent/CCAgentSessionView.tsx b/apps/desktop/src/renderer/features/cc-agent/CCAgentSessionView.tsx
index 0ca779d966..52e868138c 100644
--- a/apps/desktop/src/renderer/features/cc-agent/CCAgentSessionView.tsx
+++ b/apps/desktop/src/renderer/features/cc-agent/CCAgentSessionView.tsx
@@ -5930,14 +5930,16 @@ function CCAgentSessionContent({
</div>
{/* TopRightChipStack:聊天视图右上 chip 浮层。
- Windows 固定侧栏入口由 MainLayout 承载;当入口位于右侧时在本栈第一行
- 保留等尺寸占位,让消息跳转等 portal chip 自然落到下一行。
+ Windows 固定侧栏入口与远程桌面入口由 MainLayout 承载;任一入口位于右侧时
+ 在本栈第一行保留等尺寸占位,面板展开后也不遮住消息跳转等 portal chip。
MessageStream 内部的 PrevMessageJumpChip 通过 portal 挂入同一栈,自然落到下一行。
"本次会话改动文件列表"已迁移到 RSB review tab,不再保留浮动按钮 + 滑入抽屉。 */}
<TopRightChipStack>
{!isMac &&
(ownsRoute || showRsbToggle) &&
- rightSidebarCollapsed &&
+ (rightSidebarCollapsed ||
+ (rightSidebarDeviceLinkDeviceId &&
+ !isSharedTaskPeer(rightSidebarDeviceLinkDeviceId))) &&
rightSidebarSide === 'right' && <div aria-hidden className="h-7 w-7 shrink-0" />}
</TopRightChipStack>
</section>
diff --git a/apps/desktop/src/renderer/features/cc-agent/SplitGroup.tsx b/apps/desktop/src/renderer/features/cc-agent/SplitGroup.tsx
index 28090c0314..436a656994 100644
--- a/apps/desktop/src/renderer/features/cc-agent/SplitGroup.tsx
+++ b/apps/desktop/src/renderer/features/cc-agent/SplitGroup.tsx
@@ -912,6 +912,7 @@ function SplitGroupToolbar({ root }: { root: SplitNode }) {
<div
data-split-group-toolbar
className="flex h-8 shrink-0 items-center justify-end gap-1 border-b border-border/40 px-2"
+ style={{ paddingRight: 'calc(0.5rem + var(--content-top-right-actions-inset, 0px))' }}
>
<button
type="button"
diff --git a/apps/desktop/src/renderer/features/remote-desktop/TaskRemoteDesktopButton.tsx b/apps/desktop/src/renderer/features/remote-desktop/TaskRemoteDesktopButton.tsx
new file mode 100644
index 0000000000..e1bfcdbbc6
--- /dev/null
+++ b/apps/desktop/src/renderer/features/remote-desktop/TaskRemoteDesktopButton.tsx
@@ -0,0 +1,103 @@
+import { useEffect, useRef, useState } from 'react';
+import { LoaderCircle, Monitor, MonitorOff } from 'lucide-react';
+import { useTranslation } from 'react-i18next';
+
+import { WINDOW_NO_DRAG_STYLE } from '@/components/layout/windowDrag';
+import { Tip } from '@/components/ui/tooltip';
+import { useDeviceLinkDeviceList } from '@/features/device-link/useDeviceLinkDeviceList';
+import { cn } from '@/lib/utils';
+import { toast } from '@/lib/toast';
+import { useRemoteDesktopAvailability } from './useRemoteDesktopAvailability';
+
+/**
+ * 当前任务在同账号另一台电脑上时,放在右栏开关旁的远程桌面入口(由 MainLayout 摆位:
+ * mac 在顶栏右端、Windows 在内容区右上角的浮动 chip 栈)。
+ *
+ * 状态口径与侧栏电脑分组上的入口一致:可连 → 打开;检查中 → 转圈;暂时不能连 →
+ * 置灰,悬停 / 点击说明原因;被打断的检查在再次悬停或聚焦时重查。这台电脑本身或
+ * 手机不是远程桌面目标,不显示。调用方按 deviceId 加 key,换电脑即重建。
+ *
+ * 两端共用 28px 胶囊按钮;Windows chip 栈容器 pointer-events-none,按钮自带 auto。
+ */
+export function TaskRemoteDesktopButton({
+ deviceId,
+ className,
+}: {
+ deviceId: string;
+ className?: string;
+}) {
+ const { t } = useTranslation();
+ const devices = useDeviceLinkDeviceList();
+ const name = devices?.find((device) => device.deviceId === deviceId)?.name || deviceId;
+ const availability = useRemoteDesktopAvailability(deviceId);
+ const [opening, setOpening] = useState(false);
+ const mounted = useRef(true);
+ useEffect(() => {
+ mounted.current = true;
+ return () => {
+ mounted.current = false;
+ };
+ }, []);
+
+ if (availability.reason === 'remoteDesktop.shortcut.unsupported') return null;
+ const busy = opening || availability.checking;
+ const Icon = busy ? LoaderCircle : availability.available ? Monitor : MonitorOff;
+ const label = busy
+ ? t(opening ? 'remoteDesktop.shortcut.opening' : 'remoteDesktop.shortcut.checking')
+ : availability.available
+ ? t('remoteDesktop.shortcut.open')
+ : t('remoteDesktop.shortcut.unavailable', {
+ reason: t(availability.reason ?? 'remoteDesktop.shortcut.checkFailed'),
+ });
+ // 侧栏同款:被打断的检查在用户再次看向入口时重查。
+ const reveal = () => {
+ if (availability.retryable) availability.retry();
+ };
+ return (
+ <Tip
+ text={label}
+ side="bottom"
+ contentClassName="max-w-[min(320px,var(--radix-tooltip-content-available-width))] whitespace-normal"
+ >
+ <button
+ type="button"
+ aria-label={label}
+ aria-disabled={busy}
+ aria-busy={busy || undefined}
+ className={cn(
+ 'pointer-events-auto flex h-7 w-7 shrink-0 items-center justify-center',
+ 'rounded-full',
+ 'text-titlebar-icon transition-colors hover:bg-titlebar-button-hover',
+ 'focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-[var(--focus-ring)]',
+ 'aria-disabled:hover:bg-transparent',
+ !availability.available && !opening && 'opacity-50',
+ busy && 'motion-safe:[&_svg]:animate-spin',
+ className,
+ )}
+ style={WINDOW_NO_DRAG_STYLE}
+ onMouseEnter={reveal}
+ onFocus={reveal}
+ onClick={() => {
+ if (busy) return;
+ if (!availability.available) {
+ toast.info(label, { duration: 8000 });
+ return;
+ }
+ setOpening(true);
+ void window.electronAPI
+ .openRemoteDesktop({ deviceId, name })
+ .catch((error: unknown) => {
+ if (!mounted.current) return;
+ availability.markUnavailable(error);
+ toast.error(t('remoteDesktop.connectionError'));
+ })
+ .finally(() => {
+ if (mounted.current) setOpening(false);
+ });
+ }}
+ >
+ <Icon size={15} aria-hidden />
+ </button>
+ </Tip>
+ );
+}
diff --git a/apps/desktop/src/renderer/features/remote-desktop/__tests__/TaskRemoteDesktopButton.test.tsx b/apps/desktop/src/renderer/features/remote-desktop/__tests__/TaskRemoteDesktopButton.test.tsx
new file mode 100644
index 0000000000..1bd3f4d145
--- /dev/null
+++ b/apps/desktop/src/renderer/features/remote-desktop/__tests__/TaskRemoteDesktopButton.test.tsx
@@ -0,0 +1,229 @@
+// @vitest-environment jsdom
+// 测试价值:通过真实按钮入口保护远程任务的一键打开、不可用原因与失败恢复;
+// 原标题栏放错位置且不可用时隐藏导致用户找不到入口,相邻侧栏用例不覆盖此按钮。
+// 最小输入为一台在线且开放远控的电脑(及离线/拒绝/失败变体);unit tier,单独约 4 秒。
+import { StrictMode } from 'react';
+import { act, cleanup, fireEvent, render, screen } from '@testing-library/react';
+import { afterEach, beforeEach, expect, it, vi } from 'vitest';
+import { REMOTE_DESKTOP_CHANNEL } from '@cindy/device-link';
+import i18n from '@/i18n';
+import { revokedDevicesStore } from '@/features/device-link/revokedDevicesStore';
+import { unresponsiveDevicesStore } from '@/features/device-link/unresponsiveDevicesStore';
+import { toast } from '@/lib/toast';
+import { ContentHeader } from '@/components/layout/ContentHeader';
+import { TaskRemoteDesktopButton } from '../TaskRemoteDesktopButton';
+
+const fixture = vi.hoisted(() => ({ devices: [] as DeviceLinkDeviceView[] }));
+vi.mock('@/features/feature-context', () => ({
+ useFeatureContentHeader: () => 'Task title',
+}));
+vi.mock('@/hooks/useMacFullscreen', () => ({
+ useMacFullscreen: () => ({ isMac: true, isFullscreen: false }),
+}));
+vi.mock('@/features/device-link/useDeviceLinkDeviceList', () => ({
+ useDeviceLinkDeviceList: () => fixture.devices,
+ useDeviceLinkDeviceListRequestState: () => ({ status: 'ready', error: null }),
+}));
+vi.mock('@/lib/toast', () => ({ toast: { error: vi.fn(), info: vi.fn() } }));
+
+const capabilities = {
+ version: 1,
+ enabled: true,
+ canControl: true,
+ platform: 'win32',
+ displays: [{ id: 'screen', width: 1920, height: 1080 }],
+};
+const invoke = vi.fn();
+const open = vi.fn();
+const device = (): DeviceLinkDeviceView => ({
+ deviceId: 'remote',
+ name: 'Remote computer',
+ platform: 'win32',
+ appVersion: '1',
+ lastSeenAt: null,
+ online: true,
+ busy: true,
+ remoteControlEnabled: true,
+ controlEnabled: true,
+ isSelf: false,
+});
+
+beforeEach(async () => {
+ vi.clearAllMocks();
+ revokedDevicesStore.clearAll();
+ unresponsiveDevicesStore.clearAll();
+ fixture.devices = [device()];
+ invoke.mockReset().mockResolvedValue(capabilities);
+ open.mockReset().mockResolvedValue(undefined);
+ Object.assign(window, { electronAPI: { deviceLink: { invoke }, openRemoteDesktop: open } });
+ await i18n.changeLanguage('en');
+});
+afterEach(() => {
+ cleanup();
+ revokedDevicesStore.clearAll();
+ unresponsiveDevicesStore.clearAll();
+ vi.restoreAllMocks();
+});
+
+function unavailable() {
+ const button = screen.getByRole('button', { name: /^Remote desktop unavailable:/ });
+ expect(button.className).toContain('opacity-50');
+ expect(button.querySelector('.lucide-monitor-off')).not.toBeNull();
+ const opens = open.mock.calls.length;
+ fireEvent.click(button);
+ expect(open).toHaveBeenCalledTimes(opens);
+ expect(toast.info).toHaveBeenCalledWith(button.getAttribute('aria-label'), { duration: 8000 });
+ return button;
+}
+
+it('checks the computer, then opens its remote desktop', async () => {
+ render(<TaskRemoteDesktopButton deviceId="remote" />);
+ const action = screen.getByRole('button', { name: 'Checking remote desktop…' });
+ expect(action.getAttribute('aria-disabled')).toBe('true');
+ await act(async () => {});
+ expect(invoke).toHaveBeenCalledExactlyOnceWith('remote', REMOTE_DESKTOP_CHANNEL, [
+ { op: 'capabilities' },
+ ]);
+ expect(screen.getByRole('button', { name: 'Open remote desktop' })).toBe(action);
+ expect(action.className).not.toContain('opacity-50');
+ fireEvent.click(action);
+ expect(open).toHaveBeenCalledExactlyOnceWith({ deviceId: 'remote', name: 'Remote computer' });
+ await act(async () => {});
+ expect(screen.getByRole('button', { name: 'Open remote desktop' })).toBe(action);
+});
+
+it.each([
+ [{ online: false }, 'This computer is offline.'],
+ [
+ { remoteControlEnabled: false },
+ i18n.getResource('en', 'common', 'remoteDesktop.remoteDisabled'),
+ ],
+ [
+ { controlEnabled: false },
+ i18n.getResource('en', 'common', 'remoteDesktop.shortcut.controlDisabled'),
+ ],
+] satisfies [Partial<DeviceLinkDeviceView>, string][])(
+ 'greys out with the reason, without probing, when the computer cannot be remoted now: %j',
+ async (patch, reason) => {
+ fixture.devices = [{ ...device(), ...patch }];
+ render(<TaskRemoteDesktopButton deviceId="remote" />);
+ await act(async () => {});
+ expect(unavailable().getAttribute('aria-label')).toContain(reason);
+ expect(invoke).not.toHaveBeenCalled();
+ },
+);
+
+it.each([[{ platform: 'ios' }], [{ isSelf: true }]] satisfies [Partial<DeviceLinkDeviceView>][])(
+ 'stays hidden for a device that is never a remote desktop target: %j',
+ async (patch) => {
+ fixture.devices = [{ ...device(), ...patch }];
+ render(<TaskRemoteDesktopButton deviceId="remote" />);
+ await act(async () => {});
+ expect(screen.queryByRole('button')).toBeNull();
+ expect(invoke).not.toHaveBeenCalled();
+ },
+);
+
+it.each([
+ [{ ...capabilities, enabled: false }, 'remoteDesktop.disabled'],
+ [
+ { ...capabilities, permissions: { screenRecording: 'missing', accessibility: 'granted' } },
+ 'remoteDesktop.shortcut.screenRecordingRequired',
+ ],
+])('explains why the computer refuses remote desktop: %j', async (value, reasonKey) => {
+ invoke.mockResolvedValue(value);
+ render(<TaskRemoteDesktopButton deviceId="remote" />);
+ await act(async () => {});
+ expect(unavailable().getAttribute('aria-label')).toContain(i18n.t(reasonKey));
+});
+
+it('rechecks an interrupted check when the user looks at it again', async () => {
+ invoke.mockRejectedValueOnce(new Error('[DEVICE_LINK_TIMEOUT] no invoke-result within 12000ms'));
+ render(<TaskRemoteDesktopButton deviceId="remote" />);
+ await act(async () => {});
+ const action = screen.getByRole('button', { name: /^Remote desktop unavailable:/ });
+ expect(invoke).toHaveBeenCalledOnce();
+ fireEvent.mouseEnter(action);
+ await act(async () => {});
+ expect(invoke).toHaveBeenCalledTimes(2);
+ expect(screen.getByRole('button', { name: 'Open remote desktop' })).toBe(action);
+ fireEvent.mouseEnter(action);
+ await act(async () => {});
+ expect(invoke).toHaveBeenCalledTimes(2);
+});
+
+it('does not recheck a definitive refusal on hover', async () => {
+ invoke.mockResolvedValue({ ...capabilities, enabled: false });
+ render(<TaskRemoteDesktopButton deviceId="remote" />);
+ await act(async () => {});
+ fireEvent.mouseEnter(screen.getByRole('button'));
+ await act(async () => {});
+ expect(invoke).toHaveBeenCalledOnce();
+});
+
+it('coalesces repeated clicks and explains a failed open in StrictMode', async () => {
+ let reject!: (error: Error) => void;
+ open.mockReturnValue(
+ new Promise((_resolve, fail) => {
+ reject = fail;
+ }),
+ );
+ render(
+ <StrictMode>
+ <TaskRemoteDesktopButton deviceId="remote" />
+ </StrictMode>,
+ );
+ await act(async () => {});
+ const action = screen.getByRole('button', { name: 'Open remote desktop' });
+ fireEvent.click(action);
+ expect(screen.getByRole('button', { name: 'Opening remote desktop…' })).toBe(action);
+ fireEvent.click(action);
+ expect(open).toHaveBeenCalledOnce();
+ await act(async () => reject(new Error('ACCESS_REVOKED')));
+ expect(toast.error).toHaveBeenCalledWith(i18n.t('remoteDesktop.connectionError'));
+ expect(unavailable()).toBe(action);
+ expect(action.getAttribute('aria-label')).toContain(i18n.t('remoteDesktop.accessRevoked'));
+ fireEvent.mouseEnter(action);
+ await act(async () => {});
+ expect(invoke).toHaveBeenCalledOnce();
+});
+
+it('rechecks after the connection drops while opening', async () => {
+ open.mockRejectedValueOnce(new Error('PEER_OFFLINE'));
+ render(<TaskRemoteDesktopButton deviceId="remote" />);
+ await act(async () => {});
+ fireEvent.click(screen.getByRole('button', { name: 'Open remote desktop' }));
+ await act(async () => {});
+ const action = screen.getByRole('button', { name: /^Remote desktop unavailable:/ });
+ expect(action.getAttribute('aria-label')).toContain(i18n.t('remoteDesktop.shortcut.offline'));
+ fireEvent.mouseEnter(action);
+ await act(async () => {});
+ expect(invoke).toHaveBeenCalledTimes(2);
+ fireEvent.click(screen.getByRole('button', { name: 'Open remote desktop' }));
+ await act(async () => {});
+ expect(open).toHaveBeenCalledTimes(2);
+});
+
+it('keeps the remote desktop action clickable in the mac titlebar trailing slot', async () => {
+ render(
+ <ContentHeader
+ sidebarVisible
+ showCollapsedActions={false}
+ isSidebarRail={false}
+ rightSidebarAvailable
+ hidden={false}
+ trailing={<TaskRemoteDesktopButton deviceId="remote" />}
+ />,
+ );
+ await act(async () => {});
+ const header = screen.getByRole('banner');
+ const action = screen.getByRole('button', { name: 'Open remote desktop' });
+ expect(header.textContent).toContain('Task title');
+ expect(header.contains(action)).toBe(true);
+ expect((action.style as CSSStyleDeclaration & { WebkitAppRegion?: string }).WebkitAppRegion).toBe(
+ 'no-drag',
+ );
+ fireEvent.click(action);
+ expect(open).toHaveBeenCalledExactlyOnceWith({ deviceId: 'remote', name: 'Remote computer' });
+ await act(async () => {});
+});