Skip to content

armgit / cindy

Public Imported from GitHub
0

Consider it done. The open-source AI agent that works out of the box · 想到,就能做到。开源、开箱即用的 AI Agent。

fix(downloads): skip checkpoints for one-shot transfers

Dashc79f8ae1d2ff
diff --git a/apps/desktop/src/main/downloader/__tests__/download.test.ts b/apps/desktop/src/main/downloader/__tests__/download.test.ts
index 633464e71a..cecbf0aa73 100644
--- a/apps/desktop/src/main/downloader/__tests__/download.test.ts
+++ b/apps/desktop/src/main/downloader/__tests__/download.test.ts
@@ -45,6 +45,57 @@ afterEach(() => {
for (const root of roots.splice(0)) fs.rmSync(root, { recursive: true, force: true });
});
describe('shared verified downloads', () => {
+ it.each(['complete', 'cancel'] as const)(
+ 'never checkpoints a one-shot authorized URL: %s',
+ async (outcome) => {
+ const opts = {
+ ...options(),
+ url: 'https://publisher.test/file?signature=synthetic-secret',
+ resume: false,
+ };
+ const checkpoint = vi.spyOn(resume, 'writeMeta');
+ const controller = new AbortController();
+ let pulls = 0;
+ let body!: ReadableStreamDefaultController<Uint8Array>;
+ fetchMock.mockImplementation((_url, { signal }) =>
+ Promise.resolve(
+ new Response(
+ new ReadableStream<Uint8Array>(
+ {
+ start(stream) {
+ body = stream;
+ signal.addEventListener('abort', () => stream.error(new Error('aborted')), {
+ once: true,
+ });
+ },
+ pull(stream) {
+ if (++pulls === 1) stream.enqueue(Buffer.from('abc'));
+ },
+ },
+ { highWaterMark: 0 },
+ ),
+ ),
+ ),
+ );
+ const pending = download({ ...opts, signal: controller.signal });
+ const result =
+ outcome === 'cancel'
+ ? expect(pending).rejects.toMatchObject({ code: 'ABORTED' })
+ : expect(pending).resolves.toMatchObject({ size: 6 });
+ await vi.waitFor(() => expect(pulls).toBe(2));
+ expect(checkpoint).not.toHaveBeenCalled();
+ expect(fs.existsSync(`${opts.targetPath}.meta.json`)).toBe(false);
+ if (outcome === 'cancel') controller.abort();
+ else {
+ body.enqueue(Buffer.from('def'));
+ body.close();
+ }
+ await result;
+ expect(checkpoint).not.toHaveBeenCalled();
+ expect(fs.existsSync(`${opts.targetPath}.meta.json`)).toBe(false);
+ expect(fs.existsSync(`${opts.targetPath}.part`)).toBe(false);
+ },
+ );
it.each([
['resume', false],
['cache', false],
diff --git a/apps/desktop/src/main/downloader/transport.ts b/apps/desktop/src/main/downloader/transport.ts
index c855a0769f..54c7e3c331 100644
--- a/apps/desktop/src/main/downloader/transport.ts
+++ b/apps/desktop/src/main/downloader/transport.ts
@@ -202,16 +202,17 @@ export async function executeOnce(ctx: TransportContext): Promise<TransportResul
total: opts.expectedSize ?? total,
onProgress: opts.onProgress,
});
- meta = {
- url: opts.url,
- expectedSize: opts.expectedSize ?? total,
- expectedSha256: opts.sha256,
- downloadedBytes: loaded,
- etag: response.headers.get('etag'),
- lastModified: response.headers.get('last-modified'),
- createdAt: new Date().toISOString(),
- updatedAt: new Date().toISOString(),
- };
+ if (opts.resume !== false)
+ meta = {
+ url: opts.url,
+ expectedSize: opts.expectedSize ?? total,
+ expectedSha256: opts.sha256,
+ downloadedBytes: loaded,
+ etag: response.headers.get('etag'),
+ lastModified: response.headers.get('last-modified'),
+ createdAt: new Date().toISOString(),
+ updatedAt: new Date().toISOString(),
+ };
let lastMetaWriteAt = 0;
armTimer(opts.timeout?.idleMs ?? 30_000);
while (true) {
@@ -231,7 +232,7 @@ export async function executeOnce(ctx: TransportContext): Promise<TransportResul
await hasher.update(Buffer.from(value));
loaded += value.byteLength;
tracker.advance(value.byteLength);
- if (Date.now() - lastMetaWriteAt >= 2000) {
+ if (meta && Date.now() - lastMetaWriteAt >= 2000) {
try {
writeMeta(opts.targetPath, {
...meta,
diff --git a/docs/dev-rules/verified-downloads.md b/docs/dev-rules/verified-downloads.md
index 17040954ae..7e5c53751e 100644
--- a/docs/dev-rules/verified-downloads.md
+++ b/docs/dev-rules/verified-downloads.md
@@ -14,6 +14,7 @@ Agent runtime、Cindy Make 工具、Ollama runtime、插件包、Skill 包及更
- `signal` 取消排队、请求、缓存/续传哈希和重试等待;连接/闲置超时可重试,`timeout.totalMs`
限制取得下载槽位后的活动时长(含校验和重试等待,不含排队)。业务取消与超时分别返回 `ABORTED` 和 `TIMEOUT`。
- 默认保留部分文件以续传;一次性安装暂存目录可用 `resume: false`。
+ 此模式不创建或写入续传元数据,避免将一次性授权 URL 留在磁盘;失败时删除部分文件。
调用方只有在下载 Promise 结束后才可 `cleanup()` 或删除暂存目录。
- 默认校验成功后替换目标,下载失败保留原目标;`existingTarget: 'error'`
原子地拒绝覆盖已有文件。不要让多个进程共写同一个暂存路径。