Skip to content

Free, open source blog writer for Claude Code. Researches current sources, writes answer-first posts for Google and AI answers, has an independent reviewer score each one out of 100 and ships only after five delivery gates. 32 skills, 30 /blog commands, 5 agents. Active development at AI-Marketing-Hub/claude-blog; public releases ship here.

7.3 KB
Raw Blame
"""Wave 3 regression tests: blog-image validator and MCP setup key handling."""

from __future__ import annotations

import datetime
import importlib.util
import json
import os
import stat
import subprocess
import sys
from pathlib import Path

import pytest

ROOT = Path(__file__).resolve().parents[1]
SCRIPTS = ROOT / "skills" / "blog-image" / "scripts"
VALIDATE = SCRIPTS / "validate_image_setup.py"
SETUP = SCRIPTS / "setup_image_mcp.py"

GOOGLE_KEY = "AIza" + "A" * 35
OTHER_KEY = "sk-" + "b" * 30


def _load(path: Path):
    spec = importlib.util.spec_from_file_location(f"wave3_{path.stem}", path)
    module = importlib.util.module_from_spec(spec)
    spec.loader.exec_module(module)
    return module


@pytest.fixture(scope="module")
def validate():
    return _load(VALIDATE)


@pytest.fixture(scope="module")
def setup():
    return _load(SETUP)


EARLY = datetime.date(2026, 1, 1)
LATE = datetime.date(2026, 10, 12)


@pytest.mark.parametrize("model", ["gemini-3.1-flash-image-preview", "gemini-3-pro-image-preview"])
def test_accepted_model_passes_while_google_still_serves_it(validate, model):
    ok, detail = validate.validate_nanobanana_model(model, EARLY)
    assert ok is True
    assert "shuts down on 2026-06-25" in detail


@pytest.mark.parametrize("model", ["gemini-3.1-flash-image-preview", "gemini-3-pro-image-preview", ""])
def test_accepted_model_fails_after_the_shutdown_with_a_clear_reason(validate, model):
    ok, detail = validate.validate_nanobanana_model(model, LATE)
    assert ok is False
    assert "shut it down on 2026-06-25" in detail


def test_unset_model_reports_the_package_default(validate):
    ok, detail = validate.validate_nanobanana_model("", EARLY)
    assert ok is True and "pinned package default" in detail


def test_direct_ids_are_valid_google_models_the_package_cannot_use(validate):
    ok, detail = validate.validate_nanobanana_model("gemini-3.1-flash-image", LATE)
    assert ok is False
    assert "falls back" in detail and "direct API" in detail
    for name in ("gemini-nano-banana-2.1", "gemini-3.1-flash-lite-image", "gemini-3-pro-image"):
        assert name in validate.DIRECT_API_MODELS


@pytest.mark.parametrize("model", ["flash", "pro"])
def test_aliases_are_not_env_values(validate, model):
    ok, detail = validate.validate_nanobanana_model(model, EARLY)
    assert ok is False and "set_model" in detail


def test_stale_ids_name_current_replacements_and_drop_unverified_ones(validate):
    assert "gemini-2.0-flash-exp" not in validate.DEPRECATED_MODEL_REPLACEMENTS
    ok, detail = validate.validate_nanobanana_model("imagen-4.0-generate-001", LATE)
    assert not ok and "2026-08-17" in detail


def test_recommendation_points_at_direct_path_and_cites_google(validate):
    text = validate.RECOMMENDATION
    assert "scripts/generate_hero.py" in text
    assert "gemini-3.1-flash-image" in text
    assert "https://ai.google.dev/gemini-api/docs/models" in text
    assert "https://ai.google.dev/gemini-api/docs/deprecations" in text


def test_cli_json_reports_failure_and_recommendation(tmp_path):
    settings = tmp_path / ".claude" / "settings.json"
    settings.parent.mkdir()
    settings.write_text(json.dumps({"mcpServers": {"nanobanana-mcp": {
        "command": "npx",
        "args": ["-y", "@ycse/[email protected]"],
        "env": {"GOOGLE_AI_API_KEY": GOOGLE_KEY, "NANOBANANA_MODEL": "gemini-3.1-flash-image-preview"},
    }}}))
    env = dict(os.environ, HOME=str(tmp_path))
    result = subprocess.run(
        [sys.executable, str(VALIDATE), "--json"], capture_output=True, text=True,
        env=env, cwd=tmp_path,
    )
    payload = json.loads(result.stdout)
    labels = {c["label"]: c for c in payload["checks"]}
    assert labels["NANOBANANA_MODEL is supported"]["passed"] is False
    assert "shut it down" in labels["NANOBANANA_MODEL is supported"]["detail"]
    assert "generate_hero.py" in payload["recommendation"]
    assert result.returncode == 1


# ---- setup_image_mcp key handling ----------------------------------------

def test_extract_single_key_forms(setup):
    assert setup.extract_api_key(GOOGLE_KEY + "\n") == GOOGLE_KEY
    assert setup.extract_api_key(f"GOOGLE_AI_API_KEY={GOOGLE_KEY}\n") == GOOGLE_KEY
    assert setup.extract_api_key(f"# my key\n\nexport GEMINI_API_KEY='{GOOGLE_KEY}'\n") == GOOGLE_KEY
    assert setup.extract_api_key("a" * 40) == "a" * 40


def test_extract_refuses_files_with_a_second_secret(setup):
    with pytest.raises(ValueError, match="more than one secret") as exc:
        setup.extract_api_key(f"GOOGLE_AI_API_KEY={GOOGLE_KEY}\nOPENAI_API_KEY={OTHER_KEY}\n")
    assert OTHER_KEY not in str(exc.value) and GOOGLE_KEY not in str(exc.value)
    assert "OPENAI_API_KEY" in str(exc.value)
    with pytest.raises(ValueError, match="more than one secret"):
        setup.extract_api_key(f"{GOOGLE_KEY}\nAIza{'B' * 35}\n")
    with pytest.raises(ValueError, match="more than one secret"):
        setup.extract_api_key(f"{GOOGLE_KEY}\nSLACK_TOKEN=xox" + "b-123456789012-abcdef\n")


def test_extract_refuses_when_no_key(setup):
    with pytest.raises(ValueError, match="No Google AI API key"):
        setup.extract_api_key("hello world\nFOO=bar\n")
    with pytest.raises(ValueError, match="empty"):
        setup.extract_api_key("\n# only a comment\n")


def _run_setup(tmp_path, key_text):
    key_file = tmp_path / "keys.env"
    key_file.write_text(key_text)
    env = dict(os.environ, HOME=str(tmp_path))
    env.pop("GOOGLE_AI_API_KEY", None)
    return subprocess.run(
        [sys.executable, str(SETUP), "--key-file", str(key_file), "--global", "--json"],
        capture_output=True, text=True, env=env, cwd=tmp_path,
    )


def test_multi_secret_key_file_never_reaches_settings(tmp_path):
    result = _run_setup(tmp_path, f"GOOGLE_AI_API_KEY={GOOGLE_KEY}\nOPENAI_API_KEY={OTHER_KEY}\n")
    assert result.returncode == 1
    assert "more than one secret" in result.stdout
    assert OTHER_KEY not in result.stdout + result.stderr
    assert not (tmp_path / ".claude" / "settings.json").exists()


def test_single_key_file_writes_only_the_key_with_mode_600(tmp_path):
    result = _run_setup(tmp_path, f"# comment\nGOOGLE_AI_API_KEY={GOOGLE_KEY}\n")
    assert result.returncode == 0, result.stdout
    settings = tmp_path / ".claude" / "settings.json"
    config = json.loads(settings.read_text())
    assert config["mcpServers"]["nanobanana-mcp"]["env"]["GOOGLE_AI_API_KEY"] == GOOGLE_KEY
    assert "comment" not in settings.read_text()
    assert stat.S_IMODE(settings.stat().st_mode) == 0o600
    assert "generate_hero.py" in json.loads(result.stdout)["warning"]


def test_setup_rejects_a_multiline_key_passed_directly(setup, tmp_path, monkeypatch, capsys):
    monkeypatch.setattr(setup, "GLOBAL_SETTINGS_PATH", tmp_path / "settings.json")
    with pytest.raises(SystemExit):
        setup.setup_mcp(f"{GOOGLE_KEY}\nOPENAI_API_KEY={OTHER_KEY}", True, True)
    assert not (tmp_path / "settings.json").exists()


def test_save_config_works_without_fchmod(setup, tmp_path, monkeypatch):
    """Windows has no os.fchmod; the config must still be written with a private mode."""
    monkeypatch.delattr(os, "fchmod", raising=False)
    target = tmp_path / "settings.json"
    setup.save_config(target, {"k": "v"}, quiet=True)
    assert json.loads(target.read_text()) == {"k": "v"}
    if os.name == "posix":
        assert stat.S_IMODE(target.stat().st_mode) == 0o600