Skip to content

Business operating system for Claude Code — 57 skills, 21 agents, smart daemon. Unified inbox (WhatsApp/Email/Slack/Telegram), autonomous PR merge, full-AWS monitoring, revenue (Stripe+RevenueCat), e-commerce (Shopify), marketing (Klaviyo/Meta/GA4), voice (Bland/ElevenLabs), APM (Datadog/NewRelic/OTEL), YOLO mode.

fix(security): stop shelling out with untrusted input in rotation + opener (#832)

Aurora Capitalaa7a10cb31e6
diff --git a/claude-ops/lib/opener.mjs b/claude-ops/lib/opener.mjs
index 4fe9923b..be24d4e7 100644
--- a/claude-ops/lib/opener.mjs
+++ b/claude-ops/lib/opener.mjs
@@ -105,6 +105,13 @@ export async function openTarget(target) {
return { ok: false, command: null, target: '' };
}
+ // `target` reaches here straight from argv when this module is used as a CLI.
+ // A NUL/newline is never valid in a URL or path, so reject those everywhere.
+ if (/[\u0000-\u001F\u007F]/.test(target)) {
+ process.stderr.write('opener: refusing target containing control characters\n');
+ return { ok: false, command: null, target };
+ }
+
const cmd = resolveOpener();
if (!cmd) {
process.stderr.write('opener: no URL opener available on this host\n');
@@ -118,6 +125,15 @@ export async function openTarget(target) {
const isWindowsStart = cmd === 'cmd.exe /c start' || osId() === 'windows' || process.platform === 'win32';
if (isWindowsStart && cmd.includes('start')) {
+ // Node quotes argv entries, but `cmd.exe /c` then strips the outer quotes and
+ // re-parses the string. A double quote inside `target` escapes that quoting and
+ // everything after it is interpreted by cmd. `&` and friends stay inert while
+ // quoted — which is why only the quote-breakout is rejected here, rather than
+ // stripping characters that appear legitimately in URL query strings.
+ if (target.includes('"')) {
+ process.stderr.write('opener: refusing target containing a double quote on Windows\n');
+ return { ok: false, command: cmd, target };
+ }
const child = spawn('cmd.exe', ['/c', 'start', '', target], {
detached: true,
stdio: 'ignore',
diff --git a/claude-ops/scripts/account-rotation/crs-token-feed.mjs b/claude-ops/scripts/account-rotation/crs-token-feed.mjs
index 82ccb5a5..f12dff66 100644
--- a/claude-ops/scripts/account-rotation/crs-token-feed.mjs
+++ b/claude-ops/scripts/account-rotation/crs-token-feed.mjs
@@ -16,7 +16,7 @@
import { readFileSync, appendFileSync } from 'fs';
import { join, dirname } from 'path';
import { fileURLToPath } from 'url';
-import { execSync, spawnSync } from 'child_process';
+import { execFileSync, spawnSync } from 'child_process';
import { foreignActiveKeys } from './account-leases.mjs';
import { assertCrsInvariant } from './route-state.mjs';
import { acquireRefreshLock, claimRefreshPace } from './crs-refresh-lock.mjs';
@@ -108,12 +108,20 @@ async function oauthRefresh(refreshToken) {
async function crsLogin(crsBase, crsContainer, adminUser = 'cradmin') {
let pw = '';
try {
- pw = execSync(
- `docker inspect ${crsContainer} --format '{{range .Config.Env}}{{println .}}{{end}}' | sed -n 's/^ADMIN_PASSWORD=//p'`,
- { timeout: 8000 },
- )
- .toString()
- .trim();
+ // The container name came from config/env and used to be interpolated into a shell
+ // pipeline. Run docker directly with argv and do the ADMIN_PASSWORD extraction in JS,
+ // so no part of this can be interpreted as shell syntax.
+ const envDump = execFileSync(
+ 'docker',
+ ['inspect', crsContainer, '--format', '{{range .Config.Env}}{{println .}}{{end}}'],
+ { timeout: 8000, encoding: 'utf8' },
+ );
+ for (const line of envDump.split('\n')) {
+ if (line.startsWith('ADMIN_PASSWORD=')) {
+ pw = line.slice('ADMIN_PASSWORD='.length).trim();
+ break;
+ }
+ }
} catch {}
if (!pw) return null;
if (!process.env.CRS_ADMIN_PASSWORD) process.env.CRS_ADMIN_PASSWORD = pw;
diff --git a/claude-ops/scripts/account-rotation/refresh-tokens.mjs b/claude-ops/scripts/account-rotation/refresh-tokens.mjs
index b08deadb..b55f9340 100644
--- a/claude-ops/scripts/account-rotation/refresh-tokens.mjs
+++ b/claude-ops/scripts/account-rotation/refresh-tokens.mjs
@@ -19,7 +19,7 @@ import { appendFileSync, existsSync, readFileSync, writeFileSync, renameSync } f
import { join, dirname } from 'path';
import { userInfo } from 'os';
import { fileURLToPath } from 'url';
-import { execFileSync, execSync } from 'child_process';
+import { execFileSync, spawnSync } from 'child_process';
import { fetchWithProxyFallback } from './proxy-helper.mjs';
import { acquireRefreshLock, claimRefreshPace } from './crs-refresh-lock.mjs';
import { readRotationToken, reconcileRemoteRotationVault, writeRotationTokenCoordinated } from './rotation-vault.mjs';
@@ -73,7 +73,14 @@ function tokenService(account) {
}
function readKeychain(svc = KEYCHAIN_SERVICE, acct = KEYCHAIN_ACCOUNT) {
- const out = execSync(`security find-generic-password -s "${svc}" -a "${acct}" -g 2>&1`, { timeout: 5000 }).toString();
+ // `security -g` writes the password to stderr, not stdout, which is why this used to
+ // shell out with `2>&1`. spawnSync exposes both streams without a shell, so the
+ // service/account names can no longer be interpreted as shell syntax.
+ const res = spawnSync('security', ['find-generic-password', '-s', svc, '-a', acct, '-g'], {
+ timeout: 5000,
+ encoding: 'utf8',
+ });
+ const out = `${res.stdout || ''}${res.stderr || ''}`;
const m = out.match(/^password: "?(.*?)"?$/m);
if (!m) throw new Error(`No keychain entry ${svc}/${acct}`);
return m[1].replace(/\\"/g, '"');
@@ -110,11 +117,16 @@ function syncStoredTokenToCrs(account) {
if (process.env.CLAUDE_ROTATION_SKIP_CRS_SYNC === '1') return;
const key = accountKey(account);
try {
- const out = execSync(`node "${join(__dirname, 'sync-crs-account.mjs')}" ${JSON.stringify(key)} 2>&1`, {
+ // JSON.stringify only adds double quotes, and $(...) is still expanded inside shell
+ // double quotes, so the account key must never reach a shell. Pass it as an argv entry.
+ const res = spawnSync('node', [join(__dirname, 'sync-crs-account.mjs'), key], {
timeout: 45_000,
- })
- .toString()
- .trim();
+ encoding: 'utf8',
+ });
+ if (res.status !== 0) {
+ throw new Error(`${res.stderr || res.stdout || `exit ${res.status}`}`.trim());
+ }
+ const out = `${res.stdout || ''}${res.stderr || ''}`.trim();
log(out.split('\n').slice(-1)[0] || `${key}: CRS sync complete`);
} catch (err) {
log(`${key}: ⚠ CRS sync failed — ${String(err.message || err).slice(0, 180)}`);
diff --git a/claude-ops/scripts/account-rotation/rotate.mjs b/claude-ops/scripts/account-rotation/rotate.mjs
index b454bf2d..2bc52361 100644
--- a/claude-ops/scripts/account-rotation/rotate.mjs
+++ b/claude-ops/scripts/account-rotation/rotate.mjs
@@ -1501,7 +1501,9 @@ function readLatestSMSCode({ maxAgeSec = 300 } = {}) {
// Apple timestamp = seconds since 2001-01-01, stored as nanoseconds
const cutoffAppleNs = (Math.floor(Date.now() / 1000) - 978307200 - maxAgeSec) * 1_000_000_000;
const sql = `SELECT hex(attributedBody), text FROM message WHERE date > ${cutoffAppleNs} AND service IN ('SMS','iMessage') ORDER BY date DESC LIMIT 10;`;
- const rows = execSync(`sqlite3 "${db}" "${sql}"`, { timeout: 5000 }).toString().split('\n').filter(Boolean);
+ // $HOME feeds `db`, so the old shell string let the environment inject sqlite3 args
+ // or shell syntax. execFileSync passes both as argv entries instead.
+ const rows = execFileSync('sqlite3', [db, sql], { timeout: 5000, encoding: 'utf8' }).split('\n').filter(Boolean);
for (const row of rows) {
const [hex, text] = row.split('|');
// Plain text column (older macOS)