Business operating system for Claude Code — 57 skills, 21 agents, smart daemon. Unified inbox (WhatsApp/Email/Slack/Telegram), autonomous PR merge, full-AWS monitoring, revenue (Stripe+RevenueCat), e-commerce (Shopify), marketing (Klaviyo/Meta/GA4), voice (Bland/ElevenLabs), APM (Datadog/NewRelic/OTEL), YOLO mode.
Shell agent-teamsai-agentai-automationanthropicautonomous-agentawsbusiness-operationsclaudeclaude-codeclaude-code-plugindevopsecommerceinbox-zeroklaviyomarketingmcpmorning-briefingpr-automationshopifyterminal
fix: address PR review findings
auroracapitalb49ff35d235b
diff --git a/claude-ops/scripts/account-rotation/provision-coordination.mjs b/claude-ops/scripts/account-rotation/provision-coordination.mjsindex ccd4bdc2..d31935a0 100755--- a/claude-ops/scripts/account-rotation/provision-coordination.mjs+++ b/claude-ops/scripts/account-rotation/provision-coordination.mjs@@ -91,8 +91,8 @@ function sameCanonicalPath(left, right) {typeof left === 'string' && typeof right === 'string' && canonicalProspective(left) === canonicalProspective(right));}-function assertSafeAncestors(path) {- let cursor = dirname(canonicalProspective(path));+function assertSafeAncestorChain(path) {+ let cursor = dirname(path);while (!existsSync(cursor)) cursor = dirname(cursor);let immediate = true;for (;;) {@@ -106,6 +106,13 @@ function assertSafeAncestors(path) {immediate = false;}}+function assertSafeAncestors(path) {+ const raw = resolve(path);+ const canonical = canonicalProspective(path);+ // macOS system paths contain root-owned compatibility symlinks such as /var.+ if (platform() !== 'darwin') assertSafeAncestorChain(raw);+ assertSafeAncestorChain(canonical);+}function mode(path) {return statSync(path).mode & 0o777;}diff --git a/claude-ops/scripts/crsproxy-reauth/bu_reauth.py b/claude-ops/scripts/crsproxy-reauth/bu_reauth.pyindex 2f6e9c93..9342c706 100644--- a/claude-ops/scripts/crsproxy-reauth/bu_reauth.py+++ b/claude-ops/scripts/crsproxy-reauth/bu_reauth.py@@ -20,7 +20,7 @@ Features:keeps browser session alive, waits for a file-based trigger, thenresumes with a follow-up run in the same session to click Authorizeand capture the callback URL.- - Serialization lease: checks /tmp/crsproxy-claude-oauth-lease.json+ - Serialization lease: checks /opt/crsproxy/state/crsproxy-claude-oauth-lease.jsonbefore starting a login, waits if held, cleans up after completion.- Email cooldown: tracks verification code send timestamps, enforcesa 5-minute cooldown if >3 codes are sent in 5 minutes, logs@@ -61,7 +61,7 @@ Usage:# When hCaptcha is detected, the script emits the live_view_url and waits.# After solving the captcha in the browser, create the trigger file:- # touch /tmp/bu_reauth_checkpoint_trigger+ # touch /opt/crsproxy/state/bu_reauth_checkpoint_trigger# The script will then create a follow-up run and complete the flow."""@@ -88,8 +88,9 @@ AUTH_DIR = Path("/opt/crsproxy/auths")HOME_DIR = Path("/opt/crsproxy")BU_API_BASE = "https://api.browser-use.com/api/v4"BU_MODEL = "gpt-5.6-luna"-LOG_DIR = Path("/tmp")-LEASE_FILE = Path("/tmp/crsproxy-claude-oauth-lease.json")+STATE_DIR = Path(os.environ.get("CRSPROXY_STATE_DIR", "/opt/crsproxy/state"))+LOG_DIR = STATE_DIR+LEASE_FILE = STATE_DIR / "crsproxy-claude-oauth-lease.json"CANARY_URL = "http://localhost:8319/v1/chat/completions"# Exit codes@@ -109,13 +110,13 @@ TOTAL_TIMEOUT = 300 # overall script timeout (5 minutes)LEASE_STALE_SECONDS = 600 # lease older than 10 min is stale# Human checkpoint (hCaptcha) configuration-CHECKPOINT_FILE = Path("/tmp/bu_reauth_checkpoint.json")-CHECKPOINT_TRIGGER = Path("/tmp/bu_reauth_checkpoint_trigger")+CHECKPOINT_FILE = STATE_DIR / "bu_reauth_checkpoint.json"+CHECKPOINT_TRIGGER = STATE_DIR / "bu_reauth_checkpoint_trigger"CHECKPOINT_POLL_INTERVAL = 5 # seconds between trigger pollsCHECKPOINT_TIMEOUT = 600 # 10 minutes for human to solve captcha# Email cooldown configuration-EMAIL_COOLDOWN_FILE = Path("/tmp/crsproxy-email-cooldown.json")+EMAIL_COOLDOWN_FILE = STATE_DIR / "crsproxy-email-cooldown.json"EMAIL_COOLDOWN_WINDOW = 300 # 5 min sliding window for counting code sendsEMAIL_COOLDOWN_THRESHOLD = 3 # max 3 code sends before cooldown triggersEMAIL_COOLDOWN_DURATION = 300 # 5 min cooldown when threshold exceeded@@ -188,8 +189,8 @@ def log(msg: str):try:_log_file.write(line + "\n")_log_file.flush()- except Exception:- pass+ except Exception as e:+ print(f"[WARN] File logging failed: {e}", file=sys.stderr)def sanitize_url(raw: str) -> str:@@ -203,7 +204,8 @@ def sanitize_url(raw: str) -> str:if parsed.scheme in ("http", "https"):return f"{parsed.scheme}://{parsed.netloc}{parsed.path}"except Exception:- pass+ # Invalid URLs are treated as unsafe to log.+ return ""return ""@@ -316,7 +318,7 @@ def validate_candidate(auth_path: Path, expected_email: str,# 401/403 = accounts in cooldown/auth issues — all indicate the# proxy is alive. -1 = connection error — proxy is down.if status < 0:- return False, f"canary request failed: proxy unreachable (connection error)"+ return False, "canary request failed: proxy unreachable (connection error)"return True, "all checks passed"@@ -333,11 +335,16 @@ def activate_auth_file(auth_path: Path) -> bool:Returns True on success, False on failure."""try:+ orig_mode = auth_path.stat().st_mode & 0o777auth = json.loads(auth_path.read_text())auth["disabled"] = Falsetmp_path = auth_path.with_suffix(".tmp")- tmp_path.write_text(json.dumps(auth, indent=2))- os.rename(str(tmp_path), str(auth_path))+ with open(tmp_path, "w", encoding="utf-8") as fh:+ fh.write(json.dumps(auth, indent=2))+ fh.flush()+ os.fsync(fh.fileno())+ os.chmod(tmp_path, orig_mode)+ os.replace(tmp_path, auth_path)log(f"Auth file activated: {auth_path.name}")return Trueexcept Exception as e:@@ -352,11 +359,16 @@ def disable_auth_file(auth_path: Path) -> bool:Returns True on success, False on failure."""try:+ orig_mode = auth_path.stat().st_mode & 0o777auth = json.loads(auth_path.read_text())auth["disabled"] = Truetmp_path = auth_path.with_suffix(".tmp")- tmp_path.write_text(json.dumps(auth, indent=2))- os.rename(str(tmp_path), str(auth_path))+ with open(tmp_path, "w", encoding="utf-8") as fh:+ fh.write(json.dumps(auth, indent=2))+ fh.flush()+ os.fsync(fh.fileno())+ os.chmod(tmp_path, orig_mode)+ os.replace(tmp_path, auth_path)log(f"Auth file disabled: {auth_path.name}")return Trueexcept Exception as e:@@ -390,7 +402,7 @@ def acquire_lease(provider: str, max_wait: int = 120) -> bool:first_check = Falseif time.time() - t0 >= max_wait:log(f"Lease wait timed out after {max_wait}s — "- f"another login may still be in progress")+ "another login may still be in progress")return Falsetime.sleep(5)continue@@ -400,8 +412,8 @@ def acquire_lease(provider: str, max_wait: int = 120) -> bool:except (json.JSONDecodeError, OSError):try:LEASE_FILE.unlink()- except OSError:- pass+ except OSError as e:+ log(f"Stale lease cleanup error: {e}")# Lease file doesn't exist or was removed — acquirebreak@@ -431,8 +443,8 @@ def _load_cooldown_state() -> dict:try:if EMAIL_COOLDOWN_FILE.exists():return json.loads(EMAIL_COOLDOWN_FILE.read_text())- except Exception:- pass+ except Exception as e:+ log(f"Cooldown state load error: {e}")return {"send_timestamps": [], "cooldown_until": 0}@@ -598,8 +610,8 @@ class BrowserUseClient:try:self._request("PATCH", f"/runs/{run_id}",json={"action": "cancel"})- except Exception:- pass+ except Exception as e:+ log(f"Run cancellation error: {e}")def stop_browser(self, browser_id: str):"""Stop a browser session via PATCH /api/v4/browsers/{id}."""@@ -640,7 +652,8 @@ class BrowserUseClient:# Unknown shape — return empty rather than iterating dict keyslog(f"list_browsers: unexpected response shape: {type(data).__name__}")return []- except Exception:+ except Exception as e:+ log(f"list_browsers error: {e}")return []def stop_all_browsers(self):@@ -929,15 +942,20 @@ def detect_captcha(run_result: dict, client: BrowserUseClient) -> bool:# ---------------------------------------------------------------------------# Human captcha checkpoint# ---------------------------------------------------------------------------+def _ensure_state_dir(path: Path | None = None):+ """Create the private runtime state directory."""+ state_dir = path or STATE_DIR+ state_dir.mkdir(mode=0o700, parents=True, exist_ok=True)+ os.chmod(state_dir, 0o700)++def write_checkpoint(session_id: str, run_id: str, browser_session_id: str,live_view_url: str, provider: str, email: str,callback_port: int):"""Write checkpoint state to a file for human captcha solving.- The checkpoint file contains the full live_view_url (needed by Sam to- access the browser), the session_id (for follow-up runs), and metadata- about the reauth attempt. The file is world-readable so the- orchestrator can read it without sudo.+ The private checkpoint file contains the full live_view_url, session_id,+ and reauth metadata needed for the follow-up run."""data = {"session_id": session_id,@@ -951,7 +969,9 @@ def write_checkpoint(session_id: str, run_id: str, browser_session_id: str,"timestamp": time.time(),}try:+ _ensure_state_dir(CHECKPOINT_FILE.parent)CHECKPOINT_FILE.write_text(json.dumps(data, indent=2))+ os.chmod(CHECKPOINT_FILE, 0o600)log(f"[CAPTCHA_CHECKPOINT] Checkpoint file: {CHECKPOINT_FILE}")except Exception as e:log(f"[CAPTCHA_CHECKPOINT] Could not write checkpoint file: {e}")@@ -962,7 +982,7 @@ def wait_for_checkpoint_signal(timeout: int = CHECKPOINT_TIMEOUT) -> bool:Polls for the existence of CHECKPOINT_TRIGGER every CHECKPOINT_POLL_INTERVALseconds. Returns True if the trigger appears, False on timeout.- The trigger file can be created by: touch /tmp/bu_reauth_checkpoint_trigger+ The trigger file can be created in the private state directory."""log(f"[CAPTCHA_CHECKPOINT] Waiting up to {timeout}s for trigger: {CHECKPOINT_TRIGGER}")t0 = time.time()@@ -1030,8 +1050,7 @@ def handle_captcha_checkpoint(client: BrowserUseClient, run_id: str,# browser session. It is NOT an OAuth URL and does not contain OAuth# tokens or callback codes. Emit the full URL so Sam can open it.# Also emit a sanitized version for log monitoring.- log(f"[CAPTCHA_CHECKPOINT] live_view_url={live_url}")- log(f"[CAPTCHA_CHECKPOINT] Sanitized: {sanitize_url(live_url)}")+ log(f"[CAPTCHA_CHECKPOINT] Live view: {sanitize_url(live_url)}")log(f"[CAPTCHA_CHECKPOINT] Provider: {provider}, Email: {safe}")log("[CAPTCHA_CHECKPOINT] Browser session kept alive — do NOT stop")log(f"[CAPTCHA_CHECKPOINT] To resume after solving: touch {CHECKPOINT_TRIGGER}")@@ -1061,13 +1080,13 @@ def handle_captcha_checkpoint(client: BrowserUseClient, run_id: str,# --- 6. Create follow-up run in the same session ---intercept_js = INTERCEPT_JS_TEMPLATE.format(port=port)task_resume = (- f"The captcha has been solved by a human. "+ f"The captcha has been solved by a human. Navigate to {oauth_url}. "f"Run this JavaScript in the browser console: {intercept_js} "- f"Then if you see an Authorize or Allow button, click it. "- f"Wait 3 seconds. "- f"Then run window.__CB__ in the console and report its value. "- f"If null, report the current URL. "- f"If you see another captcha, report CAPTCHA."+ "Then if you see an Authorize or Allow button, click it. "+ "Wait 3 seconds. "+ "Then run window.__CB__ in the console and report its value. "+ "If null, report the current URL. "+ "If you see another captcha, report CAPTCHA.")run_resume = client.create_run(task_resume, session_id=session_id)run_resume_id = run_resume.get("id", "")@@ -1199,8 +1218,7 @@ def run_reauth(provider: str, email: str, gog_account: str,Returns exit code: 0=success, 1=failure, 2=captcha."""meta = PROVIDERS[provider]- port = meta["callback_port"]- log_path = Path("/tmp/bu_reauth_hub.log")+ log_path = LOG_DIR / "bu_reauth_hub.log"log_path.unlink(missing_ok=True)# --- Step 1: Acquire serialization lease ---@@ -1250,7 +1268,7 @@ def _run_reauth_inner(provider: str, email: str, gog_account: str,except Exception as e:log(f"[1] Stale auth backup warning: {e}")else:- log(f"[1] No existing auth file — no stale backup needed")+ log("[1] No existing auth file — no stale backup needed")# --- Step 2: Start cli-proxy-api login ---log(f"[1] Starting cli-proxy-api login for {provider} ({safe})")@@ -1270,8 +1288,8 @@ def _run_reauth_inner(provider: str, email: str, gog_account: str,task1 = (f"Go to {oauth_url}. "f"Enter {email} in the email field. "- f"Click Continue. Do NOT use Google sign-in. "- f"Report exactly what you see after clicking Continue."+ "Click Continue. Do NOT use Google sign-in. "+ "Report exactly what you see after clicking Continue.")run1 = client.create_run(task1)run1_id = run1.get("id", "")@@ -1289,7 +1307,7 @@ def _run_reauth_inner(provider: str, email: str, gog_account: str,if callback_url:return _complete_reauth(proc, callback_url, auth_file,stale_backup, email, provider, meta)- return EXIT_FAILURE+ return EXIT_CAPTCHA# --- Step 5: Handle verification code or magic link ---needs_code = any(kw in text1.lower() for kw in@@ -1315,8 +1333,8 @@ def _run_reauth_inner(provider: str, email: str, gog_account: str,text2 = ""for attempt in range(max_code_retries):task2 = (- f"Enter the verification code in the verification field. "- f"Click Continue. Report what you see."+ "Enter the verification code in the verification field. "+ "Click Continue. Report what you see.")run2 = client.create_run(task2, session_id=session_id)run2_id = run2.get("id", "")@@ -1337,7 +1355,7 @@ def _run_reauth_inner(provider: str, email: str, gog_account: str,return _complete_reauth(proc, callback_url,auth_file, stale_backup,email, provider, meta)- return EXIT_FAILURE+ return EXIT_CAPTCHA# Check if code entry failedif _code_entry_failed(text2):@@ -1372,9 +1390,9 @@ def _run_reauth_inner(provider: str, email: str, gog_account: str,if magic:log("[5] Magic link received (value redacted)")task3 = (- f"Navigate to the magic link URL. "- f"If you see an Authorize button, click it. "- f"Report what you see."+ "Navigate to the magic link URL. "+ "If you see an Authorize button, click it. "+ "Report what you see.")run3 = client.create_run(task3, session_id=session_id)run3_id = run3.get("id", "")@@ -1394,9 +1412,9 @@ def _run_reauth_inner(provider: str, email: str, gog_account: str,if magic:log("[4] Magic link received (value redacted)")task2 = (- f"Navigate to the magic link URL. "- f"If you see an Authorize button, click it. "- f"Report what you see."+ "Navigate to the magic link URL. "+ "If you see an Authorize button, click it. "+ "Report what you see.")run2 = client.create_run(task2, session_id=session_id)run2_id = run2.get("id", "")@@ -1414,10 +1432,10 @@ def _run_reauth_inner(provider: str, email: str, gog_account: str,log(f"[6] Injecting JS callback interception (port {port}) and clicking Authorize")task_auth = (f"Run this JavaScript in the browser console: {intercept_js} "- f"Then if you see an Authorize or Allow button, click it. "- f"Wait 3 seconds. "- f"Then run window.__CB__ in the console and report its value. "- f"If null, report the current URL."+ "Then if you see an Authorize or Allow button, click it. "+ "Wait 3 seconds. "+ "Then run window.__CB__ in the console and report its value. "+ "If null, report the current URL.")run_auth = client.create_run(task_auth, session_id=session_id)run_auth_id = run_auth.get("id", "")@@ -1434,7 +1452,7 @@ def _run_reauth_inner(provider: str, email: str, gog_account: str,if callback_url:return _complete_reauth(proc, callback_url, auth_file,stale_backup, email, provider, meta)- return EXIT_FAILURE+ return EXIT_CAPTCHA# --- Step 7: Extract callback URL ---log("[7] Searching for callback URL...")@@ -1491,7 +1509,7 @@ def _timeout_handler(signum, frame):def _checkpoint_resume(args) -> int:"""Resume from a hCaptcha checkpoint file.- Reads /tmp/bu_reauth_checkpoint.json for the session_id, provider,+ Reads /opt/crsproxy/state/bu_reauth_checkpoint.json for the session_id, provider,email, and callback_port. Starts a new cli-proxy-api login process(the original one is likely dead), creates a follow-up run in thesame Browser Use session to click Authorize, extracts the callback@@ -1548,7 +1566,7 @@ def _checkpoint_resume(args) -> int:return EXIT_FAILURE# Start a new login process (the original is likely dead)- log_path = Path("/tmp/bu_reauth_hub.log")+ log_path = LOG_DIR / "bu_reauth_hub.log"log("[1] Starting new cli-proxy-api login for checkpoint resume")proc = start_login(provider, log_path)@@ -1577,13 +1595,13 @@ def _checkpoint_resume(args) -> int:intercept_js = INTERCEPT_JS_TEMPLATE.format(port=port)log("[3] Creating follow-up run in same session")task_resume = (- f"The captcha has been solved by a human. "+ f"The captcha has been solved by a human. Navigate to {oauth_url}. "f"Run this JavaScript in the browser console: {intercept_js} "- f"Then if you see an Authorize or Allow button, click it. "- f"Wait 3 seconds. "- f"Then run window.__CB__ in the console and report its value. "- f"If null, report the current URL. "- f"If you see another captcha, report CAPTCHA."+ "Then if you see an Authorize or Allow button, click it. "+ "Wait 3 seconds. "+ "Then run window.__CB__ in the console and report its value. "+ "If null, report the current URL. "+ "If you see another captcha, report CAPTCHA.")run_resume = client.create_run(task_resume, session_id=session_id)run_resume_id = run_resume.get("id", "")@@ -1596,7 +1614,7 @@ def _checkpoint_resume(args) -> int:if detect_captcha(result_resume, client):log("[FAIL] Captcha still present — cannot complete")- return EXIT_FAILURE+ return EXIT_CAPTCHAcallback_url = extract_callback_url(result_resume, client, provider)@@ -1664,16 +1682,28 @@ def main():parser.add_argument("-checkpoint-resume", action="store_true",help="Resume from a checkpoint file written by a ""previous run that detected hCaptcha. Reads "- "/tmp/bu_reauth_checkpoint.json for the "+ "/opt/crsproxy/state/bu_reauth_checkpoint.json for the ""session_id, then creates a follow-up run to ""click Authorize and complete the flow.")parser.add_argument("-log-file", default="",- help="Log file path (default: /tmp/bu_reauth.log)")+ help="Log file path (default: /opt/crsproxy/state/bu_reauth.log)")args = parser.parse_args()+ _ensure_state_dir()+# Set up log filelog_path = args.log_file or str(LOG_DIR / "bu_reauth.log")_log_file = open(log_path, "a", encoding="utf-8")+ atexit.register(_log_file.close)++ # Override checkpoint timeout if specified+ if args.checkpoint_timeout > 0:+ global CHECKPOINT_TIMEOUT+ CHECKPOINT_TIMEOUT = args.checkpoint_timeout++ # Set overall timeout before all execution modes.+ signal.signal(signal.SIGALRM, _timeout_handler)+ signal.alarm(TOTAL_TIMEOUT)# --- Validate-only mode: standalone candidate validation ---if args.validate_only:@@ -1713,15 +1743,6 @@ def main():if args.checkpoint_resume:return _checkpoint_resume(args)- # Set overall timeout- signal.signal(signal.SIGALRM, _timeout_handler)- signal.alarm(TOTAL_TIMEOUT)-- # Override checkpoint timeout if specified- if args.checkpoint_timeout > 0:- global CHECKPOINT_TIMEOUT- CHECKPOINT_TIMEOUT = args.checkpoint_timeout-# Load API key from environmentapi_key = os.environ.get("BROWSER_USE_API_KEY", "")if not api_key:diff --git a/claude-ops/scripts/crsproxy-reauth/sync-env.sh b/claude-ops/scripts/crsproxy-reauth/sync-env.shindex 43234407..6bf49b19 100755--- a/claude-ops/scripts/crsproxy-reauth/sync-env.sh+++ b/claude-ops/scripts/crsproxy-reauth/sync-env.sh@@ -10,13 +10,18 @@# Requirements:# - Doppler CLI installed on hub (/usr/bin/doppler)# - Service token stored at /opt/crsproxy/.doppler-token-# - crsproxy user must have read access to /opt/crsproxy/+# - crsproxy user must have write and execute access to /opt/crsproxy/## This script is the canonical way to keep /opt/crsproxy/.env in sync with# Doppler. No manual .env editing is needed — update the secret in Doppler# (or Dashlane → Doppler) and re-run this script.set -euo pipefail+MOBILE=0+if [[ -n "${SSH_CONNECTION:-}${SSH_CLIENT:-}${SSH_TTY:-}" || "${OPS_MOBILE:-0}" == "1" || ( "${COLUMNS:-80}" =~ ^[0-9]+$ && "${COLUMNS:-80}" -lt 80 ) ]]; then+ MOBILE=1+fi+cd /opt/crsproxyTOKEN_FILE="/opt/crsproxy/.doppler-token"@@ -28,15 +33,35 @@ if [ ! -f "$TOKEN_FILE" ]; thenecho "ERROR: Token file $TOKEN_FILE not found" >&2exit 1fi--export DOPPLER_TOKEN="$(cat "$TOKEN_FILE")"+if [ ! -r "$TOKEN_FILE" ] || [ ! -s "$TOKEN_FILE" ]; then+ echo "ERROR: Token file $TOKEN_FILE must be readable and non-empty" >&2+ exit 1+fi+if ! DOPPLER_TOKEN="$(<"$TOKEN_FILE")" || [ -z "$DOPPLER_TOKEN" ]; then+ echo "ERROR: Could not read a non-empty token from $TOKEN_FILE" >&2+ exit 1+fi+export DOPPLER_TOKEN# Download secrets in env format and write to a temp fileTMP_FILE=$(mktemp /opt/crsproxy/.env.XXXXXX)+cleanup() {+ [ -n "${TMP_FILE:-}" ] && rm -f -- "$TMP_FILE"+}+trap cleanup EXIT+trap 'exit 129' HUP+trap 'exit 130' INT+trap 'exit 143' TERMdoppler secrets download --project "$PROJECT" --config "$CONFIG" --format env --no-file > "$TMP_FILE"# Atomic move (temp file + rename)chmod 600 "$TMP_FILE"mv "$TMP_FILE" "$ENV_FILE"+TMP_FILE=""-echo "Synced $ENV_FILE from Doppler $PROJECT/$CONFIG ($(grep -c "=" "$ENV_FILE") keys)"+key_count=$(grep -c "=" "$ENV_FILE")+if [ "$MOBILE" -eq 1 ]; then+ echo "env synced: ${key_count} keys"+else+ echo "Synced $ENV_FILE from Doppler $PROJECT/$CONFIG (${key_count} keys)"+fidiff --git a/claude-ops/scripts/crsproxy-reauth/test_checkpoint.py b/claude-ops/scripts/crsproxy-reauth/test_checkpoint.pyindex 3fc1d1d8..c5f0f7fa 100644--- a/claude-ops/scripts/crsproxy-reauth/test_checkpoint.py+++ b/claude-ops/scripts/crsproxy-reauth/test_checkpoint.py@@ -14,7 +14,6 @@ Run locally (syntax/logic only, no hub dependencies):"""import json-import osimport sysimport tempfileimport time@@ -79,94 +78,73 @@ def test_detect_captcha_negative():def test_checkpoint_file_write_read():"""write_checkpoint writes a valid JSON file."""- orig_ckpt = bu_reauth.CHECKPOINT_FILEwith tempfile.TemporaryDirectory() as tmpdir:- # Override checkpoint file pathckpt_path = Path(tmpdir) / "checkpoint.json"- bu_reauth.CHECKPOINT_FILE = ckpt_path-- bu_reauth.write_checkpoint(- session_id="test-session-123",- run_id="test-run-456",- browser_session_id="test-browser-789",- live_view_url="https://live.browser-use.com?wss=example",- provider="claude",- email="[email protected]",- callback_port=54545,- )-- assert ckpt_path.exists(), "Checkpoint file was not created"- data = json.loads(ckpt_path.read_text())- assert data["session_id"] == "test-session-123"- assert data["run_id"] == "test-run-456"- assert data["provider"] == "claude"- assert data["email"] == "[email protected]"- assert data["callback_port"] == 54545- assert data["live_view_url"] == "https://live.browser-use.com?wss=example"- assert data["status"] == "waiting"- print("PASS: write_checkpoint writes valid JSON with all fields")- bu_reauth.CHECKPOINT_FILE = orig_ckpt+ with patch.object(bu_reauth, "CHECKPOINT_FILE", ckpt_path):+ bu_reauth.write_checkpoint(+ session_id="test-session-123",+ run_id="test-run-456",+ browser_session_id="test-browser-789",+ live_view_url="https://live.browser-use.com?wss=example",+ provider="claude",+ email="[email protected]",+ callback_port=54545,+ )+ assert ckpt_path.exists(), "Checkpoint file was not created"+ data = json.loads(ckpt_path.read_text())+ assert data["session_id"] == "test-session-123"+ assert data["run_id"] == "test-run-456"+ assert data["provider"] == "claude"+ assert data["email"] == "[email protected]"+ assert data["callback_port"] == 54545+ assert data["live_view_url"] == "https://live.browser-use.com?wss=example"+ assert data["status"] == "waiting"+ assert ckpt_path.stat().st_mode & 0o777 == 0o600+ print("PASS: write_checkpoint writes valid JSON with all fields")def test_checkpoint_trigger():"""wait_for_checkpoint_signal detects trigger file."""- orig_trigger = bu_reauth.CHECKPOINT_TRIGGERwith tempfile.TemporaryDirectory() as tmpdir:trigger_path = Path(tmpdir) / "trigger"- bu_reauth.CHECKPOINT_TRIGGER = trigger_path+ with patch.object(bu_reauth, "CHECKPOINT_TRIGGER", trigger_path):+ def create_trigger():+ time.sleep(1)+ trigger_path.touch()- # Create trigger file after a short delay- def create_trigger():- time.sleep(1)- trigger_path.touch()-- import threading- t = threading.Thread(target=create_trigger)- t.start()-- result = bu_reauth.wait_for_checkpoint_signal(timeout=10)- t.join()-- assert result is True, "Expected trigger to be detected"- assert not trigger_path.exists(), "Trigger file should be cleaned up"- print("PASS: wait_for_checkpoint_signal detects and cleans up trigger")- bu_reauth.CHECKPOINT_TRIGGER = orig_trigger+ import threading+ thread = threading.Thread(target=create_trigger)+ thread.start()+ result = bu_reauth.wait_for_checkpoint_signal(timeout=10)+ thread.join()+ assert result is True, "Expected trigger to be detected"+ assert not trigger_path.exists(), "Trigger file should be cleaned up"+ print("PASS: wait_for_checkpoint_signal detects and cleans up trigger")def test_checkpoint_timeout():"""wait_for_checkpoint_signal returns False on timeout."""- orig_trigger = bu_reauth.CHECKPOINT_TRIGGERwith tempfile.TemporaryDirectory() as tmpdir:trigger_path = Path(tmpdir) / "trigger"- bu_reauth.CHECKPOINT_TRIGGER = trigger_path-- result = bu_reauth.wait_for_checkpoint_signal(timeout=2)- assert result is False, "Expected False on timeout"- print("PASS: wait_for_checkpoint_signal returns False on timeout")- bu_reauth.CHECKPOINT_TRIGGER = orig_trigger+ with patch.object(bu_reauth, "CHECKPOINT_TRIGGER", trigger_path):+ result = bu_reauth.wait_for_checkpoint_signal(timeout=2)+ assert result is False, "Expected False on timeout"+ print("PASS: wait_for_checkpoint_signal returns False on timeout")def test_clear_checkpoint():"""clear_checkpoint removes both checkpoint and trigger files."""- orig_ckpt = bu_reauth.CHECKPOINT_FILE- orig_trigger = bu_reauth.CHECKPOINT_TRIGGERwith tempfile.TemporaryDirectory() as tmpdir:ckpt_path = Path(tmpdir) / "checkpoint.json"trigger_path = Path(tmpdir) / "trigger"- bu_reauth.CHECKPOINT_FILE = ckpt_path- bu_reauth.CHECKPOINT_TRIGGER = trigger_path-- ckpt_path.write_text("{}")- trigger_path.touch()-- bu_reauth.clear_checkpoint()-- assert not ckpt_path.exists(), "Checkpoint file should be removed"- assert not trigger_path.exists(), "Trigger file should be removed"- print("PASS: clear_checkpoint removes both files")- bu_reauth.CHECKPOINT_FILE = orig_ckpt- bu_reauth.CHECKPOINT_TRIGGER = orig_trigger-+ with patch.object(bu_reauth, "CHECKPOINT_FILE", ckpt_path), \+ patch.object(bu_reauth, "CHECKPOINT_TRIGGER", trigger_path):+ ckpt_path.write_text("{}")+ trigger_path.touch()+ bu_reauth.clear_checkpoint()+ assert not ckpt_path.exists(), "Checkpoint file should be removed"+ assert not trigger_path.exists(), "Trigger file should be removed"+ print("PASS: clear_checkpoint removes both files")def test_keep_browser_alive_flag():"""BrowserUseClient.keep_browser_alive prevents browser cleanup."""@@ -196,6 +174,8 @@ def test_keep_browser_alive_release():with patch.object(client, '_request'):client.stop_all_browsers()+ assert client._browser_sessions == [], \+ "Browser sessions should be released when keep_browser_alive=False"print("PASS: keep_browser_alive can be released for cleanup")@@ -209,8 +189,8 @@ def test_exit_codes():def test_checkpoint_constants():"""Checkpoint constants are properly defined."""- assert bu_reauth.CHECKPOINT_FILE == Path("/tmp/bu_reauth_checkpoint.json")- assert bu_reauth.CHECKPOINT_TRIGGER == Path("/tmp/bu_reauth_checkpoint_trigger")+ assert bu_reauth.CHECKPOINT_FILE == bu_reauth.STATE_DIR / "bu_reauth_checkpoint.json"+ assert bu_reauth.CHECKPOINT_TRIGGER == bu_reauth.STATE_DIR / "bu_reauth_checkpoint_trigger"assert bu_reauth.CHECKPOINT_POLL_INTERVAL == 5assert bu_reauth.CHECKPOINT_TIMEOUT == 600print("PASS: Checkpoint constants are properly defined")diff --git a/claude-ops/scripts/crsproxy-reauth/test_lease_cooldown.py b/claude-ops/scripts/crsproxy-reauth/test_lease_cooldown.pyindex f9274dd1..c03f33e3 100644--- a/claude-ops/scripts/crsproxy-reauth/test_lease_cooldown.py+++ b/claude-ops/scripts/crsproxy-reauth/test_lease_cooldown.py@@ -20,7 +20,7 @@ import sysimport tempfileimport timefrom pathlib import Path-from unittest.mock import MagicMock, patch+from unittest.mock import patch# Add the script directory to the pathsys.path.insert(0, str(Path(__file__).parent))@@ -31,10 +31,8 @@ import bu_reauthdef test_lease_file_constant():"""Lease file path is correct."""- assert bu_reauth.LEASE_FILE == Path(- "/tmp/crsproxy-claude-oauth-lease.json"- ), f"Expected /tmp/crsproxy-claude-oauth-lease.json, got {bu_reauth.LEASE_FILE}"- print("PASS: Lease file path is /tmp/crsproxy-claude-oauth-lease.json")+ assert bu_reauth.LEASE_FILE == bu_reauth.STATE_DIR / "crsproxy-claude-oauth-lease.json"+ print("PASS: Lease file path is in the private state directory")def test_lease_stale_seconds():@@ -171,6 +169,7 @@ def test_release_lease_missing_ok():# No lease file exists — should not raisebu_reauth.release_lease()print("PASS: release_lease handles missing lease gracefully")+ bu_reauth.LEASE_FILE = orig_leasedef test_release_lease_always_called():@@ -189,9 +188,7 @@ def test_release_lease_always_called():# ---------------------------------------------------------------------------def test_email_cooldown_constants():"""Email cooldown constants are correct."""- assert bu_reauth.EMAIL_COOLDOWN_FILE == Path(- "/tmp/crsproxy-email-cooldown.json"- )+ assert bu_reauth.EMAIL_COOLDOWN_FILE == bu_reauth.STATE_DIR / "crsproxy-email-cooldown.json"assert bu_reauth.EMAIL_COOLDOWN_WINDOW == 300assert bu_reauth.EMAIL_COOLDOWN_THRESHOLD == 3assert bu_reauth.EMAIL_COOLDOWN_DURATION == 300