Claude Code. Any Model. The most powerful AI coding agent now speaks every language.
fix(probe): show the signer of a live muse@ request over a sibling rejection
Jack Rudenko2735ac1f4e0c
diff --git a/packages/cli/src/providers/meta-muse/muse-credentials.ts b/packages/cli/src/providers/meta-muse/muse-credentials.tsindex 5778ef26..c1d0d74d 100644--- a/packages/cli/src/providers/meta-muse/muse-credentials.ts+++ b/packages/cli/src/providers/meta-muse/muse-credentials.ts@@ -488,7 +488,8 @@ function displayPath(path: string): string {* visible). Read AFTER the probe request, and in this order:** 1. A probe that ran and was refused because every login file was rejected- * by Meta: `Muse Code login rejected`, with the rejection message.+ * by Meta: `Muse Code login rejected`, with the rejection message. Never+ * over a request of this probe that signed and went live.* 2. `signedWith` — the signer THIS probe request's response named* (`x-claudish-signed-with`). Per request, so concurrent probes in one* process cannot borrow each other's answer. Named on a failed answer too@@ -509,7 +510,11 @@ export function describeMuseSigningSource(): MuseSigningDescription {// Rejected first: a request signed with a key whose re-mint then found every// login rejected also names its signer, but the login is what is wrong now.- if (opts.probed && lastRejection) {+ // Not over a request that signed and went live: `lastRejection` is process+ // wide, so it may be a concurrent sibling probe's re-mint, and this request's+ // own answer proves its login worked.+ const signedAndLive = opts.signedWith !== undefined && opts.failure === undefined;+ if (opts.probed && lastRejection && !signedAndLive) {return { present: false, label: "Muse Code login rejected", detail: lastRejection };}if (opts.signedWith) {diff --git a/packages/cli/src/providers/meta-muse/muse-reporting.test.ts b/packages/cli/src/providers/meta-muse/muse-reporting.test.tsindex 6ae8dfd2..faa372cc 100644--- a/packages/cli/src/providers/meta-muse/muse-reporting.test.ts+++ b/packages/cli/src/providers/meta-muse/muse-reporting.test.ts@@ -698,6 +698,15 @@ describe("revision 3: winner Key line and signed failures", () => {);});+ test("rejected login 401 remains visible without a signer or failure", async () => {+ store.writeMuseStore("own-login", { access_token: OWN }, dir);+ mintStatus = 401;+ await expect(sign()).rejects.toThrow(rejectedMessage(401));+ const result = description({ probed: true });+ expect(await keyLine(result)).toBe(`Muse Code login rejected (${rejectedMessage(401)})`);+ expect(keychainUses).toBe(0);+ });+test("no provenance has no Key text", async () => {const { keyLineText } = await import("../../probe/probe-chain.js");expect(keyLineText(undefined)).toBeUndefined();@@ -716,6 +725,20 @@ describe("revision 3: winner Key line and signed failures", () => {}for (const status of [401, 403]) {+ test(`signed-and-live probe takes precedence over rejected login ${status}`, async () => {+ store.writeMuseStore("own-login", { access_token: OWN }, dir);+ mintStatus = status;+ await expect(sign()).rejects.toThrow(rejectedMessage(status));+ const label = "Muse Code borrowed copy · Muse Code Power Usage";+ const result = description({ signedWith: label, probed: true });+ expect(result.present).toBe(true);+ expect(result.label).toBe(label);+ expect(result.detail).toBe("signed this probe request");+ expect(await keyLine(result)).toBe(+ "Muse Code borrowed copy · Muse Code Power Usage (signed this probe request)"+ );+ expect(keychainUses).toBe(0);+ });test(`rejected login ${status} takes precedence over a supplied signer and failure`, async () => {store.writeMuseStore("own-login", { access_token: OWN }, dir);mintStatus = status;