Claude Code. Any Model. The most powerful AI coding agent now speaks every language.
fix(mcp): refuse a non-boolean include_completed or spans argument
Jack Rudenko3fe6bc2c4db2
diff --git a/packages/cli/src/mcp-contract.e2e.test.ts b/packages/cli/src/mcp-contract.e2e.test.tsindex adee37c2..8da20940 100644--- a/packages/cli/src/mcp-contract.e2e.test.ts+++ b/packages/cli/src/mcp-contract.e2e.test.ts@@ -350,6 +350,11 @@ describe.skipIf(!MAGMUX_AVAILABLE)("every §8 verb answers its errors as a Contrawait server.callTool("capture_session", { session_id: "deadbeef", since_seq: "x" }),"invalid_args");+ // a non-boolean spans is refused before the session lookup, like a string since_seq+ contractError(+ await server.callTool("capture_session", { session_id: "deadbeef", spans: "yes" }),+ "invalid_args"+ );contractError(await server.callTool("capture_session", {}), "invalid_args");contractError(await server.callTool("cancel_session", {}), "invalid_args");// a refused create_session argument is the caller's error: no provider_failure hintdiff --git a/packages/cli/src/mcp-server.ts b/packages/cli/src/mcp-server.tsindex 0aa8951f..302633c0 100644--- a/packages/cli/src/mcp-server.ts+++ b/packages/cli/src/mcp-server.ts@@ -2182,9 +2182,10 @@ function defineTools(group: "channel",handler: async (args) => {try {+ const includeCompleted = optionalBoolean(args.include_completed, "include_completed");return contractAnswer({...contractMeta(),- sessions: sessionManager.listSessionRows(args.include_completed === true),+ sessions: sessionManager.listSessionRows(includeCompleted),});} catch (e) {return contractErrorAnswer(e);@@ -2279,12 +2280,9 @@ function defineTools(const sessionId = optionalString(args.session_id, "session_id");if (sessionId === undefined)throw new ContractErrorException("invalid_args", "'session_id' is required");- const since = args.since_seq;- if (since !== undefined && (typeof since !== "number" || !Number.isInteger(since)))- throw new ContractErrorException("invalid_args", "'since_seq' must be an integer");- return contractAnswer(- sessionManager.captureSession(sessionId, since as number | undefined, args.spans === true)- );+ const since = optionalInteger(args.since_seq, "since_seq");+ const spans = optionalBoolean(args.spans, "spans");+ return contractAnswer(sessionManager.captureSession(sessionId, since, spans));} catch (e) {return contractErrorAnswer(e);}