Claude Code. Any Model. The most powerful AI coding agent now speaks every language.
fix(tui): name the credential in the provider Test success line
Jack Rudenko6965ff333254
diff --git a/packages/cli/src/tui/components/ProviderDetail.test.ts b/packages/cli/src/tui/components/ProviderDetail.test.tsindex 37748c82..fe851ffe 100644--- a/packages/cli/src/tui/components/ProviderDetail.test.ts+++ b/packages/cli/src/tui/components/ProviderDetail.test.ts@@ -1,5 +1,9 @@import { describe, expect, test } from "bun:test";-import { credentialNoteLines, resolveProviderDetailKeyDisplay } from "./ProviderDetail.js";+import {+ credentialNoteLines,+ resolveProviderDetailKeyDisplay,+ validTestNote,+} from "./ProviderDetail.js";describe("resolveProviderDetailKeyDisplay", () => {test("shows OAuth as the active credential instead of an empty key", () => {@@ -31,6 +35,29 @@ describe("resolveProviderDetailKeyDisplay", () => {});});+// REGRESSION: Login-authenticated providers reported an API key after a successful Test — /dev:fix session dev-fix-20261020-235500-vtx01+describe("validTestNote", () => {+ test("keeps the API key success sentence for a keyed provider", () => {+ expect(validTestNote({ isLocal: false, credential: "key" })).toBe(+ " API key is valid and endpoint is reachable."+ );+ });++ test("names the login for an OAuth or ADC provider", () => {+ expect(validTestNote({ isLocal: false, credential: "login" })).toBe(+ " Login is valid and endpoint is reachable."+ );+ });++ test("keeps the local success sentence regardless of credential", () => {+ for (const credential of ["key", "login"] as const) {+ expect(validTestNote({ isLocal: true, credential })).toBe(+ " Local provider responded through the shared probe path."+ );+ }+ });+});+// REGRESSION: Vertex Auth note overflowed DETAIL_H and painted over the Status row — /dev:fix session dev-fix-20261020-235500-vtx01describe("credentialNoteLines", () => {const note =diff --git a/packages/cli/src/tui/components/ProviderDetail.tsx b/packages/cli/src/tui/components/ProviderDetail.tsxindex 55cefe07..59def241 100644--- a/packages/cli/src/tui/components/ProviderDetail.tsx+++ b/packages/cli/src/tui/components/ProviderDetail.tsx@@ -107,6 +107,13 @@ export function resolveProviderDetailKeyDisplay(input: {return "────────";}+export function validTestNote(input: { isLocal: boolean; credential: "key" | "login" }): string {+ if (input.isLocal) return " Local provider responded through the shared probe path.";+ return input.credential === "login"+ ? " Login is valid and endpoint is reachable."+ : " API key is valid and endpoint is reachable.";+}+export function ProviderDetail({selectedProvider,mode,@@ -409,9 +416,11 @@ export function ProviderDetail({</span>{tr.ms !== undefined && <span fg={C.dim}>{` ${tr.ms}ms`}</span>}<span fg={C.fgMuted}>- {selectedProvider.isLocal- ? " Local provider responded through the shared probe path."- : " API key is valid and endpoint is reachable."}+ {validTestNote({+ isLocal: !!selectedProvider.isLocal,+ credential:+ isOAuth || selectedProvider.catalogName === "vertex" ? "login" : "key",+ })}</span></>)}