Skip to content

Claude Code. Any Model. The most powerful AI coding agent now speaks every language.

fix(team): refuse an invalid require_pattern before writing the session

Jack Rudenkodd5abb70a0b4
diff --git a/packages/cli/src/mcp-server.ts b/packages/cli/src/mcp-server.ts
index b482a912..43e3bcdb 100644
--- a/packages/cli/src/mcp-server.ts
+++ b/packages/cli/src/mcp-server.ts
@@ -1632,6 +1632,7 @@ function defineTools(
slots: models.length,
claudeFlags: childFlags,
input: promptText(),
+ requirePattern,
});
setupSession(resolved, models, input);
@@ -1726,6 +1727,7 @@ function defineTools(
slots: models.length,
claudeFlags: childFlags,
input: promptText(),
+ requirePattern,
});
setupSession(resolved, models, input);
const handle = await startModels(resolved, runOpts);
diff --git a/packages/cli/src/team-list-contract.test.ts b/packages/cli/src/team-list-contract.test.ts
index 70a5499c..cd0c81da 100644
--- a/packages/cli/src/team-list-contract.test.ts
+++ b/packages/cli/src/team-list-contract.test.ts
@@ -10,7 +10,7 @@
*/
import { afterEach, beforeEach, describe, expect, it } from "bun:test";
-import { mkdirSync, mkdtempSync, rmSync } from "node:fs";
+import { existsSync, mkdirSync, mkdtempSync, rmSync } from "node:fs";
import { join } from "node:path";
import { teamContractVerb, teamStatusAnswer } from "./mcp-server.js";
import { CAPABILITIES, type CaptureResult, type TeamRunRow } from "./pane/index.js";
@@ -165,6 +165,14 @@ describe.skipIf(!MAGMUX)("team run registry (list / status / cancel / capture)",
await expect(startModels(path, paneRunOptions(t))).rejects.toThrow(message);
}, 60_000);
+ it("refuses an invalid require_pattern in preflight, before any session dir or record", async () => {
+ const path = join(base, "bad-pattern");
+ await expect(preflightTeamRun({ path, slots: 1, requirePattern: "(" })).rejects.toThrow(
+ /^invalid_args: Invalid requirePattern \/\(\//
+ );
+ expect(existsSync(path)).toBe(false);
+ });
+
it("answers unknown runs and slots with ContractError JSON", async () => {
const path = join(base, "nothing-here");
const unknownStatus = json(await teamContractVerb("status", { path }));
diff --git a/packages/cli/src/team-orchestrator.ts b/packages/cli/src/team-orchestrator.ts
index 9df8277e..4df0eff2 100644
--- a/packages/cli/src/team-orchestrator.ts
+++ b/packages/cli/src/team-orchestrator.ts
@@ -1083,8 +1083,15 @@ export async function preflightTeamRun(opts: {
slots: number;
claudeFlags?: string[];
input?: string;
+ requirePattern?: string;
parentEnv?: Record<string, string | undefined>;
}): Promise<void> {
+ // before setupSession and the run record, so a refused run leaves no record (§4.1)
+ try {
+ assertValidRequirePattern(opts.requirePattern);
+ } catch (err) {
+ throw new Error(`invalid_args: ${err instanceof Error ? err.message : String(err)}`);
+ }
const flags = opts.claudeFlags ?? [];
const check = checkChildFlags(flags);
if (!check.ok) throw new Error(`invalid_args: ${check.message}`);