Debloat any Android or Google TV over Wi-Fi and get an Apple TV-style home.
Python adbadblockandroid-tvandroid-tv-launcherapple-tvbloatware-removalclaude-codedebloatfire-tvgoogle-tvlauncherprivacysmart-tvsony-braviatclvibe-codingxiaomi
tools: privacy.py answers a run that never got as far as the TV with 2
xbsheng696f0d64cb71
diff --git a/tests/test_privacy_unreached_tv.py b/tests/test_privacy_unreached_tv.pynew file mode 100644index 000000000..fbb46fa27--- /dev/null+++ b/tests/test_privacy_unreached_tv.py@@ -0,0 +1,141 @@+"""tools/privacy.py answers a run that never got as far as the TV with 2, and says nothing was asked.++The docstring gives 1 to a run that reached the TV and then failed and 2 to one that never got as far+as the TV, and check.py (#2405), b64push.py (#2426), manage.py (#2692), trace.py (#2683),+theme_restart.py (#2763) and recovery.py (#2767) all answer an import-time refusal from tools/tv.py+with 2 and a line saying what they did not do. privacy.py's connect() caught only ImportError, so the+two refusals tv.py makes while it is being imported - no TV_HOST ("Set TV_HOST to your TV's IP+address ...") and a TV_PORT that is not a port number ("not a port number: 'abc'") - came out of+`import tv` as a SystemExit the interpreter answered with exit 1, the status this file keeps for an+audit that ran and then failed. An owner whose wrapper reads the status, or whose shell stops on it,+was told the audit had reached the TV when no connection was ever opened and nothing was sent.++Reproduced on main (57c00a40): `env -u TV_HOST tools/venv/bin/python -I tools/privacy.py` printed the+two Set TV_HOST lines and exited 1, and `TV_HOST=192.168.1.50 TV_PORT=abc ...` printed "not a port+number: 'abc'" and exited 1. Both exit 2 with tv.py's own text, a "Nothing was asked of the TV." line+and an empty stdout now, and a `--write` target is still not created.++The last test is the branch that was already right: a checkout with no tools/tv.py at all still says+it could not load it, with 2.++Run from the repository root: python3 -m unittest discover -s tests -v+"""+import os+from pathlib import Path+import shutil+import subprocess+import sys+import tempfile+import unittest++ROOT = Path(__file__).resolve().parents[1]++NOTHING_ASKED = "Nothing was asked of the TV."+SET_HOST = "Set TV_HOST to your TV's IP address"+BAD_PORT = "not a port number: 'abc'"+CANNOT_LOAD = "cannot load tools/tv.py"+++class PrivacyNeedsHostTest(unittest.TestCase):+ """The checkout's own tools/tv.py: the two refusals it makes while it is being imported."""++ def setUp(self):+ tmp = tempfile.TemporaryDirectory()+ self.addCleanup(tmp.cleanup)+ self.base = Path(tmp.name)+ self.repo = self.base / "repo"+ (self.repo / "tools").mkdir(parents=True)+ shutil.copy2(ROOT / "tools" / "privacy.py", self.repo / "tools" / "privacy.py")+ shutil.copy2(ROOT / "tools" / "tv.py", self.repo / "tools" / "tv.py")+ self.script = self.repo / "tools" / "privacy.py"++ def run_privacy(self, *args, **env_overrides):+ env = {k: v for k, v in os.environ.items() if k not in ("TV_HOST", "TV_PORT")}+ env.update(env_overrides)+ return subprocess.run([sys.executable, str(self.script), *args], cwd=self.repo, env=env,+ capture_output=True, text=True, stdin=subprocess.DEVNULL, timeout=120)++ def test_no_tv_host_is_2_with_tv_pys_own_line(self):+ result = self.run_privacy()+ self.assertEqual(result.returncode, 2, result.stderr)+ self.assertIn(SET_HOST, result.stderr)+ self.assertIn(NOTHING_ASKED, result.stderr)+ self.assertEqual(result.stdout, "")+ self.assertNotIn("Traceback", result.stderr)++ def test_a_write_target_is_not_created_when_no_host_was_given(self):+ result = self.run_privacy("--write", "privacy.txt")+ self.assertEqual(result.returncode, 2, result.stderr)+ self.assertIn(SET_HOST, result.stderr)+ self.assertIn(NOTHING_ASKED, result.stderr)+ self.assertFalse((self.repo / "privacy.txt").exists(),+ "a run that never reached the TV wrote a list")++ def test_a_tv_port_that_is_not_a_number_is_2_too(self):+ # Same import, one step further: tv.py prints the number it could not read and exits 1, which+ # read as an audit that ran and failed.+ result = self.run_privacy(TV_HOST="192.168.1.50", TV_PORT="abc")+ self.assertEqual(result.returncode, 2, result.stderr)+ self.assertIn(BAD_PORT, result.stderr)+ self.assertIn(NOTHING_ASKED, result.stderr)+ self.assertEqual(result.stdout, "")+ self.assertNotIn("Traceback", result.stderr)++ def test_the_address_tv_py_refused_is_the_one_it_prints(self):+ # The line printed is tv.py's, not a rewrite of it: a reader is sent to the tool that judged it.+ result = self.run_privacy()+ self.assertIn("tools/tv.py --probe", result.stderr)+ self.assertNotIn("cannot reach the TV", result.stderr)+++class PrivacyImportExitTest(unittest.TestCase):+ """A tools/tv.py that exits as it is imported, which is all the two refusals above are."""++ def setUp(self):+ tmp = tempfile.TemporaryDirectory()+ self.addCleanup(tmp.cleanup)+ self.base = Path(tmp.name)+ self.repo = self.base / "repo"+ (self.repo / "tools").mkdir(parents=True)+ shutil.copy2(ROOT / "tools" / "privacy.py", self.repo / "tools" / "privacy.py")+ self.script = self.repo / "tools" / "privacy.py"++ def with_tv(self, source):+ (self.repo / "tools" / "tv.py").write_text(source, encoding="utf-8")+ env = dict(os.environ, TV_HOST="192.168.1.50")+ return subprocess.run([sys.executable, str(self.script)], cwd=self.repo, env=env,+ capture_output=True, text=True, stdin=subprocess.DEVNULL, timeout=120)++ def test_a_text_exit_is_printed_and_answered_with_2(self):+ result = self.with_tv('import sys\nsys.exit("the address tv.py read is not one it can use")\n')+ self.assertEqual(result.returncode, 2, result.stderr)+ self.assertIn("the address tv.py read is not one it can use", result.stderr)+ self.assertIn(NOTHING_ASKED, result.stderr)+ self.assertEqual(result.stdout, "")++ def test_a_numeric_exit_is_answered_with_2_as_well(self):+ # tv.py keeps 2 for a command line it cannot read and 1 for the rest of its own refusals; this+ # file's next step looks at whether the TV was asked, not at which number tv.py chose.+ result = self.with_tv("import sys\nsys.exit(3)\n")+ self.assertEqual(result.returncode, 2, result.stderr)+ self.assertIn(NOTHING_ASKED, result.stderr)++ def test_a_module_that_exited_0_keeps_its_status(self):+ # An import that answered the call itself (its own --help) is not a refusal, and is not+ # rewritten: theme_restart.py's import keeps that status too.+ result = self.with_tv("import sys\nsys.exit(0)\n")+ self.assertEqual(result.returncode, 0, result.stderr)+ self.assertNotIn(NOTHING_ASKED, result.stderr)++ def test_a_checkout_without_tv_py_still_says_it_could_not_load_it(self):+ env = dict(os.environ, TV_HOST="192.168.1.50")+ result = subprocess.run([sys.executable, str(self.script)], cwd=self.repo, env=env,+ capture_output=True, text=True, stdin=subprocess.DEVNULL, timeout=120)+ self.assertEqual(result.returncode, 2, result.stderr)+ self.assertIn(CANNOT_LOAD, result.stderr)+ self.assertIn(NOTHING_ASKED, result.stderr)+ self.assertEqual(result.stdout, "")+++if __name__ == "__main__":+ unittest.main()diff --git a/tools/privacy.py b/tools/privacy.pyindex 1fa7d21b9..93f83cb6f 100644--- a/tools/privacy.py+++ b/tools/privacy.py@@ -23,10 +23,11 @@ record written before the first change, replayed by `tools/restore.sh`.Exit status: 0 the audit ran (the report printed, or the list written), 1 it reached the TV and thenfailed (the list could not be written, nothing was identified to write, a file that appeared whilethe audit ran), 2 the run never got as far as the TV: an argument was refused, the `--write` target-cannot be written, `tools/tv.py` could not be loaded, or the connection failed in one of the ways-tv.py explains (a refused port, a Wireless debugging port, a handshake that timed out, a TV that-cannot be reached). Why it stopped goes to stderr, which a wrapper that throws the report on stdout-away still shows.+cannot be written, `tools/tv.py` could not be loaded, `TV_HOST` is not set or `TV_PORT` is not a port+number (tv.py judges those at import and says so in its own words), or the connection failed in one of+the ways tv.py explains (a refused port, a Wireless debugging port, a handshake that timed out, a TV+that cannot be reached). Why it stopped goes to stderr, which a wrapper that throws the report on+stdout away still shows."""import osimport re@@ -160,6 +161,22 @@ def connect():sys.path.insert(0, os.path.dirname(os.path.abspath(__file__)))try:import tv+ except SystemExit as exit_request:+ # tv.py judges its own command line and its address at import time: with no TV_HOST it exits+ # with "Set TV_HOST to your TV's IP address" and a TV_PORT it cannot read with "not a port+ # number", each a string, so the interpreter printed it and exited 1 - the status this file+ # keeps for "it reached the TV and then failed", which is what a wrapper around it reads, and+ # what the owner reads when the audit was never run. Written here, so catching the exit does+ # not hide the text; 2 is the status the docstring already gives a run that never got as far+ # as the TV. theme_restart.py (#2763), recovery.py (#2767) and manage.py (#2692) answer the+ # same import-time exits the same way. A module that exits 0 answered the call itself, and+ # that status stands.+ if not exit_request.code:+ raise+ if isinstance(exit_request.code, str):+ sys.stderr.write(exit_request.code + "\n")+ sys.stderr.write("Nothing was asked of the TV.\n")+ raise SystemExit(2)except ImportError as e:# Exit 2, where SystemExit(str) exits 1 by itself: no command was sent, and 1 is the status# this file keeps for a run that reached the TV and then failed. b64push.py, check.py and