Skip to content

Local code intelligence for developers and AI agents. Connect code, docs and infrastructure in a persistent graph, with CBM Lens, MCP tools, agent integrations and change-aware test selection.

Merge remote-tracking branch 'origin/main' into gq-l5/stack-a-1907

Martin Vogel730a8747e824
diff --cc tests/test_extraction.c
index 82fc6213a,8c37e8c5d..85ebe46bc
--- a/tests/test_extraction.c
+++ b/tests/test_extraction.c
@@@ -7178,17 -7178,69 +7178,74 @@@ TEST(extract_perl_method_call_flags_is_
PASS();
}
+ /* The def QN of `name` and the enclosing-function QN of the call `callee` inside
+ * it, from one extraction result. */
+ static void rust_def_and_scope(const CBMFileResult *r, const char *name, const char *callee,
+ const char **def_qn, const char **scope_qn) {
+ *def_qn = NULL;
+ *scope_qn = NULL;
+ for (int i = 0; i < r->defs.count; i++) {
+ const CBMDefinition *d = &r->defs.items[i];
+ if (d->name && d->qualified_name && strcmp(d->name, name) == 0) {
+ *def_qn = d->qualified_name;
+ }
+ }
+ for (int i = 0; i < r->calls.count; i++) {
+ const CBMCall *c = &r->calls.items[i];
+ if (c->callee_name && strcmp(c->callee_name, callee) == 0 && c->enclosing_func_qn &&
+ strstr(c->enclosing_func_qn, name)) {
+ *scope_qn = c->enclosing_func_qn;
+ }
+ }
+ }
+
+ /* F-R4: a method of a generic impl (`impl<T> Gen<T>`, `impl<'a> Life<'a>`) got a
+ * call scope that kept the generic arguments ("...Gen<T>.in_generic") while the
+ * def side strips them ("...Gen.in_generic"), so no node carried the scope and
+ * every call in the body fell back to the File node (base census: 84,331 Rust
+ * CALLS sourced from a File although inside a function, 96% of all File-sourced
+ * Rust CALLS). The def QN and the call scope must agree. */
+ TEST(extract_rust_generic_impl_call_scope_matches_def) {
+ CBMFileResult *r = extract("pub struct Plain;\n"
+ "impl Plain {\n"
+ " pub fn in_plain(&self) -> u32 { helper() }\n"
+ "}\n"
+ "pub struct Gen<T> { v: T }\n"
+ "impl<T> Gen<T> {\n"
+ " pub fn in_generic(&self) -> u32 { helper() }\n"
+ "}\n"
+ "pub struct Life<'a> { s: &'a str }\n"
+ "impl<'a> Life<'a> {\n"
+ " pub fn in_lifetime(&self) -> u32 { helper() }\n"
+ "}\n"
+ "pub fn helper() -> u32 { 1 }\n",
+ CBM_LANG_RUST, "t", "src/lib.rs");
+ ASSERT_NOT_NULL(r);
+ ASSERT_FALSE(r->has_error);
+ static const char *const methods[] = {"in_plain", "in_generic", "in_lifetime", NULL};
+ for (int m = 0; methods[m]; m++) {
+ const char *def_qn = NULL;
+ const char *scope_qn = NULL;
+ rust_def_and_scope(r, methods[m], "helper", &def_qn, &scope_qn);
+ ASSERT_NOT_NULL(def_qn);
+ ASSERT_NOT_NULL(scope_qn);
+ ASSERT_STR_EQ(scope_qn, def_qn);
+ }
+ cbm_free_result(r);
+ PASS();
+ }
+
-/* Languages OUTSIDE the is_method flag set (only Perl and TS/JS/TSX set it) must
- * be unaffected: a Go method call never sets is_method. */
+/* Languages OUTSIDE the is_method flag set (Perl, Python, TS/JS/TSX and Go set
+ * it) must be unaffected: a Rust method call never sets is_method. */
TEST(extract_flag_exempt_method_call_not_flagged_is_method) {
- CBMFileResult *r = extract("package m\n"
- "func run(o Obj) { o.Commit(); helper() }\n",
- CBM_LANG_GO, "t", "x.go");
+ /* Rust is flag-exempt: only Perl, Python, TS/JS and Go set is_method.
+ * Guards the blast radius of the receiver-aware flags for every other
+ * language. */
+ CBMFileResult *r = extract("fn run(o: Obj) {\n"
+ " o.commit();\n"
+ " helper();\n"
+ "}\n",
+ CBM_LANG_RUST, "t", "x.rs");
ASSERT_NOT_NULL(r);
ASSERT_FALSE(r->has_error);
for (int i = 0; i < r->calls.count; i++) {