Local code intelligence for developers and AI agents. Connect code, docs and infrastructure in a persistent graph, with CBM Lens, MCP tools, agent integrations and change-aware test selection.
C aiderastclaude-codecode-analysiscode-intelligencecodexcursorcypherdeveloper-toolsgemini-cligraph-visualizationkilocodeknowledge-graphmcpmcp-servermodel-context-protocolopencodesqlitetree-sitterwindsurf
fix(store): give every overview group its share of listed entries
Bernhard Jackiewicz7c7dce8300b8
diff --git a/src/store/architecture_projection.c b/src/store/architecture_projection.cindex 5d76944bc..a83e45004 100644--- a/src/store/architecture_projection.c+++ b/src/store/architecture_projection.c@@ -23,8 +23,10 @@ enum {/* Overview entries carry a full representative symbol (about 1.3 KB of* mutable JSON each). Django 5.2.7 has 12,700 components: listing all of* them took half of AP_JSON_BUDGET before any other section. Keep it at- * least the max_components ceiling (512) so displayed parts stay listed. */- AP_OVERVIEW_COMPONENTS = 4096+ * least the max_components ceiling (512) plus 64 groups * AP_GROUP_ENTRIES+ * so displayed parts and every group's share always fit. */+ AP_OVERVIEW_COMPONENTS = 4096,+ AP_GROUP_ENTRIES = 16};enum { AP_EVIDENCE_CONTEXT, AP_EVIDENCE_CORRIDOR, AP_EVIDENCE_PATH, AP_EVIDENCE_SCOPES };@@ -1312,6 +1314,29 @@ done:return rc;}+/* Overview entries are bounded; groups still carry every id and count. The+ * displayed components are listed first, then each group's own top-ranked+ * components up to AP_GROUP_ENTRIES, so that every group can be opened, and+ * the global rank fills the remaining entries. */+static void ap_list_overview(ap_context *c, const ap_rank *ranks) {+ enum { AP_LIST_DISPLAYED, AP_LIST_GROUPS, AP_LIST_RANK, AP_LIST_PASSES };+ int group_entries[sizeof(c->groups) / sizeof(c->groups[0])] = {0};+ int listed = 0;+ for (int i = 0; i < c->component_count; i++)+ c->components[i].listed = false;+ for (int pass = 0; pass < AP_LIST_PASSES; pass++)+ for (int pick = 0; pick < c->component_count && listed < AP_OVERVIEW_COMPONENTS; pick++) {+ ap_component *part = &c->components[ranks[pick].index];+ int *entries = &group_entries[part->overview_group];+ if (part->listed || (pass == AP_LIST_DISPLAYED && part->displayed < 0) ||+ (pass == AP_LIST_GROUPS && *entries >= AP_GROUP_ENTRIES))+ continue;+ part->listed = true;+ (*entries)++;+ listed++;+ }+}+static const char *ap_component_basis(const ap_context *c, int i) {const ap_component *p = &c->components[i];return p->atoms > 1 ? "interaction_community"@@ -1331,7 +1356,8 @@ static int ap_overview(ap_context *c, yyjson_mut_doc *doc, yyjson_mut_val *root)yyjson_mut_obj_add_val(doc, overview, "connections", connections);yyjson_mut_obj_add_val(doc, overview, "totals", totals);yyjson_mut_obj_add_val(doc, overview, "limits", limits);- int connection_count = 0, shown = 0, omitted_parts = 0;+ int connection_count = 0, shown = 0;+ int omitted_entries = 0;if (!c->limited) {for (int g = 0; g < c->group_count; g++) {ap_overview_group *group = &c->groups[g];@@ -1363,11 +1389,11 @@ static int ap_overview(ap_context *c, yyjson_mut_doc *doc, yyjson_mut_val *root)return CBM_STORE_ERR;}/* Groups above keep every component id and count; only the detailed- * entries are bounded, in display rank order. */+ * entries are bounded (ap_list_overview). */for (int i = 0; i < c->component_count; i++) {ap_component *part = &c->components[i];if (!part->listed) {- omitted_parts++;+ omitted_entries++;continue;}yyjson_mut_val *value = yyjson_mut_obj(doc), *reps = yyjson_mut_arr(doc);@@ -1429,13 +1455,13 @@ static int ap_overview(ap_context *c, yyjson_mut_doc *doc, yyjson_mut_val *root)free(edges);}yyjson_mut_obj_add_bool(doc, overview, "complete",- !c->limited && shown == connection_count && !omitted_parts);+ !c->limited && shown == connection_count && !omitted_entries);yyjson_mut_obj_add_int(doc, totals, "groups", c->limited ? 0 : c->group_count);yyjson_mut_obj_add_int(doc, totals, "components", c->limited ? 0 : c->component_count);yyjson_mut_obj_add_int(doc, totals, "accounted_nodes", c->limited ? 0 : c->accounted);yyjson_mut_obj_add_int(doc, totals, "connections", connection_count);yyjson_mut_obj_add_int(doc, limits, "omitted_connections", connection_count - shown);- yyjson_mut_obj_add_int(doc, limits, "omitted_components", omitted_parts);+ yyjson_mut_obj_add_int(doc, limits, "omitted_component_entries", omitted_entries);return CBM_STORE_OK;}@@ -1796,21 +1822,20 @@ static int ap_render(ap_context *c, const char *project, char **out_json) {if (!c->limited) {/* Prefer the largest connected candidates, retaining deterministic IDs.* Never relabel discarded components as a single invented component.- * The same rank bounds the overview entries, which therefore always- * include every displayed component. */+ * The same rank picks the overview entries, before they render. */ap_rank *ranks = malloc(((size_t)c->component_count + 1) * sizeof(*ranks));if (!ranks) {rc = CBM_STORE_ERR;goto done;}- for (int i = 0; i < c->component_count; i++)+ for (int i = 0; i < c->component_count; i++) {+ c->components[i].displayed = -1;ranks[i] = (ap_rank){i, c->components[i].members, c->components[i].degree};- qsort(ranks, (size_t)c->component_count, sizeof(*ranks), ap_rank_compare);- for (int pick = 0; pick < c->component_count; pick++) {- ap_component *part = &c->components[ranks[pick].index];- part->displayed = pick < c->options.max_components ? shown++ : -1;- part->listed = pick < AP_OVERVIEW_COMPONENTS;}+ qsort(ranks, (size_t)c->component_count, sizeof(*ranks), ap_rank_compare);+ for (int pick = 0; pick < c->options.max_components && pick < c->component_count; pick++)+ c->components[ranks[pick].index].displayed = shown++;+ ap_list_overview(c, ranks);free(ranks);if (ap_stopped(c)) {rc = CBM_STORE_ERR;diff --git a/tests/test_architecture_projection.c b/tests/test_architecture_projection.cindex 1468b3323..be56cc568 100644--- a/tests/test_architecture_projection.c+++ b/tests/test_architecture_projection.c@@ -1144,21 +1144,30 @@ TEST(projection_repeated_behavior_evidence_preserves_base_graph_under_budget) {* the node and edge budgets): one full overview entry per component used to* exceed the 32 MB response budget, so the whole projection came back* limited and empty. The overview now lists a bounded, ranked subset and- * still accounts for every component through its groups and totals. */+ * still accounts for every component through its groups and totals. A group+ * whose components all rank last, like Django's @no-source, still gets its+ * own share of entries so that it can be opened. */TEST(projection_many_small_components_stay_within_response_budget) {cbm_store_t *store = projection_store();ASSERT_NOT_NULL(store);- enum { parts = 14000 };+ enum { bulk = 14000, late = 20, parts = bulk + late, entries = 4096, share = 16 };char padding[161];memset(padding, 'x', sizeof(padding) - 1);padding[sizeof(padding) - 1] = '\0';ASSERT_EQ(cbm_store_begin(store), CBM_STORE_OK);- for (int i = 0; i < parts; i++) {+ for (int i = 0; i < bulk; i++) {char qn[256], file[256];snprintf(qn, sizeof(qn), "projection.area%d.%s%05d.Part", i % 8, padding, i);snprintf(file, sizeof(file), "src/area%d/%.*s%05d.py", i % 8, 120, padding, i);ASSERT_TRUE(projection_node(store, "Class", qn, file, false) > 0);}+ /* Equal rank otherwise, so the later ids of this group rank last. */+ for (int i = 0; i < late; i++) {+ char qn[64], file[64];+ snprintf(qn, sizeof(qn), "projection.late.Part%02d", i);+ snprintf(file, sizeof(file), "late/part%02d.py", i);+ ASSERT_TRUE(projection_node(store, "Class", qn, file, false) > 0);+ }ASSERT_EQ(cbm_store_commit(store), CBM_STORE_OK);char *json = NULL;ASSERT_EQ(cbm_store_architecture_projection(store, "projection", NULL, &json), CBM_STORE_OK);@@ -1175,12 +1184,11 @@ TEST(projection_many_small_components_stay_within_response_budget) {*listed = yyjson_obj_get(overview, "components"),*groups = yyjson_obj_get(overview, "groups");size_t listed_count = yyjson_arr_size(listed);- ASSERT_TRUE(listed_count >= 512);- ASSERT_TRUE(listed_count < parts);+ ASSERT_EQ(listed_count, entries);ASSERT_FALSE(yyjson_get_bool(yyjson_obj_get(overview, "complete")));- ASSERT_EQ(- yyjson_get_int(yyjson_obj_get(yyjson_obj_get(overview, "limits"), "omitted_components")),- parts - (int)listed_count);+ ASSERT_EQ(yyjson_get_int(+ yyjson_obj_get(yyjson_obj_get(overview, "limits"), "omitted_component_entries")),+ parts - entries);ASSERT_EQ(yyjson_get_int(yyjson_obj_get(yyjson_obj_get(overview, "totals"), "components")),parts);/* Every displayed component keeps its overview entry. */@@ -1195,8 +1203,25 @@ TEST(projection_many_small_components_stay_within_response_budget) {int members = 0;for (size_t i = 0; i < yyjson_arr_size(groups); i++) {yyjson_val *group = yyjson_arr_get(groups, i);- membership += yyjson_arr_size(yyjson_obj_get(group, "component_ids"));+ yyjson_val *ids = yyjson_obj_get(group, "component_ids");+ membership += yyjson_arr_size(ids);members += yyjson_get_int(yyjson_obj_get(group, "member_count"));+ /* Equal ranks fall back to component order, so each group must list+ * a prefix of its ids, and at least its share of them. */+ const char *group_id = yyjson_get_str(yyjson_obj_get(group, "id"));+ size_t count = yyjson_arr_size(ids), shown = 0, at, maximum;+ yyjson_val *entry;+ yyjson_arr_foreach(listed, at, maximum, entry) {+ if (strcmp(group_id, yyjson_get_str(yyjson_obj_get(entry, "group_id"))))+ continue;+ ASSERT_TRUE(shown < count);+ ASSERT_STR_EQ(yyjson_get_str(yyjson_obj_get(entry, "id")),+ yyjson_get_str(yyjson_arr_get(ids, shown)));+ shown++;+ }+ ASSERT_TRUE(shown >= (count < share ? count : (size_t)share));+ if (!strcmp(yyjson_get_str(yyjson_obj_get(group, "label")), "late"))+ ASSERT_EQ(shown, share);}ASSERT_EQ(membership, parts);ASSERT_EQ(members, parts);