Skip to content

Local code intelligence for developers and AI agents. Connect code, docs and infrastructure in a persistent graph, with CBM Lens, MCP tools, agent integrations and change-aware test selection.

fix(ui): preserve framework route entry points

lorenzozanee9b4d697a57a0
diff --git a/src/ui/layout3d.c b/src/ui/layout3d.c
index 3176da2ff..111be4903 100644
--- a/src/ui/layout3d.c
+++ b/src/ui/layout3d.c
@@ -554,6 +554,7 @@ cbm_layout_result_t *cbm_layout_compute(cbm_store_t *store, const char *project,
/* 3. Query edges — filter during fetch via binary search (O(e log n)) */
int *deg = calloc((size_t)n, sizeof(int));
+ bool *framework_entry = calloc((size_t)n, sizeof(bool));
int mapped = 0;
int edge_cap = CBM_SZ_256;
cbm_edge_t *all_edges = malloc((size_t)edge_cap * sizeof(cbm_edge_t));
@@ -561,8 +562,9 @@ cbm_layout_result_t *cbm_layout_compute(cbm_store_t *store, const char *project,
int *ed = malloc((size_t)edge_cap * sizeof(int));
cbm_schema_info_t schema;
memset(&schema, 0, sizeof(schema));
- if (deg && all_edges && es && ed &&
- cbm_store_get_schema(store, project, &schema) == CBM_STORE_OK) {
+ bool framework_entries_valid = deg && framework_entry && all_edges && es && ed;
+ if (framework_entries_valid) {
+ if (cbm_store_get_schema(store, project, &schema) == CBM_STORE_OK) {
for (int t = 0; t < schema.edge_type_count; t++) {
cbm_edge_t *te = NULL;
int tc = 0;
@@ -571,6 +573,15 @@ cbm_layout_result_t *cbm_layout_compute(cbm_store_t *store, const char *project,
for (int e = 0; e < tc; e++) {
int si = find_node_index(id_map, n, te[e].source_id);
int di = find_node_index(id_map, n, te[e].target_id);
+ if (si >= 0 && te[e].type && strcmp(te[e].type, "HANDLES") == 0) {
+ cbm_node_t route = {0};
+ if (cbm_store_find_node_by_id(store, te[e].target_id, &route) == CBM_STORE_OK) {
+ if (route.label && strcmp(route.label, "Route") == 0)
+ framework_entry[si] = true;
+ cbm_node_free_fields(&route);
+ } else
+ framework_entries_valid = false;
+ }
if (si >= 0 && di >= 0) {
if (mapped >= edge_cap) {
int nc = edge_cap * PAIR_LEN;
@@ -578,6 +589,7 @@ cbm_layout_result_t *cbm_layout_compute(cbm_store_t *store, const char *project,
int *ts = realloc(es, (size_t)nc * sizeof(int));
int *td = realloc(ed, (size_t)nc * sizeof(int));
if (!te2 || !ts || !td) {
+ framework_entries_valid = false;
if (te2)
all_edges = te2;
if (ts)
@@ -606,7 +618,11 @@ cbm_layout_result_t *cbm_layout_compute(cbm_store_t *store, const char *project,
}
}
free(te);
- }
+ } else
+ framework_entries_valid = false;
+ }
+ } else {
+ framework_entries_valid = false;
}
edges_done:
cbm_store_schema_free(&schema);
@@ -630,6 +646,7 @@ cbm_layout_result_t *cbm_layout_compute(cbm_store_t *store, const char *project,
if (!result || !bodies) {
free(bodies);
free(deg);
+ free(framework_entry);
free(es);
free(ed);
free(cdepth);
@@ -735,11 +752,12 @@ cbm_layout_result_t *cbm_layout_compute(cbm_store_t *store, const char *project,
status = "structural";
else if (testish)
status = "test";
- else if (nf.is_entry || nf.is_route)
+ else if (nf.is_entry || nf.is_route ||
+ (framework_entries_valid && framework_entry && framework_entry[i]))
status = "entry";
else if (nf.is_exported)
status = "exported";
- else if (ic == 0 && iu == 0)
+ else if (framework_entries_valid && ic == 0 && iu == 0)
status = "dead";
else if (ic == 1)
status = "single";
@@ -772,6 +790,7 @@ cbm_layout_result_t *cbm_layout_compute(cbm_store_t *store, const char *project,
free(bodies);
free(deg);
+ free(framework_entry);
free(es);
free(ed);
free(cdepth);
diff --git a/tests/test_ui.c b/tests/test_ui.c
index a403dbbbe..e4f2129bb 100644
--- a/tests/test_ui.c
+++ b/tests/test_ui.c
@@ -627,6 +627,30 @@ TEST(layout_dead_code_classification) {
.qualified_name = "dc::exportedfn",
.file_path = "src/d.c",
.properties_json = "{\"is_exported\":true}"};
+ cbm_node_t framework = {.project = "dc",
+ .label = "Function",
+ .name = "frameworkfn",
+ .qualified_name = "dc::frameworkfn",
+ .file_path = "src/routes.c",
+ .properties_json = "{}"};
+ cbm_node_t route = {.project = "dc",
+ .label = "Route",
+ .name = "GET /framework",
+ .qualified_name = "dc::route",
+ .file_path = "src/routes.c",
+ .properties_json = "{}"};
+ cbm_node_t unrelated = {.project = "dc",
+ .label = "Class",
+ .name = "UnrelatedTarget",
+ .qualified_name = "dc::unrelated",
+ .file_path = "src/routes.c",
+ .properties_json = "{}"};
+ cbm_node_t nonroute = {.project = "dc",
+ .label = "Function",
+ .name = "nonroutefn",
+ .qualified_name = "dc::nonroutefn",
+ .file_path = "src/routes.c",
+ .properties_json = "{}"};
cbm_node_t single = {.project = "dc",
.label = "Function",
.name = "calledonce",
@@ -658,6 +682,14 @@ TEST(layout_dead_code_classification) {
cbm_store_upsert_node(store, &tst);
cbm_store_upsert_node(store, &tstpath);
cbm_store_upsert_node(store, &exp);
+ int64_t id_framework = cbm_store_upsert_node(store, &framework);
+ int64_t id_route = cbm_store_upsert_node(store, &route);
+ int64_t id_unrelated = cbm_store_upsert_node(store, &unrelated);
+ int64_t id_nonroute = cbm_store_upsert_node(store, &nonroute);
+ ASSERT_GT(id_framework, 0);
+ ASSERT_GT(id_route, 0);
+ ASSERT_GT(id_unrelated, 0);
+ ASSERT_GT(id_nonroute, 0);
int64_t id_single = cbm_store_upsert_node(store, &single);
int64_t id_norm = cbm_store_upsert_node(store, &norm);
int64_t id_caller = cbm_store_upsert_node(store, &caller);
@@ -670,9 +702,15 @@ TEST(layout_dead_code_classification) {
cbm_edge_t e2 = {
.project = "dc", .source_id = id_caller, .target_id = id_norm, .type = "CALLS"};
cbm_edge_t e3 = {.project = "dc", .source_id = id_dead, .target_id = id_norm, .type = "CALLS"};
+ cbm_edge_t framework_route = {
+ .project = "dc", .source_id = id_framework, .target_id = id_route, .type = "HANDLES"};
+ cbm_edge_t framework_unrelated = {
+ .project = "dc", .source_id = id_nonroute, .target_id = id_unrelated, .type = "HANDLES"};
cbm_store_insert_edge(store, &e1);
cbm_store_insert_edge(store, &e2);
cbm_store_insert_edge(store, &e3);
+ ASSERT_GT(cbm_store_insert_edge(store, &framework_route), 0);
+ ASSERT_GT(cbm_store_insert_edge(store, &framework_unrelated), 0);
cbm_layout_result_t *r = cbm_layout_compute(store, "dc", CBM_LAYOUT_OVERVIEW, NULL, 0, 100);
ASSERT_NOT_NULL(r);
@@ -700,6 +738,18 @@ TEST(layout_dead_code_classification) {
ASSERT_NOT_NULL(ln);
ASSERT_STR_EQ(ln->status, "exported");
+ ln = find_layout_node(r, "frameworkfn");
+ ASSERT_NOT_NULL(ln);
+ ASSERT_STR_EQ(ln->status, "entry");
+
+ ln = find_layout_node(r, "nonroutefn");
+ ASSERT_NOT_NULL(ln);
+ ASSERT_STR_EQ(ln->status, "dead");
+
+ ln = find_layout_node(r, "GET /framework");
+ ASSERT_NOT_NULL(ln);
+ ASSERT_STR_EQ(ln->status, "structural");
+
ln = find_layout_node(r, "calledonce");
ASSERT_NOT_NULL(ln);
ASSERT_STR_EQ(ln->status, "single");