Skip to content

Local code intelligence for developers and AI agents. Connect code, docs and infrastructure in a persistent graph, with CBM Lens, MCP tools, agent integrations and change-aware test selection.

test(ts): cover module-level inferred receiver

mikemikimikeb74e91cb2f2b
diff --git a/tests/repro/repro_lsp_ts.c b/tests/repro/repro_lsp_ts.c
index eefed2cd9..6221e4416 100644
--- a/tests/repro/repro_lsp_ts.c
+++ b/tests/repro/repro_lsp_ts.c
@@ -115,8 +115,9 @@
* does (".ts" → TypeScript, ".tsx" → TSX). Returns 0 on PASS (GREEN), non-zero
* on FAIL (RED) — the redness is the documented per-pass status.
*/
-static int assert_lsp_strategy_files(const RFile *files, int nfiles,
- const char *strategy) {
+static int assert_lsp_strategy_files_expected(const RFile *files, int nfiles,
+ const char *strategy,
+ int expected_module_sourced) {
RProj lp;
cbm_store_t *store = rh_index_files(&lp, files, nfiles);
if (!store) {
@@ -135,12 +136,13 @@ static int assert_lsp_strategy_files(const RFile *files, int nfiles,
int rc = 0;
- /* (a) callable-sourcing floor: zero Module/File-sourced CALLS edges. */
- if (module_sourced != 0) {
+ /* (a) keep module-sourced calls explicit so top-level constructors are
+ * allowed only in fixtures that expect them. */
+ if (module_sourced != expected_module_sourced) {
printf(" %sFAIL%s %s:%d: strategy %s: %d Module-sourced CALLS "
- "(expected 0)\n",
+ "(expected %d)\n",
tf_red(), tf_reset(), __FILE__, __LINE__, strategy,
- module_sourced);
+ module_sourced, expected_module_sourced);
rc = 1;
}
/* There must be a callable-sourced CALLS edge, else the fixture produced no
@@ -165,6 +167,11 @@ static int assert_lsp_strategy_files(const RFile *files, int nfiles,
return rc;
}
+static int assert_lsp_strategy_files(const RFile *files, int nfiles,
+ const char *strategy) {
+ return assert_lsp_strategy_files_expected(files, nfiles, strategy, 0);
+}
+
/* Single-file convenience wrapper. */
static int assert_lsp_strategy(const char *filename, const char *src,
const char *strategy) {
@@ -297,9 +304,8 @@ static const RFile kTsImport[] = {
"function caller(v: number): number { return helper(v); }\n"},
};
-/* An imported class constructed through an inferred local variable must retain
- * the imported class QN for subsequent member dispatch. The explicit type
- * annotation path already covers this shape; this fixture isolates inference.
+/* Keep the module-level inferred receiver shape from issue #1974: a local
+ * initialized from an imported constructor is used by a later function.
*/
static const RFile kTsInferredImportedMethod[] = {
{"store.ts",
@@ -308,21 +314,12 @@ static const RFile kTsInferredImportedMethod[] = {
"}\n"},
{"service.ts",
"import { WidgetStore } from \"./store\";\n"
+ "const inferred = new WidgetStore();\n"
"function load(id: string): string {\n"
- " const store = new WidgetStore();\n"
- " return store.findById(id);\n"
+ " return inferred.findById(id);\n"
"}\n"},
};
-/* A standard-library class constructed through an inferred local variable must
- * retain its bare stdlib QN for member dispatch; the current expected-red
- * result and investigation are documented at the board case below. */
-static const char kTsInferredStdlibMethod[] =
- "function lookup(id: string): string {\n"
- " const m = new Map<string, string>();\n"
- " return m.get(id);\n"
- "}\n";
-
/* lsp_ts_jsx — <Comp/> JSX element whose tag is a module-local component
* function (ts_lsp.c:2643-2647). TSX only (jsx_mode); the tag's first letter is
* uppercase so it is NOT treated as an intrinsic HTML element; it resolves via
@@ -396,22 +393,12 @@ TEST(repro_lsp_ts_import) {
"lsp_ts_import");
}
-TEST(repro_lsp_ts_inferred_import_receiver) {
- return assert_lsp_strategy_files(
+TEST(repro_lsp_ts_inferred_import_module_receiver) {
+ return assert_lsp_strategy_files_expected(
kTsInferredImportedMethod,
(int)(sizeof(kTsInferredImportedMethod) /
sizeof(kTsInferredImportedMethod[0])),
- "lsp_ts_method");
-}
-
-TEST(repro_lsp_ts_inferred_stdlib_receiver) {
- /* EXPECTED-RED on the non-gating board: the runner emits no callable-
- * sourced CALLS edge (callable=0) and no lsp_ts_method strategy. Verified
- * with scripts/repro.sh CC=gcc CXX=g++; the focused ts_lsp suite does not
- * run this file. Current, unproven hypothesis: Map.get is unavailable as
- * a callable target from the TypeScript stdlib seed. */
- return assert_lsp_strategy("main.ts", kTsInferredStdlibMethod,
- "lsp_ts_method");
+ "lsp_ts_method", 1);
}
TEST(repro_lsp_ts_jsx) {
@@ -447,8 +434,7 @@ SUITE(repro_lsp_ts) {
RUN_TEST(repro_lsp_ts_method);
RUN_TEST(repro_lsp_ts_namespace);
RUN_TEST(repro_lsp_ts_import);
- RUN_TEST(repro_lsp_ts_inferred_import_receiver);
- RUN_TEST(repro_lsp_ts_inferred_stdlib_receiver);
+ RUN_TEST(repro_lsp_ts_inferred_import_module_receiver);
RUN_TEST(repro_lsp_ts_jsx);
RUN_TEST(repro_lsp_ts_jsx_import);
RUN_TEST(repro_lsp_ts_default);