Skip to content

Local code intelligence for developers and AI agents. Connect code, docs and infrastructure in a persistent graph, with CBM Lens, MCP tools, agent integrations and change-aware test selection.

fix(pipeline): decode persisted LSP surfaces with linear array iteration

JosephStarobinetsd7eba5a71d2a
diff --git a/src/pipeline/lsp_surface.c b/src/pipeline/lsp_surface.c
index 5a8c89f97..0cf6a167f 100644
--- a/src/pipeline/lsp_surface.c
+++ b/src/pipeline/lsp_surface.c
@@ -250,9 +250,15 @@ static const char **arena_str_array(CBMArena *arena, yyjson_val *arr, bool null_
if (!items) {
return NULL;
}
- for (int i = 0; i < count; i++) {
- const char *s = yyjson_get_str(yyjson_arr_get(arr, (size_t)i));
- items[i] = s ? cbm_arena_strdup(arena, s) : "?";
+ /* Iterate instead of yyjson_arr_get(i): that call is a linear scan for
+ * non-flat arrays (arrays of objects are not flat), which turns this loop
+ * into O(n^2) in the element count. */
+ yyjson_arr_iter iter = yyjson_arr_iter_with(arr);
+ int i = 0;
+ yyjson_val *item;
+ while ((item = yyjson_arr_iter_next(&iter))) {
+ const char *s = yyjson_get_str(item);
+ items[i++] = s ? cbm_arena_strdup(arena, s) : "?";
}
if (null_terminated) {
items[count] = NULL;
@@ -288,9 +294,15 @@ int cbm_lsp_surface_defs_from_json(CBMArena *arena, const char *defs_json, CBMLS
return -1;
}
memset(defs, 0, (size_t)count * sizeof(CBMLSPDef));
- for (int i = 0; i < count; i++) {
- yyjson_val *o = yyjson_arr_get(lsp, (size_t)i);
- CBMLSPDef *d = &defs[i];
+ /* Iterate instead of yyjson_arr_get(i). `lsp` is an array of objects, which
+ * is not flat, so indexing rescans the preceding elements and the whole
+ * decode becomes O(n^2). One generated data file with ~300k defs made this
+ * step take minutes. */
+ yyjson_arr_iter iter = yyjson_arr_iter_with(lsp);
+ int i = 0;
+ yyjson_val *o;
+ while ((o = yyjson_arr_iter_next(&iter))) {
+ CBMLSPDef *d = &defs[i++];
d->qualified_name = arena_str_or_null(arena, yyjson_obj_get(o, "qn"));
d->short_name = arena_str_or_null(arena, yyjson_obj_get(o, "sn"));
d->label = arena_str_or_null(arena, yyjson_obj_get(o, "lb"));
diff --git a/tests/test_pipeline.c b/tests/test_pipeline.c
index d32ab3538..854d1088c 100644
--- a/tests/test_pipeline.c
+++ b/tests/test_pipeline.c
@@ -10,6 +10,7 @@
#include "test_helpers.h"
#include "foundation/mem.h" // cbm_mem_init/budget (back-pressure futile-nap test)
#include "pipeline/pipeline.h"
+#include "pipeline/lsp_surface.h"
#include "pipeline/pipeline_internal.h"
#include "pipeline/artifact.h"
#include "store/store.h"
@@ -14185,6 +14186,48 @@ TEST(pipeline_seq_ts_cross_uses_shared_registry) {
PASS();
}
+/* Object arrays are non-flat in yyjson. Exercise ordered decoding and arena
+ * ownership across a large surface, including nested string arrays. */
+TEST(pipeline_lsp_surface_large_object_array_decode) {
+ const int count = 8192;
+ const size_t capacity = (size_t)count * 192 + 64;
+ char *json = malloc(capacity);
+ ASSERT_NOT_NULL(json);
+ size_t used = (size_t)snprintf(json, capacity, "{\"v\":1,\"lsp\":[");
+ for (int i = 0; i < count; i++) {
+ int n = snprintf(json + used, capacity - used,
+ "%s{\"qn\":\"pkg.f%d\",\"sn\":\"f%d\",\"lb\":\"Function\","
+ "\"spt\":[\"str\",\"int\"],\"dec\":[\"first\",\"second\"]}",
+ i ? "," : "", i, i);
+ ASSERT_TRUE(n > 0 && (size_t)n < capacity - used);
+ used += (size_t)n;
+ }
+ snprintf(json + used, capacity - used, "]}");
+ CBMArena arena;
+ cbm_arena_init(&arena);
+ CBMLSPDef *defs = NULL;
+ int decoded = cbm_lsp_surface_defs_from_json(&arena, json, &defs);
+ free(json);
+ ASSERT_EQ(decoded, count);
+ ASSERT_NOT_NULL(defs);
+ for (int i = 0; i < count; i++) {
+ char expected[64];
+ snprintf(expected, sizeof(expected), "pkg.f%d", i);
+ ASSERT_STR_EQ(defs[i].qualified_name, expected);
+ snprintf(expected, sizeof(expected), "f%d", i);
+ ASSERT_STR_EQ(defs[i].short_name, expected);
+ ASSERT_STR_EQ(defs[i].label, "Function");
+ ASSERT_EQ(defs[i].signature_param_count, 2);
+ ASSERT_STR_EQ(defs[i].signature_param_types[0], "str");
+ ASSERT_STR_EQ(defs[i].signature_param_types[1], "int");
+ ASSERT_STR_EQ(defs[i].decorators[0], "first");
+ ASSERT_STR_EQ(defs[i].decorators[1], "second");
+ ASSERT_NULL(defs[i].decorators[2]);
+ }
+ cbm_arena_destroy(&arena);
+ PASS();
+}
+
/* The closure-repair route lives and dies by two properties of the persisted
* per-file LSP surface: a BODY edit must leave the surface_sha unchanged (the
* early cutoff -- no dependent recomputation owed), while a SIGNATURE edit
@@ -15054,6 +15097,7 @@ TEST(pipeline_objectscript_export_range_join_keeps_one_trailing_marker) {
#endif
SUITE(pipeline) {
+ RUN_TEST(pipeline_lsp_surface_large_object_array_decode);
RUN_TEST(pipeline_lsp_surface_persisted_and_body_edit_invariant);
/* Index lock */
RUN_TEST(pipeline_lock_try_acquire);