Skip to content

Local code intelligence for developers and AI agents. Connect code, docs and infrastructure in a persistent graph, with CBM Lens, MCP tools, agent integrations and change-aware test selection.

feat(extraction): route Next.js App Router handlers

Petteri Ponsimaafa331ed5e6b4
diff --git a/Makefile.cbm b/Makefile.cbm
index 3b93146f1..631290d69 100644
--- a/Makefile.cbm
+++ b/Makefile.cbm
@@ -397,6 +397,7 @@ EXTRACTION_SRCS = \
$(CBM_DIR)/diagram.c \
$(CBM_DIR)/route_path.c \
$(CBM_DIR)/openapi.c \
+ $(CBM_DIR)/extract_nextjs.c \
$(CBM_DIR)/sql_values.c \
$(CBM_DIR)/helpers.c \
$(CBM_DIR)/cpp_branch_views.c \
diff --git a/internal/cbm/cbm.c b/internal/cbm/cbm.c
index 23b871dbc..50dd97568 100644
--- a/internal/cbm/cbm.c
+++ b/internal/cbm/cbm.c
@@ -3902,6 +3902,9 @@ static CBMFileResult *extract_file_ex_body(const char *source, int source_len, C
// OpenAPI operations as Routes (self-gated: API description documents).
cbm_extract_openapi(&ctx);
+ // Next.js App Router handlers' routes (self-gated: app/**/route.ts and route.js).
+ cbm_extract_nextjs_routes(&ctx);
+
// K8s / Kustomize semantic pass (additional structured extraction for YAML-based infra files).
if (ctx.language == CBM_LANG_KUSTOMIZE || ctx.language == CBM_LANG_K8S) {
cbm_extract_k8s(&ctx);
diff --git a/internal/cbm/cbm.h b/internal/cbm/cbm.h
index ade41fea5..12b8c1acd 100644
--- a/internal/cbm/cbm.h
+++ b/internal/cbm/cbm.h
@@ -1389,6 +1389,11 @@ void cbm_extract_diagram_file(CBMExtractCtx *ctx);
* or JSON files whose root says `openapi` or `swagger`. */
void cbm_extract_openapi(CBMExtractCtx *ctx);
+/* Next.js App Router route handlers (extract_nextjs.c): the HTTP verb Functions
+ * a route file exports carry the route path its directories name. Self-gated:
+ * TS / JS route.ts and route.js under app/ or src/app/. */
+void cbm_extract_nextjs_routes(CBMExtractCtx *ctx);
+
/* Canonicalize route-path parameter placeholders (":id", "{id}", "<id>",
* "${...}") to a single "{}" token so that client call sites, server handlers
* and OpenAPI operations rendezvous on the same Route QN regardless of
diff --git a/internal/cbm/extract_nextjs.c b/internal/cbm/extract_nextjs.c
new file mode 100644
index 000000000..eea270fa7
--- /dev/null
+++ b/internal/cbm/extract_nextjs.c
@@ -0,0 +1,272 @@
+/*
+ * extract_nextjs.c -- Next.js App Router route handlers (#759): an HTTP verb a
+ * route file (`app/.../route.ts` or `route.js`, the app directory at the root
+ * or under src/) exports serves the path its directories name.
+ *
+ * The handler is the Function definition extraction already made for the
+ * export: this fills its route_path / route_method, so its Route node and
+ * HANDLES edge come from the route pass exactly as a decorator route's do, on
+ * a full and on an incremental index alike. The path is spelled as SvelteKit's
+ * (sveltekit_route_path, pass_route_nodes.c): `[id]` is `:id`, `[...slug]` is
+ * `*slug` and a `(group)` directory adds no segment.
+ *
+ * A directory this cannot spell makes the file no route at all: an optional
+ * catch-all (`[[...slug]]`), a private folder (`_lib`), a parallel slot
+ * (`@modal`), an intercepting route (`(.)photo`), a malformed bracket, or a
+ * path that does not fit route_path. A handler is a Function of this file:
+ * `export [async] function GET`, `export const GET = [async] (...) => ...`,
+ * or `export { GET }` of such a declaration. A renamed
+ * (`export { handler as GET }`), re-exported, destructured or wrapped
+ * (`export const GET = auth(handler)`) handler, or a `function` expression
+ * bound to a const, has no Function of its own here and is not routed. Each
+ * file is judged alone: a src/app/ route file is routed even where a root
+ * app/ directory makes Next.js ignore src/app/.
+ */
+#include "cbm.h"
+#include "foundation/arena.h"
+#include "helpers.h"
+#include "tree_sitter/api.h"
+#include "foundation/constants.h"
+#include <stdbool.h>
+#include <stdint.h>
+#include <string.h>
+
+enum {
+ NX_PATH_MAX = CBM_SZ_256, /* the route pass rebuilds a Route from this much */
+ NX_REST_LEN = 3, /* "..." */
+};
+
+/* The path of a route file below its app directory, NULL for any other file. */
+static const char *nx_app_relative(const char *rel_path) {
+ const char *base = rel_path ? strrchr(rel_path, '/') : NULL;
+ if (!base || (strcmp(base, "/route.ts") != 0 && strcmp(base, "/route.js") != 0)) {
+ return NULL;
+ }
+ if (strncmp(rel_path, "app/", strlen("app/")) == 0) {
+ return rel_path + strlen("app/");
+ }
+ if (strncmp(rel_path, "src/app/", strlen("src/app/")) == 0) {
+ return rel_path + strlen("src/app/");
+ }
+ return NULL;
+}
+
+static bool nx_has_any(const char *s, size_t n, const char *chars) {
+ for (size_t i = 0; i < n; i++) {
+ if (strchr(chars, s[i])) {
+ return true;
+ }
+ }
+ return false;
+}
+
+/* Append directory segment seg (n bytes) to the route path out[*len]. False
+ * when the segment cannot be spelled or the path would not fit. */
+static bool nx_append_segment(char *out, size_t *len, const char *seg, size_t n) {
+ if (n == 0 || seg[0] == '_' || seg[0] == '@') {
+ return false;
+ }
+ if (seg[0] == '(') {
+ /* A route group adds nothing; `(.)x`, `(..)x` and `(...)x` intercept. */
+ return n > PAIR_LEN && seg[n - SKIP_ONE] == ')' && seg[SKIP_ONE] != '.' &&
+ !nx_has_any(seg + SKIP_ONE, n - PAIR_LEN, "()");
+ }
+ char marker = '\0';
+ if (seg[0] == '[') {
+ if (seg[n - SKIP_ONE] != ']') {
+ return false;
+ }
+ marker = ':';
+ seg += SKIP_ONE;
+ n -= PAIR_LEN;
+ if (n >= NX_REST_LEN && strncmp(seg, "...", NX_REST_LEN) == 0) {
+ marker = '*';
+ seg += NX_REST_LEN;
+ n -= NX_REST_LEN;
+ }
+ if (n == 0 || nx_has_any(seg, n, "[].")) {
+ return false;
+ }
+ } else if (nx_has_any(seg, n, "[]")) {
+ return false;
+ }
+ size_t need = SKIP_ONE + (marker ? SKIP_ONE : 0) + n;
+ if (*len + need >= NX_PATH_MAX) {
+ return false;
+ }
+ out[(*len)++] = '/';
+ if (marker) {
+ out[(*len)++] = marker;
+ }
+ memcpy(out + *len, seg, n);
+ *len += n;
+ out[*len] = '\0';
+ return true;
+}
+
+/* The route path of the file being extracted, in the arena; NULL for none. */
+static const char *nx_route_path(CBMExtractCtx *ctx) {
+ const char *seg = nx_app_relative(ctx->rel_path);
+ if (!seg) {
+ return NULL;
+ }
+ const char *base = strrchr(ctx->rel_path, '/');
+ char path[NX_PATH_MAX] = "/";
+ size_t len = 0;
+ while (seg < base) {
+ const char *end = strchr(seg, '/');
+ if (!nx_append_segment(path, &len, seg, (size_t)(end - seg))) {
+ return NULL;
+ }
+ seg = end + SKIP_ONE;
+ }
+ return cbm_arena_strdup(ctx->arena, path);
+}
+
+static bool nx_is_method(const char *name) {
+ static const char *const methods[] = {"GET", "POST", "PUT", "PATCH",
+ "DELETE", "HEAD", "OPTIONS"};
+ for (size_t i = 0; i < sizeof(methods) / sizeof(methods[0]); i++) {
+ if (strcmp(name, methods[i]) == 0) {
+ return true;
+ }
+ }
+ return false;
+}
+
+static bool nx_is(TSNode n, const char *type) {
+ return !ts_node_is_null(n) && strcmp(ts_node_type(n), type) == 0;
+}
+
+/* Does a node carry the anonymous keyword child kw (`default`, `type`)? */
+static bool nx_has_keyword(TSNode n, const char *kw) {
+ uint32_t count = ts_node_child_count(n);
+ for (uint32_t i = 0; i < count; i++) {
+ TSNode c = ts_node_child(n, i);
+ if (!ts_node_is_named(c) && strcmp(ts_node_type(c), kw) == 0) {
+ return true;
+ }
+ }
+ return false;
+}
+
+/* The name of a declarator whose value is an arrow function, the Function
+ * extraction names after the binding (`GET = () => ...`); a null node for any
+ * other declarator. */
+static TSNode nx_arrow_binding(TSNode declarator) {
+ TSNode value = ts_node_child_by_field_name(declarator, TS_FIELD("value"));
+ TSNode name = ts_node_child_by_field_name(declarator, TS_FIELD("name"));
+ if (!nx_is(name, "identifier") || !nx_is(value, "arrow_function")) {
+ return (TSNode){0};
+ }
+ return name;
+}
+
+/* Route the Function definition named by name_node, declared inside decl. */
+static void nx_route_handler(CBMExtractCtx *ctx, TSNode decl, TSNode name_node, const char *path) {
+ const char *name = cbm_node_text(ctx->arena, name_node, ctx->source);
+ if (!name || !nx_is_method(name)) {
+ return;
+ }
+ const char *qn =
+ cbm_fqn_compute_source_lang(ctx->arena, ctx->project, ctx->rel_path, name, ctx->language);
+ uint32_t first = ts_node_start_point(decl).row + TS_LINE_OFFSET;
+ uint32_t last = ts_node_end_point(decl).row + TS_LINE_OFFSET;
+ for (int i = 0; qn && i < ctx->result->defs.count; i++) {
+ CBMDefinition *def = &ctx->result->defs.items[i];
+ if (!def->route_path && def->label && def->qualified_name &&
+ strcmp(def->label, "Function") == 0 && strcmp(def->qualified_name, qn) == 0 &&
+ def->start_line >= first && def->end_line <= last) {
+ def->route_path = path;
+ def->route_method = name;
+ return;
+ }
+ }
+}
+
+/* Does the name node, if any, spell want? Any name does when want is NULL. */
+static bool nx_wanted(CBMExtractCtx *ctx, TSNode name, const char *want) {
+ if (ts_node_is_null(name)) {
+ return false;
+ }
+ const char *text = want ? cbm_node_text(ctx->arena, name, ctx->source) : NULL;
+ return !want || (text && strcmp(text, want) == 0);
+}
+
+/* Route the handlers a top-level declaration (function or const) defines.
+ * Only names equal to want are considered when want is set. */
+static void nx_route_declaration(CBMExtractCtx *ctx, TSNode decl, const char *path,
+ const char *want) {
+ if (nx_is(decl, "function_declaration")) {
+ TSNode name = ts_node_child_by_field_name(decl, TS_FIELD("name"));
+ if (nx_wanted(ctx, name, want)) {
+ nx_route_handler(ctx, decl, name, path);
+ }
+ return;
+ }
+ if (!nx_is(decl, "lexical_declaration") && !nx_is(decl, "variable_declaration")) {
+ return;
+ }
+ uint32_t count = ts_node_named_child_count(decl);
+ for (uint32_t i = 0; i < count; i++) {
+ TSNode declarator = ts_node_named_child(decl, i);
+ TSNode name =
+ nx_is(declarator, "variable_declarator") ? nx_arrow_binding(declarator) : (TSNode){0};
+ if (nx_wanted(ctx, name, want)) {
+ nx_route_handler(ctx, declarator, name, path);
+ }
+ }
+}
+
+/* `export { GET }`: route the file's own top-level declaration of each
+ * unrenamed, non-type specifier. */
+static void nx_route_export_clause(CBMExtractCtx *ctx, TSNode clause, const char *path) {
+ uint32_t count = ts_node_named_child_count(clause);
+ uint32_t top = ts_node_named_child_count(ctx->root);
+ for (uint32_t i = 0; i < count; i++) {
+ TSNode spec = ts_node_named_child(clause, i);
+ TSNode name = ts_node_child_by_field_name(spec, TS_FIELD("name"));
+ if (!nx_is(spec, "export_specifier") || !nx_is(name, "identifier") ||
+ !ts_node_is_null(ts_node_child_by_field_name(spec, TS_FIELD("alias"))) ||
+ nx_has_keyword(spec, "type") || nx_has_keyword(spec, "typeof")) {
+ continue;
+ }
+ const char *want = cbm_node_text(ctx->arena, name, ctx->source);
+ for (uint32_t j = 0; want && j < top; j++) {
+ nx_route_declaration(ctx, ts_node_named_child(ctx->root, j), path, want);
+ }
+ }
+}
+
+void cbm_extract_nextjs_routes(CBMExtractCtx *ctx) {
+ if (ctx->language != CBM_LANG_TYPESCRIPT && ctx->language != CBM_LANG_JAVASCRIPT) {
+ return;
+ }
+ const char *path = nx_route_path(ctx);
+ if (!path) {
+ return;
+ }
+ uint32_t count = ts_node_named_child_count(ctx->root);
+ for (uint32_t i = 0; i < count; i++) {
+ TSNode node = ts_node_named_child(ctx->root, i);
+ /* A runtime export of this file: not `export default`, not
+ * `export type { ... }`, not a re-export `... from './x'`. */
+ if (!nx_is(node, "export_statement") || nx_has_keyword(node, "default") ||
+ nx_has_keyword(node, "type") ||
+ !ts_node_is_null(ts_node_child_by_field_name(node, TS_FIELD("source")))) {
+ continue;
+ }
+ TSNode decl = ts_node_child_by_field_name(node, TS_FIELD("declaration"));
+ if (!ts_node_is_null(decl)) {
+ nx_route_declaration(ctx, decl, path, NULL);
+ continue;
+ }
+ uint32_t parts = ts_node_named_child_count(node);
+ for (uint32_t j = 0; j < parts; j++) {
+ TSNode part = ts_node_named_child(node, j);
+ if (nx_is(part, "export_clause")) {
+ nx_route_export_clause(ctx, part, path);
+ }
+ }
+ }
+}
diff --git a/src/pipeline/pipeline_internal.h b/src/pipeline/pipeline_internal.h
index fb5b724d6..bf72989a0 100644
--- a/src/pipeline/pipeline_internal.h
+++ b/src/pipeline/pipeline_internal.h
@@ -1645,8 +1645,13 @@ int cbm_pipeline_build_fresh_semantic_manifest(cbm_pipeline_t *p, const char *pr
* a kube / k8s task DEPLOYS {via:ansible} the template it applies
* (pass_ansible.c). An external Chart is keyed by its publisher URL.
* An index built before holds none of them, so it rebuilds once on
- * upgrade. */
-enum { CBM_SEMANTIC_INDEX_VERSION = 9 };
+ * upgrade.
+ * 10: a Next.js App Router route handler, the HTTP verb Function a route.ts
+ * / route.js under app/ or src/app/ exports, carries the route_path its
+ * directories name and HANDLES its Route (extract_nextjs.c). An index
+ * built before has none of these Routes for its unchanged route files,
+ * so it rebuilds once on upgrade. */
+enum { CBM_SEMANTIC_INDEX_VERSION = 10 };
typedef struct {
cbm_gbuf_t *gbuf;
diff --git a/tests/test_extraction.c b/tests/test_extraction.c
index e1c1e4491..15f03463a 100644
--- a/tests/test_extraction.c
+++ b/tests/test_extraction.c
@@ -5622,6 +5622,177 @@ TEST(extract_ts_nestjs_controller_routes_issue1428) {
PASS();
}
+/* #759: the one definition named `name`; NULL for none or more than one. */
+static const CBMDefinition *nextjs_only_def(CBMFileResult *r, const char *name) {
+ const CBMDefinition *found = NULL;
+ for (int i = 0; i < r->defs.count; i++) {
+ if (r->defs.items[i].name && strcmp(r->defs.items[i].name, name) == 0) {
+ if (found) {
+ return NULL;
+ }
+ found = &r->defs.items[i];
+ }
+ }
+ return found;
+}
+
+/* #759: a Next.js App Router route file's exported HTTP verb handlers are the
+ * Functions extraction already makes for them, now carrying the route path of
+ * the file's directories -- `[id]` as `:id`, `[...slug]` as `*slug`, a
+ * `(group)` adding nothing -- and the verb as their method. A local
+ * declaration exported by name (`export { GET }`) is that same Function; no
+ * second definition appears. The 255-byte path is the longest that fits. */
+TEST(extract_nextjs_route_metadata_contract_issue759) {
+ char long_file[CBM_SZ_512];
+ char long_path[CBM_SZ_256];
+ char segment[CBM_SZ_256];
+ memset(segment, 'x', CBM_SZ_256 - PAIR_LEN);
+ segment[CBM_SZ_256 - PAIR_LEN] = '\0';
+ snprintf(long_file, sizeof(long_file), "app/%s/route.ts", segment);
+ snprintf(long_path, sizeof(long_path), "/%s", segment);
+ static const char verbs_src[] = "export async function GET() {}\n"
+ "export async function POST() {}\n"
+ "export function PUT() {}\n"
+ "export function PATCH() {}\n"
+ "export function DELETE() {}\n"
+ "export function HEAD() {}\n"
+ "export function OPTIONS() {}\n";
+ const struct {
+ const char *file;
+ const char *src;
+ const char *path;
+ const char *names[CBM_SZ_8];
+ } cases[] = {
+ {"src/app/api/users/[id]/route.ts",
+ "export function GET() { return 1; }\nexport const POST = async () => 2;\n",
+ "/api/users/:id",
+ {"GET", "POST"}},
+ {"app/api/verbs/route.ts",
+ verbs_src,
+ "/api/verbs",
+ {"GET", "POST", "PUT", "PATCH", "DELETE", "HEAD", "OPTIONS"}},
+ {"src/app/(public)/api/[org]/users/[id]/route.ts",
+ "export async function GET() { return 1; }\n",
+ "/api/:org/users/:id",
+ {"GET"}},
+ {"app/api/[...slug]/route.ts", "export function GET() {}\n", "/api/*slug", {"GET"}},
+ {"app/api/typed/route.ts",
+ "type Handler = () => Promise<number>;\nexport const GET: Handler = async () => 1;\n",
+ "/api/typed",
+ {"GET"}},
+ {"app/route.js", "export function GET() { return 1; }\n", "/", {"GET"}},
+ {"app/api/local/route.ts",
+ "function GET() { return 1; }\nconst POST = async () => 2;\nexport { GET, POST };\n",
+ "/api/local",
+ {"GET", "POST"}},
+ {long_file, "export function GET() {}\n", long_path, {"GET"}},
+ };
+ for (size_t c = 0; c < sizeof(cases) / sizeof(cases[0]); c++) {
+ CBMLanguage lang = strstr(cases[c].file, ".js") ? CBM_LANG_JAVASCRIPT : CBM_LANG_TYPESCRIPT;
+ CBMFileResult *r = extract(cases[c].src, lang, "t", cases[c].file);
+ ASSERT_NOT_NULL(r);
+ ASSERT_FALSE(r->has_error);
+ int routed = 0;
+ for (int i = 0; i < r->defs.count; i++) {
+ routed += r->defs.items[i].route_path != NULL;
+ }
+ int want = 0;
+ for (; want < CBM_SZ_8 && cases[c].names[want]; want++) {
+ const CBMDefinition *d = nextjs_only_def(r, cases[c].names[want]);
+ ASSERT_NOT_NULL(d);
+ ASSERT_STR_EQ(d->label, "Function");
+ ASSERT_STR_EQ(d->file_path, cases[c].file);
+ ASSERT_NOT_NULL(d->route_path);
+ ASSERT_STR_EQ(d->route_path, cases[c].path);
+ ASSERT_STR_EQ(d->route_method, cases[c].names[want]);
+ }
+ ASSERT_EQ(routed, want);
+ cbm_free_result(r);
+ }
+ PASS();
+}
+
+/* #759: nothing else routes. Not a route file, or a directory the route path
+ * cannot spell -- an optional catch-all, a private folder, a parallel slot,
+ * an intercepting route, a malformed bracket, a workspace package root, a path
+ * past 255 bytes. Not a runtime export of an HTTP verb Function of this file:
+ * an unexported, default, type-only or nested GET, a class method, a
+ * constant, a lower-case verb; and no handler is made up for a renamed,
+ * re-exported, wrapped or destructured export, or a `function` expression
+ * bound to a const: none of them has a Function of its own here. */
+TEST(extract_nextjs_rejects_nonroutes_issue759) {
+ char long_file[CBM_SZ_512];
+ char segment[CBM_SZ_256];
+ memset(segment, 'x', CBM_SZ_256 - SKIP_ONE);
+ segment[CBM_SZ_256 - SKIP_ONE] = '\0';
+ snprintf(long_file, sizeof(long_file), "app/%s/route.ts", segment);
+ const char *files[] = {
+ "pages/api/route.ts",
+ "app/api/page.ts",
+ "app/api/route.test.ts",
+ "app/api/view/route.tsx",
+ "app/api/view/route.jsx",
+ "app/api/module/route.mjs",
+ "app/_private/route.ts",
+ "src/app/api/_lib/route.ts",
+ "app/@modal/route.ts",
+ "app/(.)photo/route.ts",
+ "app/(..)(..)photo/route.ts",
+ "app/api/[[...opt]]/route.ts",
+ "app/api/[broken/route.ts",
+ "app/api/broken]/route.ts",
+ "app/api/[]/route.ts",
+ "app/api/[...]/route.ts",
+ "app/api/a[id]/route.ts",
+ "app/()/route.ts",
+ "apps/web/app/api/route.ts",
+ long_file,
+ };
+ const struct {
+ const char *file;
+ const char *src;
+ } sources[] = {
+ {"app/api/nonexports/route.ts", "function GET() {}\n"
+ "export default function POST() {}\n"
+ "function PUT() {}\n"
+ "export type { PUT };\n"
+ "function OPTIONS() {}\n"
+ "export { type OPTIONS };\n"
+ "export class Handlers { PATCH() {} }\n"
+ "export const DELETE = 42;\n"
+ "export function get() {}\n"
+ "export function helper() { function HEAD() {} }\n"},
+ {"app/api/bindings/route.ts", "const handler = async () => 1;\n"
+ "export { handler as GET };\n"
+ "export { POST } from './impl';\n"
+ "export const PUT = wrap(handler);\n"
+ "export const DELETE = function () {};\n"
+ "export const { PATCH } = handlers;\n"
+ "export const HEAD = handler as Handler;\n"
+ "export const OPTIONS = (async () => 1) satisfies Handler;\n"
+ "export * from './all';\n"},
+ };
+ const int file_count = (int)(sizeof(files) / sizeof(files[0]));
+ const int source_count = (int)(sizeof(sources) / sizeof(sources[0]));
+ for (int c = 0; c < file_count + source_count; c++) {
+ bool by_file = c < file_count;
+ const char *file = by_file ? files[c] : sources[c - file_count].file;
+ CBMFileResult *r =
+ extract(by_file ? "export function GET() {}\n" : sources[c - file_count].src,
+ CBM_LANG_TYPESCRIPT, "t", file);
+ ASSERT_NOT_NULL(r);
+ ASSERT_FALSE(r->has_error);
+ if (by_file) {
+ ASSERT_NOT_NULL(nextjs_only_def(r, "GET"));
+ }
+ for (int i = 0; i < r->defs.count; i++) {
+ ASSERT_NULL(r->defs.items[i].route_path);
+ }
+ cbm_free_result(r);
+ }
+ PASS();
+}
+
/* Return the file's Module definition (extraction pushes it first), or NULL. */
static const CBMDefinition *find_module_def(CBMFileResult *r) {
for (int i = 0; i < r->defs.count; i++) {
@@ -13434,6 +13605,8 @@ SUITE(extraction) {
RUN_TEST(extract_java_jaxrs_empty_path_means_class_path);
RUN_TEST(extract_java_spring_relative_string_not_route_path);
RUN_TEST(extract_ts_nestjs_controller_routes_issue1428);
+ RUN_TEST(extract_nextjs_route_metadata_contract_issue759);
+ RUN_TEST(extract_nextjs_rejects_nonroutes_issue759);
RUN_TEST(extract_blazor_page_directive_routes_component);
RUN_TEST(extract_blazor_component_without_page_has_no_route);
RUN_TEST(extract_razor_page_directive_routes_cshtml_view);
diff --git a/tests/test_pipeline.c b/tests/test_pipeline.c
index bd76775f3..060e87022 100644
--- a/tests/test_pipeline.c
+++ b/tests/test_pipeline.c
@@ -18874,6 +18874,423 @@ TEST(pipeline_semantic_version_3_index_is_rebuilt_in_full_c1) {
PASS();
}
+/* #759: index a Next.js App Router tree as project "nextjs" (a full index, or
+ * the incremental route a stored index of the same tree takes). */
+static int nextjs_index(const char *repo, const char *db_path) {
+ cbm_pipeline_t *p = cbm_pipeline_new(repo, db_path, CBM_MODE_FULL);
+ if (!p) {
+ return -1;
+ }
+ (void)cbm_pipeline_set_project_name(p, "nextjs");
+ int rc = cbm_pipeline_run(p);
+ cbm_pipeline_free(p);
+ return rc;
+}
+
+/* Every Route of a stored index with each handler that HANDLES it, one sorted
+ * line each: "METHOD path route_qn file_path handler_qn". A Route no handler
+ * reaches ends in "-". The properties are parsed (json_extract): a Route not
+ * from route metadata is marked "!source", a handler declared in another file
+ * "!file", a HANDLES edge whose handler property is not its handler's QN
+ * "!handler"; malformed JSON fails the query. */
+static bool nextjs_route_tuples(const char *db_path, char *out, size_t sz) {
+ sqlite3 *db = NULL;
+ sqlite3_stmt *st = NULL;
+ bool ok = false;
+ if (sqlite3_open_v2(db_path, &db, SQLITE_OPEN_READONLY, NULL) == SQLITE_OK &&
+ sqlite3_prepare_v2(
+ db,
+ "SELECT coalesce(group_concat(t, char(10)), '') FROM (SELECT "
+ "json_extract(r.properties,'$.method') || ' ' || r.name || ' ' || r.qualified_name || "
+ "' ' || r.file_path || ' ' || coalesce(h.qualified_name, '-') || CASE WHEN "
+ "json_extract(r.properties,'$.source') = 'decorator' THEN '' ELSE ' !source' END || "
+ "CASE WHEN h.id IS NULL OR h.file_path = r.file_path THEN '' ELSE ' !file' END || "
+ "CASE WHEN e.id IS NULL OR json_extract(e.properties,'$.handler') = h.qualified_name "
+ "THEN '' ELSE ' !handler' END AS t FROM nodes r LEFT JOIN edges e ON "
+ "e.target_id=r.id AND e.type='HANDLES' LEFT JOIN nodes h ON h.id=e.source_id WHERE "
+ "r.label='Route' ORDER BY t)",
+ -1, &st, NULL) == SQLITE_OK &&
+ sqlite3_step(st) == SQLITE_ROW) {
+ snprintf(out, sz, "%s", (const char *)sqlite3_column_text(st, 0));
+ ok = true;
+ }
+ sqlite3_finalize(st);
+ sqlite3_close(db);
+ return ok;
+}
+
+static int nextjs_by_qn(const void *a, const void *b) {
+ return strcmp(((const cbm_search_result_t *)a)->node.qualified_name,
+ ((const cbm_search_result_t *)b)->node.qualified_name);
+}
+
+/* The Routes a search by label Route and declaring-file glob finds, one
+ * "qualified_name file_path" line each in QN order. */
+static bool nextjs_found_routes(const char *db_path, const char *glob, char *out, size_t sz) {
+ cbm_store_t *s = cbm_store_open_path_existing(db_path);
+ if (!s) {
+ return false;
+ }
+ cbm_search_params_t params = {.project = "nextjs",
+ .label = "Route",
+ .file_pattern = glob,
+ .min_degree = -1,
+ .max_degree = -1,
+ .limit = 100};
+ cbm_search_output_t res = {0};
+ bool ok = cbm_store_search(s, &params, &res) == CBM_STORE_OK;
+ if (ok && res.count > 1) {
+ qsort(res.results, (size_t)res.count, sizeof(res.results[0]), nextjs_by_qn);
+ }
+ size_t len = 0;
+ out[0] = '\0';
+ for (int i = 0; ok && i < res.count; i++) {
+ int n = snprintf(out + len, sz - len, "%s%s %s", i ? "\n" : "",
+ res.results[i].node.qualified_name, res.results[i].node.file_path);
+ ok = n >= 0 && (size_t)n < sz - len;
+ len += ok ? (size_t)n : 0;
+ }
+ cbm_store_search_free(&res);
+ cbm_store_close(s);
+ return ok;
+}
+
+/* One index of a Next.js tree: its result, the route it took and the stored
+ * Routes after it (nextjs_route_tuples). */
+typedef struct {
+ int rc;
+ cbm_incremental_route_t route;
+ bool read;
+ char tuples[1024];
+} nextjs_run_t;
+
+static void nextjs_run(const char *repo, const char *db_path, nextjs_run_t *run) {
+ run->rc = nextjs_index(repo, db_path);
+ run->route = cbm_pipeline_incremental_test_last_route();
+ run->read = nextjs_route_tuples(db_path, run->tuples, sizeof(run->tuples));
+}
+
+/* #759: the HTTP verb Functions a Next.js route file exports HANDLE the Routes
+ * its directories name, in the stored graph: a dynamic segment, a group, a
+ * catch-all and the root, under src/app/ and app/. Each Route is there once,
+ * with its file, from its own handler, whose HANDLES property is its QN. A
+ * search by label Route and the declaring file's glob finds them. `fillers`
+ * more files put the index on the parallel extraction path. */
+static int nextjs_persisted_contract(int fillers) {
+ char tmp[256];
+ snprintf(tmp, sizeof(tmp), "/tmp/cbm_nextjs_routes_XXXXXX");
+ ASSERT_NOT_NULL(cbm_mkdtemp(tmp));
+ for (int i = 0; i < fillers; i++) {
+ char name[64];
+ char body[128];
+ snprintf(name, sizeof(name), "lib/filler%d.ts", i);
+ snprintf(body, sizeof(body), "export function filler%d(): number {\n return %d;\n}\n", i,
+ i);
+ write_temp_file(tmp, name, body);
+ }
+ write_temp_file(tmp, "src/app/api/users/[id]/route.ts",
+ "export function GET() {\n return 1;\n}\n"
+ "export const POST = async () => 1;\n");
+ write_temp_file(tmp, "src/app/(public)/api/[org]/users/[id]/route.ts",
+ "export async function GET() {\n return 2;\n}\n");
+ write_temp_file(tmp, "app/api/[...slug]/route.ts", "export function GET() {\n return 3;\n}\n");
+ write_temp_file(tmp, "app/route.js", "export function GET() {\n return 4;\n}\n");
+ char db_path[512];
+ snprintf(db_path, sizeof(db_path), "%s/nextjs.db", tmp);
+
+ char *old_workers = getenv("CBM_WORKERS");
+ char *saved = old_workers ? strdup(old_workers) : NULL;
+ if (fillers > 0) {
+ cbm_setenv("CBM_WORKERS", "4", 1);
+ }
+ nextjs_run_t full;
+ nextjs_run(tmp, db_path, &full);
+ if (saved) {
+ cbm_setenv("CBM_WORKERS", saved, 1);
+ free(saved);
+ } else {
+ cbm_unsetenv("CBM_WORKERS");
+ }
+ char found[1024];
+ bool searched =
+ nextjs_found_routes(db_path, "src/app/api/users/*/route.ts", found, sizeof(found));
+ th_rmtree(tmp);
+
+ ASSERT_EQ(full.rc, 0);
+ ASSERT_TRUE(full.read);
+ ASSERT_STR_EQ(
+ full.tuples,
+ "GET / __route__GET__/ app/route.js nextjs.app.route.GET\n"
+ "GET /api/*slug __route__GET__/api/*slug app/api/[...slug]/route.ts "
+ "nextjs.app.api.[...slug].route.GET\n"
+ "GET /api/:org/users/:id __route__GET__/api/{}/users/{} "
+ "src/app/(public)/api/[org]/users/[id]/route.ts "
+ "nextjs.src.app.(public).api.[org].users.[id].route.GET\n"
+ "GET /api/users/:id __route__GET__/api/users/{} src/app/api/users/[id]/route.ts "
+ "nextjs.src.app.api.users.[id].route.GET\n"
+ "POST /api/users/:id __route__POST__/api/users/{} src/app/api/users/[id]/route.ts "
+ "nextjs.src.app.api.users.[id].route.POST");
+ ASSERT_TRUE(searched);
+ ASSERT_STR_EQ(found, "__route__GET__/api/users/{} src/app/api/users/[id]/route.ts\n"
+ "__route__POST__/api/users/{} src/app/api/users/[id]/route.ts");
+ PASS();
+}
+
+TEST(pipeline_nextjs_persisted_route_contract_issue759) {
+ return nextjs_persisted_contract(0);
+}
+
+TEST(pipeline_nextjs_persisted_route_contract_parallel_issue759) {
+ return nextjs_persisted_contract(52);
+}
+
+/* #759 over the life of a route file. Each step re-indexes the stored graph;
+ * after each, the file's current handlers are its only Routes, each once, and
+ * an unrelated route file keeps its Route. An unchanged tree is a no-op, and a
+ * change to another file rebuilds the unchanged route files' Routes from their
+ * stored handlers (pass_route_nodes.c), which a search still finds. */
+TEST(pipeline_nextjs_incremental_lifecycle_issue759) {
+ char tmp[256];
+ snprintf(tmp, sizeof(tmp), "/tmp/cbm_nextjs_life_XXXXXX");
+ ASSERT_NOT_NULL(cbm_mkdtemp(tmp));
+ write_temp_file(tmp, "app/api/items/route.ts",
+ "export function GET() {\n return 1;\n}\n"
+ "export async function POST() {\n return 2;\n}\n");
+ write_temp_file(tmp, "app/api/health/route.ts", "export const GET = () => 'ok';\n");
+ write_temp_file(tmp, "lib/helper.ts", "export function helper(): number {\n return 1;\n}\n");
+ char db_path[512];
+ snprintf(db_path, sizeof(db_path), "%s/nextjs.db", tmp);
+
+ nextjs_run_t full;
+ nextjs_run(tmp, db_path, &full);
+ nextjs_run_t same;
+ nextjs_run(tmp, db_path, &same);
+ char found_same[1024];
+ bool searched_same =
+ nextjs_found_routes(db_path, "app/api/*/route.ts", found_same, sizeof(found_same));
+
+ write_temp_file(tmp, "lib/helper.ts", "export function helper(): number {\n return 2;\n}\n");
+ nextjs_run_t helper_only;
+ nextjs_run(tmp, db_path, &helper_only);
+ char found_repair[1024];
+ bool searched_repair =
+ nextjs_found_routes(db_path, "app/api/*/route.ts", found_repair, sizeof(found_repair));
+
+ write_temp_file(tmp, "app/api/items/route.ts", "export function GET() {\n return 1;\n}\n");
+ nextjs_run_t no_post;
+ nextjs_run(tmp, db_path, &no_post);
+
+ write_temp_file(tmp, "app/api/items/route.ts",
+ "export function GET() {\n const n = 10;\n return n;\n}\n");
+ nextjs_run_t new_body;
+ nextjs_run(tmp, db_path, &new_body);
+
+ write_temp_file(tmp, "app/api/items/route.ts", "export function PATCH() {\n return 3;\n}\n");
+ nextjs_run_t patch;
+ nextjs_run(tmp, db_path, &patch);
+
+ write_temp_file(tmp, "app/api/products/route.ts",
+ "export function PATCH() {\n return 3;\n}\n");
+ stem_unlink(tmp, "app/api/items/route.ts");
+ nextjs_run_t moved;
+ nextjs_run(tmp, db_path, &moved);
+
+ write_temp_file(tmp, "app/api/products/[id]/route.ts",
+ "export function PATCH() {\n return 3;\n}\n");
+ stem_unlink(tmp, "app/api/products/route.ts");
+ nextjs_run_t dynamic;
+ nextjs_run(tmp, db_path, &dynamic);
+
+ stem_unlink(tmp, "app/api/products/[id]/route.ts");
+ nextjs_run_t deleted;
+ nextjs_run(tmp, db_path, &deleted);
+ th_rmtree(tmp);
+
+ static const char health[] = "GET /api/health __route__GET__/api/health "
+ "app/api/health/route.ts nextjs.app.api.health.route.GET";
+ static const char routes[] = "GET /api/health __route__GET__/api/health "
+ "app/api/health/route.ts nextjs.app.api.health.route.GET\n"
+ "GET /api/items __route__GET__/api/items app/api/items/route.ts "
+ "nextjs.app.api.items.route.GET\n"
+ "POST /api/items __route__POST__/api/items app/api/items/route.ts "
+ "nextjs.app.api.items.route.POST";
+ static const char get_only[] = "GET /api/health __route__GET__/api/health "
+ "app/api/health/route.ts nextjs.app.api.health.route.GET\n"
+ "GET /api/items __route__GET__/api/items app/api/items/route.ts "
+ "nextjs.app.api.items.route.GET";
+ ASSERT_EQ(full.rc, 0);
+ ASSERT_TRUE(full.read);
+ ASSERT_STR_EQ(full.tuples, routes);
+ ASSERT_EQ(same.rc, 0);
+ ASSERT_EQ(same.route, CBM_INCREMENTAL_ROUTE_NOOP);
+ ASSERT_STR_EQ(same.tuples, routes);
+ ASSERT_TRUE(searched_same);
+ ASSERT_STR_EQ(found_same, "__route__GET__/api/health app/api/health/route.ts\n"
+ "__route__GET__/api/items app/api/items/route.ts\n"
+ "__route__POST__/api/items app/api/items/route.ts");
+ ASSERT_EQ(helper_only.rc, 0);
+ ASSERT_EQ(helper_only.route, CBM_INCREMENTAL_ROUTE_CLOSURE_REPAIR);
+ ASSERT_STR_EQ(helper_only.tuples, routes);
+ ASSERT_TRUE(searched_repair);
+ ASSERT_STR_EQ(found_repair, found_same);
+ ASSERT_EQ(no_post.rc, 0);
+ ASSERT_EQ(no_post.route, CBM_INCREMENTAL_ROUTE_CLOSURE_REPAIR);
+ ASSERT_STR_EQ(no_post.tuples, get_only);
+ ASSERT_EQ(new_body.rc, 0);
+ ASSERT_EQ(new_body.route, CBM_INCREMENTAL_ROUTE_CLOSURE_REPAIR);
+ ASSERT_STR_EQ(new_body.tuples, get_only);
+ ASSERT_EQ(patch.rc, 0);
+ ASSERT_STR_EQ(patch.tuples, "GET /api/health __route__GET__/api/health "
+ "app/api/health/route.ts nextjs.app.api.health.route.GET\n"
+ "PATCH /api/items __route__PATCH__/api/items "
+ "app/api/items/route.ts nextjs.app.api.items.route.PATCH");
+ ASSERT_EQ(moved.rc, 0);
+ ASSERT_STR_EQ(moved.tuples, "GET /api/health __route__GET__/api/health "
+ "app/api/health/route.ts nextjs.app.api.health.route.GET\n"
+ "PATCH /api/products __route__PATCH__/api/products "
+ "app/api/products/route.ts nextjs.app.api.products.route.PATCH");
+ ASSERT_EQ(dynamic.rc, 0);
+ ASSERT_STR_EQ(dynamic.tuples,
+ "GET /api/health __route__GET__/api/health "
+ "app/api/health/route.ts nextjs.app.api.health.route.GET\n"
+ "PATCH /api/products/:id __route__PATCH__/api/products/{} "
+ "app/api/products/[id]/route.ts nextjs.app.api.products.[id].route.PATCH");
+ ASSERT_EQ(deleted.rc, 0);
+ ASSERT_STR_EQ(deleted.tuples, health);
+ PASS();
+}
+
+/* CBM_SEMANTIC_INDEX_VERSION 10 (#759): an index version 9 wrote has no route
+ * metadata, Route or HANDLES for a Next.js route file, and an unchanged tree
+ * is otherwise a no-op, so the version is what makes the new binary rebuild
+ * it. The stored index is put back to the version-9 state by hand (metadata,
+ * the handlers' route properties, the Routes and their edges); the run after
+ * that must replace it in full, the next one is a no-op. */
+TEST(pipeline_nextjs_semantic_upgrade_issue759) {
+ char tmp[256];
+ snprintf(tmp, sizeof(tmp), "/tmp/cbm_nextjs_upgrade_XXXXXX");
+ ASSERT_NOT_NULL(cbm_mkdtemp(tmp));
+ write_temp_file(tmp, "app/api/items/route.ts",
+ "export function GET() {\n return 1;\n}\n"
+ "export const POST = async () => 2;\n");
+ write_temp_file(tmp, "lib/helper.ts", "export function helper(): number {\n return 1;\n}\n");
+ char db_path[512];
+ snprintf(db_path, sizeof(db_path), "%s/nextjs.db", tmp);
+ static const char all_nodes[] = "SELECT COUNT(*) FROM nodes";
+ static const char all_edges[] = "SELECT COUNT(*) FROM edges";
+ static const char routed[] =
+ "SELECT COUNT(*) FROM nodes WHERE json_extract(properties,'$.route_path') IS NOT NULL";
+
+ nextjs_run_t full;
+ nextjs_run(tmp, db_path, &full);
+ int nodes_before = k8s_inc_count(db_path, all_nodes);
+ int edges_before = k8s_inc_count(db_path, all_edges);
+
+ /* Put the published index back to what version 9 wrote. */
+ cbm_store_t *store = cbm_store_open_path(db_path);
+ ASSERT_NOT_NULL(store);
+ cbm_coverage_row_t *coverage_rows = NULL;
+ int coverage_count = 0;
+ ASSERT_EQ(cbm_store_coverage_get(store, "nextjs", &coverage_rows, &coverage_count),
+ CBM_STORE_OK);
+ cbm_coverage_meta_t meta = {0};
+ ASSERT_EQ(cbm_store_coverage_meta_get(store, "nextjs", &meta), CBM_STORE_OK);
+ cbm_coverage_meta_t old_meta = meta;
+ old_meta.coverage_version = 9;
+ ASSERT_EQ(
+ cbm_store_coverage_replace_ex(store, "nextjs", coverage_rows, coverage_count, &old_meta),
+ CBM_STORE_OK);
+ cbm_store_free_coverage(coverage_rows, coverage_count);
+ cbm_store_coverage_meta_clear(&meta);
+ ASSERT_EQ(cbm_store_exec(store,
+ "DELETE FROM edges WHERE source_id IN (SELECT id FROM nodes WHERE "
+ "label = 'Route') OR target_id IN (SELECT id FROM nodes WHERE "
+ "label = 'Route');"
+ "DELETE FROM nodes WHERE label = 'Route';"
+ "UPDATE nodes SET properties = json_remove(properties, "
+ "'$.route_path', '$.route_method') "
+ "WHERE json_extract(properties, '$.route_path') IS NOT NULL;"),
+ CBM_STORE_OK);
+ cbm_store_close(store);
+ nextjs_run_t version_9 = {0};
+ version_9.read = nextjs_route_tuples(db_path, version_9.tuples, sizeof(version_9.tuples));
+ int routed_9 = k8s_inc_count(db_path, routed);
+
+ /* Nothing in the tree changed: only the version says the index is stale. */
+ nextjs_run_t upgrade;
+ nextjs_run(tmp, db_path, &upgrade);
+ int nodes_after = k8s_inc_count(db_path, all_nodes);
+ int edges_after = k8s_inc_count(db_path, all_edges);
+ int routed_after = k8s_inc_count(db_path, routed);
+ store = cbm_store_open_path(db_path);
+ ASSERT_NOT_NULL(store);
+ cbm_coverage_meta_t new_meta = {0};
+ ASSERT_EQ(cbm_store_coverage_meta_get(store, "nextjs", &new_meta), CBM_STORE_OK);
+ int stored_version = new_meta.coverage_version;
+ cbm_store_coverage_meta_clear(&new_meta);
+ cbm_store_close(store);
+ nextjs_run_t again;
+ nextjs_run(tmp, db_path, &again);
+ th_rmtree(tmp);
+
+ ASSERT_EQ(full.rc, 0);
+ ASSERT_STR_EQ(full.tuples, "GET /api/items __route__GET__/api/items app/api/items/route.ts "
+ "nextjs.app.api.items.route.GET\n"
+ "POST /api/items __route__POST__/api/items app/api/items/route.ts "
+ "nextjs.app.api.items.route.POST");
+ ASSERT_TRUE(version_9.read);
+ ASSERT_STR_EQ(version_9.tuples, "");
+ ASSERT_EQ(routed_9, 0);
+ ASSERT_EQ(upgrade.rc, 0);
+ ASSERT_EQ(upgrade.route, CBM_INCREMENTAL_ROUTE_FORCED_FULL);
+ ASSERT_STR_EQ(upgrade.tuples, full.tuples);
+ ASSERT_EQ(routed_after, 2);
+ ASSERT_EQ(nodes_after, nodes_before);
+ ASSERT_EQ(edges_after, edges_before);
+ ASSERT_EQ(stored_version, CBM_SEMANTIC_INDEX_VERSION);
+ ASSERT_EQ(again.rc, 0);
+ ASSERT_EQ(again.route, CBM_INCREMENTAL_ROUTE_NOOP);
+ ASSERT_STR_EQ(again.tuples, full.tuples);
+ ASSERT_GTE(CBM_SEMANTIC_INDEX_VERSION, 10);
+ PASS();
+}
+
+/* #759: a quote is legal in a POSIX directory name, so a route path, its file
+ * and its handler's QN can hold one, escaped in the stored JSON. The route pass
+ * builds the Route from its handler's stored properties on every index
+ * (pass_route_nodes.c), so the full index and an incremental one after an
+ * unrelated edit must both store it intact. */
+TEST(pipeline_nextjs_quoted_route_round_trip_issue759) {
+#ifdef _WIN32
+ SKIP_PLATFORM("a quote is not a legal Windows path character");
+#else
+ char tmp[256];
+ snprintf(tmp, sizeof(tmp), "/tmp/cbm_nextjs_quote_XXXXXX");
+ ASSERT_NOT_NULL(cbm_mkdtemp(tmp));
+ write_temp_file(tmp, "app/api/a\"b/route.ts", "export function GET() {\n return 1;\n}\n");
+ write_temp_file(tmp, "lib/helper.ts", "export function helper(): number {\n return 1;\n}\n");
+ char db_path[512];
+ snprintf(db_path, sizeof(db_path), "%s/nextjs.db", tmp);
+
+ nextjs_run_t full;
+ nextjs_run(tmp, db_path, &full);
+ write_temp_file(tmp, "lib/helper.ts", "export function helper(): number {\n return 2;\n}\n");
+ nextjs_run_t helper_only;
+ nextjs_run(tmp, db_path, &helper_only);
+ th_rmtree(tmp);
+
+ ASSERT_EQ(full.rc, 0);
+ ASSERT_TRUE(full.read);
+ ASSERT_STR_EQ(full.tuples, "GET /api/a\"b __route__GET__/api/a\"b app/api/a\"b/route.ts "
+ "nextjs.app.api.a\"b.route.GET");
+ ASSERT_EQ(helper_only.rc, 0);
+ ASSERT_EQ(helper_only.route, CBM_INCREMENTAL_ROUTE_CLOSURE_REPAIR);
+ ASSERT_TRUE(helper_only.read);
+ ASSERT_STR_EQ(helper_only.tuples, full.tuples);
+ PASS();
+#endif
+}
+
/* `#include <linux/device.h>` from arch/x/bugs.c: two headers end with the
* include path (include/linux/device.h, tools/virtio/linux/device.h) and each
* declares `struct device`. The exact-file lookup returned the first matching
@@ -27771,6 +28188,11 @@ SUITE(pipeline) {
RUN_TEST(pipeline_c_variants_on_sequential_and_parallel_paths_c1);
RUN_TEST(pipeline_cpp_overloads_are_listed_as_variants_c1);
RUN_TEST(pipeline_semantic_version_3_index_is_rebuilt_in_full_c1);
+ RUN_TEST(pipeline_nextjs_persisted_route_contract_issue759);
+ RUN_TEST(pipeline_nextjs_persisted_route_contract_parallel_issue759);
+ RUN_TEST(pipeline_nextjs_incremental_lifecycle_issue759);
+ RUN_TEST(pipeline_nextjs_semantic_upgrade_issue759);
+ RUN_TEST(pipeline_nextjs_quoted_route_round_trip_issue759);
RUN_TEST(pipeline_python_app_factory_routes_issue1548);
RUN_TEST(pipeline_python_nested_def_is_function_local_issue1548);
RUN_TEST(pipeline_python_local_classes_stay_in_their_def_issue1548);