Local code intelligence for developers and AI agents. Connect code, docs and infrastructure in a persistent graph, with CBM Lens, MCP tools, agent integrations and change-aware test selection.
C aiderastclaude-codecode-analysiscode-intelligencecodexcursorcypherdeveloper-toolsgemini-cligraph-visualizationkilocodeknowledge-graphmcpmcp-servermodel-context-protocolopencodesqlitetree-sitterwindsurf
fix(mcp): release path filters on search setup errors
Martin Vogelfe8dd9df7e90
diff --git a/src/mcp/mcp.c b/src/mcp/mcp.cindex c877d5110..7e1463f01 100644--- a/src/mcp/mcp.c+++ b/src/mcp/mcp.c@@ -14984,6 +14984,9 @@ static char *handle_search_code(cbm_mcp_server_t *srv, const char *args) {path_filter = NULL;if (!pattern) {+ if (has_path_filter) {+ cbm_regfree(&path_regex);+ }free(project);free(file_pattern);return cbm_mcp_text_result("pattern is required", true);@@ -14991,6 +14994,9 @@ static char *handle_search_code(cbm_mcp_server_t *srv, const char *args) {/* Project is required */if (!project) {+ if (has_path_filter) {+ cbm_regfree(&path_regex);+ }free(pattern);free(file_pattern);char *_err = build_project_list_error("project is required");@@ -15001,6 +15007,9 @@ static char *handle_search_code(cbm_mcp_server_t *srv, const char *args) {char *root_path = get_project_root(srv, project);if (!root_path) {+ if (has_path_filter) {+ cbm_regfree(&path_regex);+ }free(pattern);free(project);free(file_pattern);@@ -15094,6 +15103,9 @@ static char *handle_search_code(cbm_mcp_server_t *srv, const char *args) {char errmsg[CBM_SZ_256];snprintf(errmsg, sizeof(errmsg), "search failed: cannot create temp file (%s)",strerror(errno));+ if (has_path_filter) {+ cbm_regfree(&path_regex);+ }free(root_path);free(pattern);free(project);diff --git a/tests/test_mcp.c b/tests/test_mcp.cindex 22af972af..63f987fe8 100644--- a/tests/test_mcp.c+++ b/tests/test_mcp.c@@ -9045,6 +9045,41 @@ TEST(tool_search_code_no_project) {PASS();}+/* search_code compiles path_filter into a regex before it checks pattern,+ * project and the project root. Every one of those early error returns must+ * release the compiled regex. The leak itself is only visible to a leak+ * detector such as LeakSanitizer, so this test drives each return with a valid+ * path_filter and asserts the error taken. */+TEST(search_code_early_errors_release_path_filter_regex) {+ cbm_mcp_server_t *srv = cbm_mcp_server_new(NULL);+ ASSERT_NOT_NULL(srv);++ /* No pattern. */+ char *resp = cbm_mcp_handle_tool(+ srv, "search_code", "{\"project\":\"nonexistent\",\"path_filter\":\"^cbm_leak_probe/\"}");+ bool pattern_error = resp && strstr(resp, "pattern is required") != NULL;+ free(resp);++ /* No project. */+ resp = cbm_mcp_handle_tool(srv, "search_code",+ "{\"pattern\":\"main\",\"path_filter\":\"^cbm_leak_probe/\"}");+ bool project_error = resp && strstr(resp, "project is required") != NULL;+ free(resp);++ /* Unknown project, with a file_pattern alongside the path filter. */+ resp = cbm_mcp_handle_tool(srv, "search_code",+ "{\"pattern\":\"main\",\"project\":\"nonexistent\","+ "\"file_pattern\":\"*.c\",\"path_filter\":\"^cbm_leak_probe/\"}");+ bool root_error = resp && strstr(resp, "project not found or not indexed") != NULL;+ free(resp);++ cbm_mcp_server_free(srv);+ ASSERT_TRUE(pattern_error);+ ASSERT_TRUE(project_error);+ ASSERT_TRUE(root_error);+ PASS();+}+TEST(search_code_multi_word) {char tmp[512];cbm_mcp_server_t *srv = setup_snippet_server(tmp, sizeof(tmp));@@ -21203,6 +21238,7 @@ SUITE(mcp) {RUN_TEST(tool_search_code_limit_declares_a_minimum_issue1511);RUN_TEST(tool_search_code_declares_independent_result_and_raw_content_paging);RUN_TEST(tool_search_code_no_project);+ RUN_TEST(search_code_early_errors_release_path_filter_regex);RUN_TEST(search_code_multi_word);RUN_TEST(search_code_full_preserves_utf8_source);RUN_TEST(search_code_raw_match_preserves_utf8_content);