graff — a fast agentic coding harness in Zig: multi-provider, MCP, workflows, DGM evolution loop, TS/Python SDKs
Python
Retry unreceived composer clicks in shutdown fixture
Rach Pradhan2164089cddcc
diff --git a/apps/native/electron/smoke-server-lifecycle.cjs b/apps/native/electron/smoke-server-lifecycle.cjsindex 7014ef9f..45841f39 100644--- a/apps/native/electron/smoke-server-lifecycle.cjs+++ b/apps/native/electron/smoke-server-lifecycle.cjs@@ -52,11 +52,57 @@ exports.run = async ({win, backend}) => {}throw Error('Shutdown fixture Send click did not reach its button');}+ let skipFirstComposerClick = process.env.GRAFF_SHUTDOWN_SKIP_FIRST_COMPOSER_CLICK === '1';+ async function focusComposer() {+ // A hidden macOS window can report a visible hit point while Chromium+ // drops the first trusted press. Retry only before any text was entered.+ const observations = [];+ for (let attempt = 0; attempt < 3; attempt++) {+ await js(`(() => {+ window.__shutdownComposerEvents={down:false,click:false};+ window.__shutdownComposerObserver=e=>{+ if(!e.isTrusted || !e.target?.closest?.('textarea[aria-label="Prompt"]'))return;+ window.__shutdownComposerEvents[e.type==='pointerdown'?'down':'click']=true;+ };+ document.addEventListener('pointerdown',window.__shutdownComposerObserver,true);+ document.addEventListener('click',window.__shutdownComposerObserver,true);+ })()`);+ try {+ if (skipFirstComposerClick) skipFirstComposerClick = false;+ else await click('textarea[aria-label="Prompt"]');+ const end = Date.now() + 1000;+ while (Date.now() < end) {+ const state = await js(`(() => {+ const e=document.querySelector('textarea[aria-label="Prompt"]');+ return {down:window.__shutdownComposerEvents.down,+ click:window.__shutdownComposerEvents.click,+ focused:document.activeElement===e};+ })()`);+ observations[attempt] = {attempt:attempt + 1,...state};+ if (state.down && state.click && state.focused) {+ fs.appendFileSync(path.join(output, 'composer-clicks.jsonl'), JSON.stringify(observations)+'\n');+ return;+ }+ await sleep(50);+ }+ } finally {+ await js(`(() => {+ document.removeEventListener('pointerdown',window.__shutdownComposerObserver,true);+ document.removeEventListener('click',window.__shutdownComposerObserver,true);+ })()`);+ }+ phase(`composer trusted click missed; retrying ${attempt + 1}`);+ }+ fs.appendFileSync(path.join(output, 'composer-clicks.jsonl'), JSON.stringify(observations)+'\n');+ await timeouts.dumpTimeout({ label: 'composer focus', waitedMs: 3000, outer, output, workspace, js,+ capturePage: () => win.webContents.capturePage().then(page => page.toPNG()),+ backendOrigin: backend.origin, writePhase: phase });+ throw Error('Shutdown fixture trusted composer click did not focus its textarea');+ }async function submit(text) {const ready = () => js(`document.querySelector('textarea[aria-label="Prompt"]').value === ${JSON.stringify(text)} && !document.querySelector('[aria-label="Send"]').disabled`);for (let attempt = 0; attempt < 2 && !(await ready()); attempt++) {- await click('textarea[aria-label="Prompt"]');- await until(() => js(`document.activeElement === document.querySelector('textarea[aria-label="Prompt"]')`), 'composer focus');+ await focusComposer();for (const keyCode of text) await desktop.testInput(win.webContents, {type:'char',keyCode});const end = Date.now() + 8000;while (Date.now() < end && !(await ready())) await sleep(50);diff --git a/apps/native/scripts/test-server-desktop.mjs b/apps/native/scripts/test-server-desktop.mjsindex 367d2430..33d70421 100644--- a/apps/native/scripts/test-server-desktop.mjs+++ b/apps/native/scripts/test-server-desktop.mjs@@ -16,6 +16,7 @@ const connects=port=>new Promise(resolve=>{const s=net.connect({host:'127.0.0.1'for(const pinned of [false,true]) {const temp=fs.mkdtempSync(path.join(os.tmpdir(),'graff-desktop-shutdown-')),out=path.join(output,pinned?'pinned':'automatic'),workspace=path.join(temp,'workspace'),resources=path.join(temp,'resources');for(const dir of [out,workspace,resources])fs.mkdirSync(dir,{recursive:true});+ fs.rmSync(path.join(out,'composer-clicks.jsonl'),{force:true});fs.cpSync(path.join(ui,'.next/standalone'),path.join(resources,'ui'),{recursive:true});fs.cpSync(path.join(ui,'electron'),path.join(resources,'app'),{recursive:true});fs.cpSync(path.join(ui,'.next/static'),path.join(resources,'ui/.next/static'),{recursive:true});@@ -26,7 +27,7 @@ for(const pinned of [false,true]) {fs.writeFileSync(path.join(workspace,'listener.py'),"import os,json,socket\nsocket.getfqdn=lambda *_: (_ for _ in ()).throw(RuntimeError('unexpected hostname lookup'))\nfrom pathlib import Path\nfrom http.server import HTTPServer,BaseHTTPRequestHandler\nfrom socketserver import TCPServer\nclass NumericHTTPServer(HTTPServer):\n def server_bind(self):\n TCPServer.server_bind(self)\n self.server_name,self.server_port=self.server_address[:2]\nclass Handler(BaseHTTPRequestHandler):\n def do_GET(self):\n print('request served',flush=True)\n self.send_response(200);self.end_headers();self.wfile.write(b'ready')\ns=NumericHTTPServer(('127.0.0.1',0),Handler)\nPath('listener.json').write_text(json.dumps({'pid':os.getpid(),'port':s.server_port}))\ns.serve_forever()\n");fs.writeFileSync(path.join(workspace,'ready.py'),"import json,time,urllib.request\nfrom pathlib import Path\nfor _ in range(100):\n if Path('listener.json').exists():break\n time.sleep(.05)\nr=json.loads(Path('listener.json').read_text());body=urllib.request.urlopen('http://127.0.0.1:'+str(r['port']),timeout=2).read();assert body==b'ready',body;print('HTTP response verified: ready')\n");const script=path.join(temp,'script.json'),mcp=path.join(temp,'mcp.json');fs.writeFileSync(mcp,'{"mcpServers":{}}');fs.writeFileSync(script,JSON.stringify([{tool:'bash',arguments:{command:'python3 listener.py',run_in_background:true}},{tool:'bash',arguments:{command:'python3 ready.py'}},{text:'Listener ready for shutdown.'}]));- const env={...process.env,HOME:temp,LMSTUDIO_API_KEY:'local',GRAFF_CWD:workspace,GRAFF_ELECTRON_RESOURCES:resources,GRAFF_ELECTRON_SMOKE:path.join(out,'smoke.json'),GRAFF_SMOKE_SERVER_LIFECYCLE:'1',GRAFF_SHUTDOWN_OUTPUT:out,GRAFF_SHUTDOWN_PIN:pinned?'1':'0',GRAFF_SMOKE_PROFILE:path.join(temp,'profile'),GRAFF_MCP_CONFIG:mcp,GRAFF_NO_TELEMETRY:'1',GRAFF_FLEET:'off',GRAFF_NO_SMOLIFY:'1',GRAFF_NO_CODEDB_GUARD:'1',GRAFF_AUTO_ISOLATE:'0',GRAFF_TEST_TIMEOUT_MS:process.env.GRAFF_TEST_TIMEOUT_MS||'180000'};+ const env={...process.env,HOME:temp,LMSTUDIO_API_KEY:'local',GRAFF_CWD:workspace,GRAFF_ELECTRON_RESOURCES:resources,GRAFF_ELECTRON_SMOKE:path.join(out,'smoke.json'),GRAFF_SMOKE_SERVER_LIFECYCLE:'1',GRAFF_SHUTDOWN_OUTPUT:out,GRAFF_SHUTDOWN_PIN:pinned?'1':'0',GRAFF_SHUTDOWN_SKIP_FIRST_COMPOSER_CLICK:pinned?'1':'0',GRAFF_SMOKE_PROFILE:path.join(temp,'profile'),GRAFF_MCP_CONFIG:mcp,GRAFF_NO_TELEMETRY:'1',GRAFF_FLEET:'off',GRAFF_NO_SMOLIFY:'1',GRAFF_NO_CODEDB_GUARD:'1',GRAFF_AUTO_ISOLATE:'0',GRAFF_TEST_TIMEOUT_MS:process.env.GRAFF_TEST_TIMEOUT_MS||'180000'};for(const key of Object.keys(env))if(key.endsWith('_API_KEY')&&key!=='LMSTUDIO_API_KEY')delete env[key];const fd=fs.openSync(path.join(out,'model.log'),'w'),model=spawn('python3',[path.join(repo,'scripts/eval/frontend_model.py'),'--script',script,'--requests',path.join(out,'requests.json')],{env,stdio:['ignore',fd,fd]});fs.closeSync(fd);const unrelated=net.createServer(s=>s.end());await new Promise(r=>unrelated.listen(0,'127.0.0.1',r));@@ -34,6 +35,9 @@ for(const pinned of [false,true]) {const end=Date.now()+10000;while(!fs.readFileSync(path.join(out,'model.log'),'utf8').includes('scripted model on')){assert(model.exitCode===null&&Date.now()<end,'fixture unavailable');await sleep(50)}process.env.GRAFF_TEST_TIMEOUT_MS=env.GRAFF_TEST_TIMEOUT_MS;assert.equal(await runDesktopProcess(require('electron'),[path.join(ui,'electron/server-lifecycle-entry.cjs')],env),0,'Electron fixture failed');+ const composerClicks=fs.readFileSync(path.join(out,'composer-clicks.jsonl'),'utf8').trim().split('\n').flatMap(line=>JSON.parse(line));+ assert(composerClicks.at(-1)?.down && composerClicks.at(-1)?.click && composerClicks.at(-1)?.focused,'trusted composer click was not observed');+ if(pinned)assert(composerClicks.some(row=>!row.down&&!row.click),'missed composer click did not exercise recovery');const replies=JSON.parse(fs.readFileSync(path.join(out,'requests.json'),'utf8')).flatMap(request=>request.messages||[]);assert(replies.some(message=>message.role==='tool'&&message.content==='HTTP response verified: ready\n'),'agent did not observe a successful HTTP check');const before=JSON.parse(fs.readFileSync(path.join(out,'before-quit.json'),'utf8'));