Skip to content

graff — a fast agentic coding harness in Zig: multi-provider, MCP, workflows, DGM evolution loop, TS/Python SDKs

Python

Observe sidebar collapse before tab drag checks

Rach Pradhanbcdb69872d89
diff --git a/apps/native/electron/navigation-visual.cjs b/apps/native/electron/navigation-visual.cjs
index add38fcc..6da33504 100644
--- a/apps/native/electron/navigation-visual.cjs
+++ b/apps/native/electron/navigation-visual.cjs
@@ -32,7 +32,7 @@ async function runNavigationVisuals({win:fixtureWindow,origin,output}) {
await wc.loadURL(origin);testDesktop.present(win);await wait(`!!document.querySelector('[data-workspace-ready="true"] textarea[aria-label="Prompt"]')`);
if(process.env.GRAFF_VISUAL_SUITE==='session-navigation'){await require('./session-navigation-visual.cjs').runSessionNavigation({win,origin,output});return;}
if(process.env.GRAFF_VISUAL_SUITE==='tagged'){await require('./yxlyx-regressions-visual.cjs').runYxlyxRegressions({win,origin});return;}
- if(process.env.GRAFF_VISUAL_SUITE==='tab-drag'){await js(`document.querySelector('[aria-label="Collapse sidebar"]').click()`);await wait(`!!document.querySelector('[data-session-navigation="tabs"]')`);await require('./tab-drag-visual.cjs').runTabDrag({win,origin,output});return;}
+ if(process.env.GRAFF_VISUAL_SUITE==='tab-drag'){await js(`document.querySelector('[aria-label="Collapse sidebar"]').click()`);await wait(`!!document.querySelector('[data-session-navigation="tabs"]')`);await require('./tab-drag-visual.cjs').runTabDrag({win,origin,output,injectMissedCollapseClick:true});return;}
if(process.env.GRAFF_VISUAL_SUITE==='keyboard'){await require('./navigation-keyboard-visual.cjs').runNavigationKeyboard({win,origin});return;}
if(process.env.GRAFF_VISUAL_SUITE==='splits'){await require('./split-focus-visual.cjs').runSplitFocus({win,origin,output});return;}
const interactions = async () => {
diff --git a/apps/native/electron/tab-drag-visual.cjs b/apps/native/electron/tab-drag-visual.cjs
index cbdb7c53..e302d63e 100644
--- a/apps/native/electron/tab-drag-visual.cjs
+++ b/apps/native/electron/tab-drag-visual.cjs
@@ -2,19 +2,42 @@ const desktop = require('./test-desktop.cjs');
const assert = require('node:assert/strict');
const fs = require('node:fs');
const path = require('node:path');
-async function runTabDrag({win, origin, output}) {
+async function runTabDrag({win, origin, output, injectMissedCollapseClick=false}) {
const wc=win.webContents, js=code=>wc.executeJavaScript(code);
desktop.attachTestDebugger(wc);
console.log('Host reduced motion:', await js(`matchMedia('(prefers-reduced-motion: reduce)').matches`));
// Both motion modes are explicit test inputs, independent of runner settings.
await wc.debugger.sendCommand('Emulation.setEmulatedMedia',{features:[{name:'prefers-reduced-motion',value:'no-preference'}]});
const wait=async code=>{for(let i=0;i<100;i++){if(await js(code))return;await new Promise(r=>setTimeout(r,50));}throw Error(`Tab drag condition failed: ${code}`);};
+ const collapseObservations=[];
+ let missedCollapseInjected=false;
const ready=async()=>{
await wait(`!!document.querySelector('[data-workspace-ready="true"] textarea[aria-label="Prompt"]')`);
// setSize returns before the responsive navigation has committed wide mode.
await wait(`innerWidth>=1024 && !!document.querySelector('[data-navigation-panel]:not([popover])')`);
- if(await js(`!!document.querySelector('[aria-label="Collapse sidebar"]')?.checkVisibility()`))await click('[aria-label="Collapse sidebar"]');
- await wait(`!!document.querySelector('[data-session-navigation="tabs"]')`);
+ const tabs=`!!document.querySelector('[data-session-navigation="tabs"]')`;
+ if(await js(tabs))return;
+ // A hidden Electron window can hit-test the collapse control before its
+ // trusted click is delivered. Observe delivery and retry only while the
+ // sidebar still owns navigation; never toggle an already-collapsed one.
+ for(let attempt=0;attempt<3;attempt++){
+ const expanded=await js(`!!document.querySelector('[aria-label="Collapse sidebar"]:not([aria-hidden="true"])')?.checkVisibility()`);
+ if(!expanded)break;
+ await js(`(()=>{window.__tabCollapseClick=false;window.__tabCollapseObserver=e=>{if(e.isTrusted&&e.target?.closest?.('[aria-label="Collapse sidebar"]'))window.__tabCollapseClick=true};document.addEventListener('click',window.__tabCollapseObserver,true)})()`);
+ const skipped=injectMissedCollapseClick&&!missedCollapseInjected;
+ if(skipped)missedCollapseInjected=true;
+ try{
+ if(!skipped)await click('[aria-label="Collapse sidebar"]');
+ const end=Date.now()+1000;
+ while(Date.now()<end&&!await js(tabs))await new Promise(r=>setTimeout(r,50));
+ const state={attempt:attempt+1,skipped,clicked:await js('window.__tabCollapseClick'),tabs:await js(tabs)};
+ collapseObservations.push(state);
+ fs.writeFileSync(path.join(output,'tab-navigation-readiness.json'),JSON.stringify(collapseObservations));
+ if(state.tabs&&state.clicked)return;
+ if(state.tabs)break;
+ }finally{await js(`document.removeEventListener('click',window.__tabCollapseObserver,true)`);}
+ }
+ throw Error(`Tab navigation did not accept a trusted collapse click: ${JSON.stringify(collapseObservations.at(-1))}`);
};
const tabs=()=>js(`Array.from(document.querySelectorAll('[data-tab-id]')).map(t=>Number(t.dataset.tabId))`);
const panes=()=>js(`Array.from(document.querySelectorAll('[data-chat]')).map(t=>Number(t.dataset.chat))`);
@@ -165,6 +188,7 @@ async function runTabDrag({win, origin, output}) {
await up(bottom);await wait(`document.querySelectorAll('[data-chat]').length===2`);
assert.equal(await js(`Array.from(document.querySelectorAll('[data-chat], [data-tab-id]')).flatMap(p=>p.getAnimations()).filter(a=>Number(a.effect.getTiming().duration)>1).length`),0, 'Reduced motion must skip pane and tab settling; global instant color transitions are allowed');
} finally { await wc.debugger.sendCommand('Emulation.setEmulatedMedia',{features:[]}); }
+ if(injectMissedCollapseClick)assert.ok(collapseObservations.some(row=>row.skipped&&!row.clicked&&!row.tabs)&&collapseObservations.some(row=>row.clicked&&row.tabs),'missed collapse click must recover through trusted input');
console.log('PASS pointer tab drag: reorder, right/below splits, preserved draft, Escape cancellation, reduced motion and settled geometry');
}
module.exports={runTabDrag};