Skip to content

graff — a fast agentic coding harness in Zig: multi-provider, MCP, workflows, DGM evolution loop, TS/Python SDKs

Python

An empty tool result reads as "(no output)" on every wire

justrachf0cc57c9c556
diff --git a/src/main.zig b/src/main.zig
index dabb2147..53551369 100644
--- a/src/main.zig
+++ b/src/main.zig
@@ -565,7 +565,7 @@ test { // ── Unit tests (`zig build test`): pull in tests from imported modu
_ = .{ @import("session_catalog.zig"), @import("session_prompt.zig"), @import("session_discovery.zig"), @import("session_workspaces.zig"), @import("commands_resume.zig"), @import("peer_live.zig"), @import("presence_tests.zig"), @import("mcp_rpc_tests.zig") };
_ = .{ @import("prompt_astra.zig"), @import("prompt_guidance.zig"), @import("oauth_chatgpt.zig"), @import("chatgpt_reauth.zig") }; // per-model guidance (Astra, GPT-5.6); ChatGPT plan sign-in (ADR 0253)
_ = .{ @import("agent_empty_completion.zig"), @import("agent_model_loop.zig"), @import("publication_policy_tests.zig"), @import("jobs_completion_tests.zig") };
- _ = .{ @import("provider_routing_tests.zig"), @import("codegraff_messages_tests.zig"), @import("history_wire.zig"), @import("readline_paste_number_tests.zig"), @import("test_hooks.zig"), @import("peer_wake_loop.zig") };
+ _ = .{ @import("provider_routing_tests.zig"), @import("codegraff_messages_tests.zig"), @import("tool_result_empty_tests.zig"), @import("history_wire.zig"), @import("readline_paste_number_tests.zig"), @import("test_hooks.zig"), @import("peer_wake_loop.zig") };
_ = .{ @import("list_dir_nearmiss.zig"), @import("tool_preview_tests.zig") };
_ = @import("repo_map.zig");
_ = @import("agent_overflow_tests.zig"); // #414: and, through it, agent_overflow.zig's table tests
diff --git a/src/messages.zig b/src/messages.zig
index d9f40549..7b0cdbcc 100644
--- a/src/messages.zig
+++ b/src/messages.zig
@@ -86,10 +86,12 @@ pub fn userNote(arena: Allocator, kind: Provider.Kind, text: []const u8) !Value
return @import("session_wake.zig").typedMessage(arena, kind, text);
}
+pub const empty_result = "(no output)"; // an empty tool result, on every wire
pub fn toolResultMessage(arena: Allocator, kind: Provider.Kind, call_id: []const u8, raw_text: []const u8, is_error: bool) !Value {
// Scrub raw bytes (binary tool output etc.) at the source so the result is a
- // valid JSON string, not a byte-integer array the API rejects.
- const text = sanitizeUtf8(arena, raw_text);
+ // valid JSON string, not a byte-integer array the API rejects. An empty one
+ // gets the shell's marker: a hosted route rejects an empty text part.
+ const text = if (raw_text.len == 0) empty_result else sanitizeUtf8(arena, raw_text);
var obj: std.json.ObjectMap = .empty;
switch (kind) {
.interactions => return @import("interactions_steps.zig").fallbackResult(arena, call_id, text, is_error),
diff --git a/src/tool_result_empty_tests.zig b/src/tool_result_empty_tests.zig
new file mode 100644
index 00000000..c16ea93a
--- /dev/null
+++ b/src/tool_result_empty_tests.zig
@@ -0,0 +1,21 @@
+//! An empty tool result never reaches a wire as an empty string. A hosted
+//! chat route turned "" into an empty text part, its upstream rejected the
+//! request, and every later request in that conversation failed the same way.
+const std = @import("std");
+const messages = @import("messages.zig");
+
+test "an empty tool result reads as the shell's marker on every wire" {
+ var arena_state = std.heap.ArenaAllocator.init(std.testing.allocator);
+ defer arena_state.deinit();
+ const a = arena_state.allocator();
+ for ([_]@import("provider.zig").Provider.Kind{ .openai, .anthropic, .responses, .interactions }) |kind| {
+ const msg = try messages.toolResultMessage(a, kind, "c1", "", false);
+ const json = try std.json.Stringify.valueAlloc(a, msg, .{});
+ try std.testing.expect(std.mem.indexOf(u8, json, messages.empty_result) != null);
+ try std.testing.expect(std.mem.indexOf(u8, json, "\"\"") == null);
+ }
+ const err = try messages.toolResultMessage(a, .openai, "c1", "", true);
+ try std.testing.expectEqualStrings("[error] (no output)", err.object.get("content").?.string);
+ const kept = try messages.toolResultMessage(a, .openai, "c1", "x", false);
+ try std.testing.expectEqualStrings("x", kept.object.get("content").?.string);
+}