Skip to content

OpenAI's Codex Security CLI and TypeScript SDK for finding, validating, and fixing security vulnerabilities. npm: https://www.npmjs.com/package/@openai/codex-security

fix(workbench): preserve large SQLite row IDs during migration (#2382)

Michael D'Angelo00deff70cc72
diff --git a/plugins/codex-security/mcp-app/src/workbench/migrations.ts b/plugins/codex-security/mcp-app/src/workbench/migrations.ts
index 30f122dc6..883962849 100644
--- a/plugins/codex-security/mcp-app/src/workbench/migrations.ts
+++ b/plugins/codex-security/mcp-app/src/workbench/migrations.ts
@@ -177,6 +177,8 @@ function migrateWorkflowResults(database: DatabaseSync): void {
"SELECT rowid, results_json FROM finding_workflows",
);
rows.setReadBigInts(true);
+ // run() also returns the connection's last inserted row ID after an UPDATE.
+ update.setReadBigInts(true);
for (const row of rows.all()) {
const { stages } = parseJson(String(row.results_json)) as {
stages: Record<
diff --git a/plugins/codex-security/mcp-app/tests/test_workbench_database.ts b/plugins/codex-security/mcp-app/tests/test_workbench_database.ts
index e0855d715..a06cc4f8b 100644
--- a/plugins/codex-security/mcp-app/tests/test_workbench_database.ts
+++ b/plugins/codex-security/mcp-app/tests/test_workbench_database.ts
@@ -93,7 +93,11 @@ test("retains SQLite open errors and recovery guidance", async () => {
openWorkbenchDatabase(databasePath),
(error: unknown) => {
assert.ok(error instanceof Error);
- assert.equal((error as Error & { errcode: number }).errcode, 14);
+ const resultCode = (error as Error & { errcode: number }).errcode;
+ assert.equal(resultCode & 0xff, 14);
+ assert.throws(() => new DatabaseSync(databasePath).close(), {
+ errcode: resultCode,
+ });
assert.equal(
(error as Error & { code: string }).code,
"ERR_SQLITE_ERROR",
@@ -1048,27 +1052,28 @@ test("workflow and review checkpoints upgrade atomically with their preserved re
`"findings":${index},"opaqueId":9007199254740993`,
),
);
+ const insertWorkflow = database.prepare(
+ "INSERT INTO finding_workflows (rowid, id, state_json, created_at, updated_at) VALUES (?, ?, ?, 'created', 'updated')",
+ );
+ const insertReview = database.prepare(
+ "INSERT INTO finding_workflow_reviews (rowid, workflow_id, review_key, binding_json, result_json, created_at) VALUES (?, ?, ?, ?, ?, 'created')",
+ );
+ // run() returns the inserted row ID even when the fixture ignores the result.
+ insertWorkflow.setReadBigInts(true);
+ insertReview.setReadBigInts(true);
for (const [index, id] of workflowIds.entries()) {
- database
- .prepare(
- "INSERT INTO finding_workflows (rowid, id, state_json, created_at, updated_at) VALUES (?, ?, ?, 'created', 'updated')",
- )
- .run(9007199254740993n + BigInt(index), id, states[index]);
+ insertWorkflow.run(9007199254740993n + BigInt(index), id, states[index]);
for (const [keyIndex, key] of reviewKeys.entries()) {
- database
- .prepare(
- "INSERT INTO finding_workflow_reviews (rowid, workflow_id, review_key, binding_json, result_json, created_at) VALUES (?, ?, ?, ?, ?, 'created')",
- )
- .run(
- 9007199254740993n + BigInt(index * reviewKeys.length + keyIndex),
- id,
- key,
- JSON.stringify({
- ...binding,
- promptDigest: `prompt-${index}-${keyIndex}`,
- }),
- JSON.stringify({ retained: `${index}-${keyIndex}` }),
- );
+ insertReview.run(
+ 9007199254740993n + BigInt(index * reviewKeys.length + keyIndex),
+ id,
+ key,
+ JSON.stringify({
+ ...binding,
+ promptDigest: `prompt-${index}-${keyIndex}`,
+ }),
+ JSON.stringify({ retained: `${index}-${keyIndex}` }),
+ );
}
}
const before = schema(database);