Skip to content

OpenAI's Codex Security CLI and TypeScript SDK for finding, validating, and fixing security vulnerabilities. npm: https://www.npmjs.com/package/@openai/codex-security

perf(cli): index saved sessions by parent when reading scan logs (#2237)

Michael D'Angelo0a91d67d41f2
diff --git a/sdk/typescript/src/scan-logs.ts b/sdk/typescript/src/scan-logs.ts
index 33a284760..03557ed5b 100644
--- a/sdk/typescript/src/scan-logs.ts
+++ b/sdk/typescript/src/scan-logs.ts
@@ -127,6 +127,7 @@ export async function readScanLogs(options: ScanLogOptions) {
`No saved session logs are available for scan ${options.scanId}.`,
);
}
+ let children: Map<string | undefined, SessionLog[]> | undefined;
const included = new Set([
...(options.threadId ? [options.threadId] : []),
@@ -138,14 +139,16 @@ export async function readScanLogs(options: ScanLogOptions) {
const traversed = new Set(options.executionThreadIds ?? included);
for (const parentId of traversed) {
const parent = logs.get(parentId)?.[0];
- for (const [session] of logs.values()) {
+ // Parentless workers can only belong to the root, in discovery order.
+ children ??= Map.groupBy(
+ logs.values().map(([session]) => session),
+ (session) => session.parentThreadId ?? root?.threadId,
+ );
+ for (const session of children.get(parentId) ?? []) {
if (
!traversed.has(session.threadId) &&
(session.parentThreadId === parentId ||
- (root !== undefined &&
- parent === root &&
- session.parentThreadId === null &&
- belongsToScan(session, root, options)))
+ (parent !== undefined && belongsToScan(session, parent, options)))
) {
included.add(session.threadId);
traversed.add(session.threadId);