OpenAI's Codex Security CLI and TypeScript SDK for finding, validating, and fixing security vulnerabilities. npm: https://www.npmjs.com/package/@openai/codex-security
TypeScript ai-securityapplication-securityclicode-scanningcodexcodex-securitycybersecuritydevsecopsnodejsnpmopenaisdksecuritytypescriptvulnerability-scanning
fix(exports): preserve split UTF-8 diagnostics (#1249)
Sylvester Kaczmarek1345ea3fa480
diff --git a/sdk/typescript/src/artifact-export.ts b/sdk/typescript/src/artifact-export.tsindex 496bedd47..7f54c57fa 100644--- a/sdk/typescript/src/artifact-export.ts+++ b/sdk/typescript/src/artifact-export.ts@@ -119,8 +119,9 @@ export async function runArtifactHelper();let stderr = "";let stdout = "";- invocation.stderr.on("data", (chunk: Buffer) => {- stderr = `${stderr}${chunk.toString("utf8")}`.slice(-64 * 1024);+ invocation.stderr.setEncoding("utf8");+ invocation.stderr.on("data", (chunk: string) => {+ stderr = `${stderr}${chunk}`.slice(-64 * 1024);});const forwarded =options.output === undefineddiff --git a/sdk/typescript/tests-ts/artifact-export.test.ts b/sdk/typescript/tests-ts/artifact-export.test.tsindex 4754cf8ff..100a715f7 100644--- a/sdk/typescript/tests-ts/artifact-export.test.ts+++ b/sdk/typescript/tests-ts/artifact-export.test.ts@@ -1,3 +1,5 @@+import * as childProcess from "node:child_process";+import { EventEmitter } from "node:events";import {mkdir,mkdtemp,@@ -8,16 +10,66 @@ import {} from "node:fs/promises";import { tmpdir } from "node:os";import { join } from "node:path";-import { describe, expect, test } from "bun:test";+import { PassThrough } from "node:stream";+import { describe, expect, spyOn, test } from "bun:test";import { exportArtifact } from "../src/index.js";import {readThreatModelPath,+ runArtifactHelper,writeThreatModel,} from "../src/artifact-export.js";import { PLUGIN_ROOT } from "./plugin-root.js";import { PYTHON } from "./support/security-policy.js";describe("offline artifact export", () => {+ test.each([0, 1])(+ "preserves split UTF-8 diagnostics at exit %i",+ async (exitCode) => {+ const diagnostic = "synthetic diagnostic café 東 😀 retained\n";+ const child = Object.assign(new EventEmitter(), {+ stdout: new PassThrough(),+ stderr: new PassThrough(),+ kill: () => true,+ });+ const originalSpawn = childProcess.spawn;+ const script = join(PLUGIN_ROOT, "scripts", "finalize_scan_contract.py");+ const spawn = spyOn(childProcess, "spawn").mockImplementation(((+ ...args: Parameters<typeof originalSpawn>+ ) => {+ if (!Array.isArray(args[1]) || !args[1].includes(script)) {+ return originalSpawn(...args);+ }+ queueMicrotask(() => {+ child.stdout.end("synthetic stdout\n");+ for (const byte of Buffer.from(diagnostic)) {+ child.stderr.write(Buffer.from([byte]));+ }+ child.stderr.end();+ child.emit("close", exitCode, null);+ });+ return child;+ }) as typeof originalSpawn);+ try {+ const operation = runArtifactHelper([], {+ pluginRoot: PLUGIN_ROOT,+ pythonPath: PYTHON,+ });+ if (exitCode === 0) {+ expect(await operation).toEqual({+ stdout: "synthetic stdout\n",+ stderr: diagnostic,+ });+ } else {+ await expect(operation).rejects.toThrow(diagnostic.trim());+ }+ } finally {+ spawn.mockRestore();+ child.stdout.destroy();+ child.stderr.destroy();+ }+ },+ );+test("only exposes a document matching the current canonical model", async () => {const root = await mkdtemp(join(tmpdir(), "codex-security-current-model-"));const modelPath = join(root, "threatmodel.md");