OpenAI's Codex Security CLI and TypeScript SDK for finding, validating, and fixing security vulnerabilities. npm: https://www.npmjs.com/package/@openai/codex-security
TypeScript ai-securityapplication-securityclicode-scanningcodexcodex-securitycybersecuritydevsecopsnodejsnpmopenaisdksecuritytypescriptvulnerability-scanning
fix(windows): parse native tar listings by line (#436)
faizan-oai17614f7765e7
diff --git a/sdk/typescript/scripts/check-package.mjs b/sdk/typescript/scripts/check-package.mjsindex 72603d9fc..95e5c4368 100644--- a/sdk/typescript/scripts/check-package.mjs+++ b/sdk/typescript/scripts/check-package.mjs@@ -5,6 +5,7 @@ import { fileURLToPath } from "node:url";import { brotliDecompressSync, gunzipSync } from "node:zlib";import { assertExpectedGitHead } from "./package-provenance.mjs";import { packageSmokeTimeouts } from "./package-smoke-timeouts.mjs";+import { regularTarListingLines } from "./package-tar-listing.mjs";const PACKAGE_SMOKE_PROCESS_TIMEOUT_MS =packageSmokeTimeouts().processTimeoutMs;@@ -219,12 +220,7 @@ for (const file of files) {}const listing = tar(["-tvzf", archive], "utf8");-if (/^[^d-]/mu.test(listing)) {- throw new Error(- "npm tarball contains a non-regular entry (symbolic or hard link, device, or pipe).",- );-}-const listingLines = listing.split(/\r?\n/u).filter(Boolean);+const listingLines = regularTarListingLines(listing);if (listingLines.length !== entries.length ||listingLines.some(diff --git a/sdk/typescript/scripts/package-tar-listing.mjs b/sdk/typescript/scripts/package-tar-listing.mjsnew file mode 100644index 000000000..1e9914873--- /dev/null+++ b/sdk/typescript/scripts/package-tar-listing.mjs@@ -0,0 +1,9 @@+export function regularTarListingLines(listing) {+ const lines = listing.split(/\r?\n/u).filter(Boolean);+ if (lines.some((line) => !line.startsWith("d") && !line.startsWith("-"))) {+ throw new Error(+ "npm tarball contains a non-regular entry (symbolic or hard link, device, or pipe).",+ );+ }+ return lines;+}diff --git a/sdk/typescript/tests-ts/package-tar-listing.test.ts b/sdk/typescript/tests-ts/package-tar-listing.test.tsnew file mode 100644index 000000000..d2d117280--- /dev/null+++ b/sdk/typescript/tests-ts/package-tar-listing.test.ts@@ -0,0 +1,27 @@+import { describe, expect, test } from "bun:test";++const { regularTarListingLines } = (await import(+ new URL("../scripts/package-tar-listing.mjs", import.meta.url).href+)) as { regularTarListingLines: (listing: string) => string[] };++describe("npm package tar listings", () => {+ test("accepts regular entries with Unix or Windows line endings", () => {+ const file = "-rw-r--r-- package/package.json";+ const directory = "drwxr-xr-x package/dist/";++ expect(regularTarListingLines(`${file}\n${directory}\n`)).toEqual([+ file,+ directory,+ ]);+ expect(regularTarListingLines(`${file}\r\n${directory}\r\n`)).toEqual([+ file,+ directory,+ ]);+ });++ test("rejects symbolic links and other non-regular entries", () => {+ expect(() =>+ regularTarListingLines("lrwxrwxrwx package/link -> target\r\n"),+ ).toThrow("npm tarball contains a non-regular entry");+ });+});