Skip to content

OpenAI's Codex Security CLI and TypeScript SDK for finding, validating, and fixing security vulnerabilities. npm: https://www.npmjs.com/package/@openai/codex-security

fix(deep-scan): wait for the coordinator before ending CLI scans (#2007)

Michael D'Angelo28a18608984e
diff --git a/sdk/typescript/src/api.ts b/sdk/typescript/src/api.ts
index da617c055..32b4b9cad 100644
--- a/sdk/typescript/src/api.ts
+++ b/sdk/typescript/src/api.ts
@@ -2856,6 +2856,9 @@ export class CodexSecurity {
runtimePaths,
options.auth,
git,
+ mode === "deep" && !directDeepScan
+ ? deepScanParentConfig(session.sessionConfig)
+ : undefined,
);
const threadOptions: ThreadOptions = {
threadSource: CODEX_SECURITY_THREAD_SOURCES.scan,
@@ -5810,6 +5813,32 @@ export function classifyConnectionFailure(
return "unknown";
}
+function deepScanParentConfig(config: JsonObject): JsonObject {
+ const resolved = resolveCodexProfile(config);
+ const features = resolved["features"] ?? {};
+ if (!isRecord(features)) return resolved;
+ const mode = features["code_mode"];
+ const settings = typeof mode === "boolean" ? { enabled: mode } : (mode ?? {});
+ // Leave malformed user settings for the native config parser to reject.
+ if (!isRecord(settings)) return resolved;
+ const direct = settings["direct_only_tool_namespaces"] ?? [];
+ if (!Array.isArray(direct)) return resolved;
+ // The native parent waits for direct tool calls before it can end its turn.
+ // A code-mode cell can yield the still-running coordinator to the model.
+ return {
+ ...resolved,
+ features: {
+ ...features,
+ code_mode: {
+ ...settings,
+ direct_only_tool_namespaces: [
+ ...new Set([...direct, "mcp__codex_security", "codex_security"]),
+ ],
+ },
+ },
+ };
+}
+
export function scanRuntimeCodexConfig(
config: JsonObject,
protectedCredentialHome?: string,
diff --git a/sdk/typescript/tests-ts/api-deep-scan-runtime-routing.test.ts b/sdk/typescript/tests-ts/api-deep-scan-runtime-routing.test.ts
index e2dd4c24b..fb95d691b 100644
--- a/sdk/typescript/tests-ts/api-deep-scan-runtime-routing.test.ts
+++ b/sdk/typescript/tests-ts/api-deep-scan-runtime-routing.test.ts
@@ -44,6 +44,13 @@ test.each([
runtimeNode: null,
route: "direct",
},
+ {
+ name: "invalid code mode supplied by the caller",
+ dependencyNode: null,
+ runtimeNode: "selected runtime",
+ route: "parent",
+ codeMode: "mistyped",
+ },
])("Deep Scan respects $name", async (scenario) => {
const root = await temporaryDirectory();
const repository = join(root, "repository");
@@ -59,6 +66,9 @@ test.each([
const runtimeEnvironment: Record<string, string> =
selectedNode === undefined ? {} : { CODEX_MCP_NODE_PATH: selectedNode };
const originalRuntimeEnvironment = { ...runtimeEnvironment };
+ const codeMode = scenario.codeMode ?? {
+ direct_only_tool_namespaces: ["existing_tools"],
+ };
const parentTurn = mock(async () => {
throw new Error("parent route reached");
});
@@ -75,7 +85,19 @@ test.each([
expect(options.config).toMatchObject({
model: "gpt-6.1-sol",
model_reasoning_effort: "high",
- features: { shell_tool: false },
+ features: {
+ shell_tool: false,
+ code_mode:
+ typeof codeMode === "string" || scenario.route === "direct"
+ ? codeMode
+ : {
+ direct_only_tool_namespaces: [
+ "existing_tools",
+ "mcp__codex_security",
+ "codex_security",
+ ],
+ },
+ },
});
return {
startThread: () => ({ id: null, runStreamed: parentTurn }),
@@ -86,7 +108,10 @@ test.each([
codexOverrides: {
model: "gpt-6.1-sol",
model_reasoning_effort: "high",
- features: { shell_tool: false },
+ features: {
+ shell_tool: false,
+ code_mode: codeMode,
+ },
},
},
{