Skip to content

OpenAI's Codex Security CLI and TypeScript SDK for finding, validating, and fixing security vulnerabilities. npm: https://www.npmjs.com/package/@openai/codex-security

test(runtime): share bundled runtime source loader (#407)

mldangelo-oai3afb0c33808d
diff --git a/sdk/typescript/tests-ts/completed-scan-handoff.test.ts b/sdk/typescript/tests-ts/completed-scan-handoff.test.ts
index 6aefeb544..7e0e2f1b6 100644
--- a/sdk/typescript/tests-ts/completed-scan-handoff.test.ts
+++ b/sdk/typescript/tests-ts/completed-scan-handoff.test.ts
@@ -1,16 +1,8 @@
-import { readFile } from "node:fs/promises";
-import { join } from "node:path";
-import { brotliDecompressSync } from "node:zlib";
import { expect, test } from "bun:test";
-import { PLUGIN_ROOT } from "./plugin-root.js";
+import { loadBundledRuntime } from "./plugin-root.js";
test("does not request completed findings after a prompt-only scan", async () => {
- const parts = await Promise.all(
- ["000", "001"].map((part) =>
- readFile(join(PLUGIN_ROOT, "mcp", `server.mjs.br.part-${part}`)),
- ),
- );
- const runtime = brotliDecompressSync(Buffer.concat(parts)).toString("utf8");
+ const runtime = await loadBundledRuntime();
const source = /function promptOnlyScanResult\([^\n]*\) \{[\s\S]*?\n\}/u.exec(
runtime,
)?.[0];
diff --git a/sdk/typescript/tests-ts/deep-scan-reducer-recovery.test.ts b/sdk/typescript/tests-ts/deep-scan-reducer-recovery.test.ts
index 1577bf94c..27714b150 100644
--- a/sdk/typescript/tests-ts/deep-scan-reducer-recovery.test.ts
+++ b/sdk/typescript/tests-ts/deep-scan-reducer-recovery.test.ts
@@ -1,17 +1,9 @@
import { spawnSync } from "node:child_process";
import { mkdirSync, mkdtempSync, rmSync } from "node:fs";
-import { readFile } from "node:fs/promises";
import { tmpdir } from "node:os";
import { join } from "node:path";
-import { brotliDecompressSync } from "node:zlib";
import { expect, test } from "bun:test";
-import { PLUGIN_ROOT } from "./plugin-root.js";
-
-const bundledRuntime = Promise.all(
- ["000", "001"].map((part) =>
- readFile(join(PLUGIN_ROOT, "mcp", `server.mjs.br.part-${part}`)),
- ),
-).then((parts) => brotliDecompressSync(Buffer.concat(parts)).toString("utf8"));
+import { loadBundledRuntime, PLUGIN_ROOT } from "./plugin-root.js";
function bundledFunction(runtime: string, name: string): string {
const source = new RegExp(
@@ -23,7 +15,7 @@ function bundledFunction(runtime: string, name: string): string {
}
test("keeps every advertised Deep worker tool within Codex's name limit", async () => {
- const runtime = await bundledRuntime;
+ const runtime = await loadBundledRuntime();
const method = / compactArtifactServer\(request\) \{[\s\S]*?\n \}/u.exec(
runtime,
)?.[0];
@@ -112,7 +104,7 @@ test("keeps every advertised Deep worker tool within Codex's name limit", async
});
test("classifies owned worker tool failures without exposing their contents", async () => {
- const runtime = await bundledRuntime;
+ const runtime = await loadBundledRuntime();
const diagnosticSource = bundledFunction(runtime, "appendSafeItemDiagnostic");
const recordHelper = /\b(isRecord\d*)\(item\)/u.exec(diagnosticSource)?.[1];
expect(recordHelper).toBeDefined();
@@ -182,7 +174,7 @@ test("classifies owned worker tool failures without exposing their contents", as
});
test("resumes only when the exact reducer result is missing", async () => {
- const runtime = await bundledRuntime;
+ const runtime = await loadBundledRuntime();
const source = bundledFunction(runtime, "isMissingReducerResult");
const pathImport = /\(0, (import_node_path\d+)\.join\)/u.exec(source)?.[1];
expect(pathImport).toBeDefined();
diff --git a/sdk/typescript/tests-ts/deep-scan-worker-shutdown.test.ts b/sdk/typescript/tests-ts/deep-scan-worker-shutdown.test.ts
index dbe0815ee..84af1ac37 100644
--- a/sdk/typescript/tests-ts/deep-scan-worker-shutdown.test.ts
+++ b/sdk/typescript/tests-ts/deep-scan-worker-shutdown.test.ts
@@ -1,8 +1,5 @@
-import { readFile } from "node:fs/promises";
-import { join } from "node:path";
-import { brotliDecompressSync } from "node:zlib";
import { expect, test } from "bun:test";
-import { PLUGIN_ROOT } from "./plugin-root.js";
+import { loadBundledRuntime } from "./plugin-root.js";
type WorkerEvent =
| { type: "thread.started"; thread_id: string }
@@ -26,12 +23,7 @@ type WorkerExecutorConstructor = new (settings: {
async function bundledWorkerExecutor(
events: (signal: AbortSignal) => AsyncGenerator<WorkerEvent>,
): Promise<WorkerExecutorConstructor> {
- const chunks = await Promise.all(
- ["000", "001"].map((part) =>
- readFile(join(PLUGIN_ROOT, "mcp", `server.mjs.br.part-${part}`)),
- ),
- );
- const runtime = brotliDecompressSync(Buffer.concat(chunks)).toString("utf8");
+ const runtime = await loadBundledRuntime();
const source = /var CodexSdkWorkerExecutor = class \{[\s\S]*?\n\};/u.exec(
runtime,
)?.[0];
diff --git a/sdk/typescript/tests-ts/plugin-root.ts b/sdk/typescript/tests-ts/plugin-root.ts
index fa7d95a1c..9885e6fc9 100644
--- a/sdk/typescript/tests-ts/plugin-root.ts
+++ b/sdk/typescript/tests-ts/plugin-root.ts
@@ -1,5 +1,7 @@
import { existsSync } from "node:fs";
+import { readFile } from "node:fs/promises";
import { fileURLToPath } from "node:url";
+import { brotliDecompressSync } from "node:zlib";
const sourcePlugin = new URL(
"../../../plugins/codex-security/",
@@ -9,11 +11,22 @@ const bundledPlugin = new URL("../_bundled_plugin/", import.meta.url);
const hasSourcePlugin = existsSync(
new URL(".codex-plugin/plugin.json", sourcePlugin),
);
+const plugin = hasSourcePlugin ? sourcePlugin : bundledPlugin;
-export const PLUGIN_ROOT = fileURLToPath(
- hasSourcePlugin ? sourcePlugin : bundledPlugin,
-);
+export const PLUGIN_ROOT = fileURLToPath(plugin);
export const INTEGRATION_TARGET = hasSourcePlugin
? "project/codex-security-sdk/src"
: "sdk/typescript/src";
+
+let bundledRuntime: Promise<string> | undefined;
+
+export function loadBundledRuntime(): Promise<string> {
+ return (bundledRuntime ??= Promise.all(
+ ["000", "001"].map((part) =>
+ readFile(new URL(`mcp/server.mjs.br.part-${part}`, plugin)),
+ ),
+ ).then((parts) =>
+ brotliDecompressSync(Buffer.concat(parts)).toString("utf8"),
+ ));
+}
diff --git a/sdk/typescript/tests-ts/prompt-only-start-timeout.test.ts b/sdk/typescript/tests-ts/prompt-only-start-timeout.test.ts
index 4eb4ea7f3..89ba4cfb9 100644
--- a/sdk/typescript/tests-ts/prompt-only-start-timeout.test.ts
+++ b/sdk/typescript/tests-ts/prompt-only-start-timeout.test.ts
@@ -1,16 +1,8 @@
-import { readFile } from "node:fs/promises";
-import { join } from "node:path";
-import { brotliDecompressSync } from "node:zlib";
import { expect, test } from "bun:test";
-import { PLUGIN_ROOT } from "./plugin-root.js";
+import { loadBundledRuntime, PLUGIN_ROOT } from "./plugin-root.js";
test("gives prompt-only scan startup the five-minute scan timeout", async () => {
- const parts = await Promise.all(
- ["000", "001"].map((part) =>
- readFile(join(PLUGIN_ROOT, "mcp", `server.mjs.br.part-${part}`)),
- ),
- );
- const runtime = brotliDecompressSync(Buffer.concat(parts)).toString("utf8");
+ const runtime = await loadBundledRuntime();
const source =
/async function executeWorkbench\([^\n]*\) \{[\s\S]*?\n\}/u.exec(
runtime,