Skip to content

OpenAI's Codex Security CLI and TypeScript SDK for finding, validating, and fixing security vulnerabilities. npm: https://www.npmjs.com/package/@openai/codex-security

fix(plugin): include Terraform files in scan inventories (#944)

mluck-openai46dce4a2497e
diff --git a/plugins/codex-security/scripts/rank_preview.py b/plugins/codex-security/scripts/rank_preview.py
index a5f48e798..d24c7e564 100644
--- a/plugins/codex-security/scripts/rank_preview.py
+++ b/plugins/codex-security/scripts/rank_preview.py
@@ -56,6 +56,7 @@ TEXT_CODE_EXTENSIONS = {
".sh",
".sql",
".swift",
+ ".tf",
".toml",
".ts",
".tsx",
diff --git a/plugins/codex-security/tests/test_generate_in_scope_files.py b/plugins/codex-security/tests/test_generate_in_scope_files.py
index bb9d7067c..742328d24 100644
--- a/plugins/codex-security/tests/test_generate_in_scope_files.py
+++ b/plugins/codex-security/tests/test_generate_in_scope_files.py
@@ -382,6 +382,28 @@ def test_diff_inventory_keeps_changed_and_deleted_source_files(tmp_path: Path) -
]
[email protected]("mode", ["revisions", "local-patch"])
+def test_diff_inventory_includes_changed_terraform(tmp_path: Path, mode: str) -> None:
+ repository = make_repository(tmp_path)
+ write_file(repository, "infra/main.tf", b'variable "enabled" { default = false }\n')
+ git(repository, "add", ".")
+ git(repository, "commit", "-qm", "base")
+ base = git(repository, "rev-parse", "HEAD")
+ write_file(repository, "infra/main.tf", b'variable "enabled" { default = true }\n')
+ arguments = ["--diff-base", base, "--diff-mode", mode]
+ if mode == "revisions":
+ git(repository, "add", ".")
+ git(repository, "commit", "-qm", "change")
+ arguments.extend(["--diff-head", git(repository, "rev-parse", "HEAD")])
+ git(repository, "checkout", "-q", base)
+ output = tmp_path / "in_scope_files.txt"
+
+ result = run_inventory(repository, ".", output, arguments=arguments)
+
+ assert result.returncode == 0, result.stderr
+ assert output.read_text(encoding="utf-8") == "infra/main.tf\n"
+
+
def test_diff_inventory_keeps_every_javascript_module_extension(tmp_path: Path) -> None:
repository = make_repository(tmp_path)
git(repository, "add", ".")
diff --git a/plugins/codex-security/tests/test_generate_rank_input.py b/plugins/codex-security/tests/test_generate_rank_input.py
index f6c39f937..1eeaad972 100644
--- a/plugins/codex-security/tests/test_generate_rank_input.py
+++ b/plugins/codex-security/tests/test_generate_rank_input.py
@@ -171,6 +171,38 @@ def test_make_repo_rank_input_matches_golden_and_filters_noise(tmp_path: Path) -
)
[email protected]("mode", ["repo", "revisions", "local-patch"])
+def test_rank_input_includes_terraform(tmp_path: Path, mode: str) -> None:
+ repo = tmp_path / "repo"
+ infra = repo / "infra"
+ infra.mkdir(parents=True)
+ initialize_repo(repo)
+ source = infra / "main.tf"
+ source.write_text('variable "enabled" { default = false }\n', encoding="utf-8")
+ git(repo, "add", ".")
+ git(repo, "commit", "-qm", "base")
+ base = git(repo, "rev-parse", "HEAD")
+ changed = 'variable "enabled" { default = true }'
+ source.write_text(changed + "\n", encoding="utf-8")
+ output = tmp_path / "rank_input.jsonl"
+
+ if mode == "repo":
+ arguments = ["make-repo-rank-input", "--repo", str(repo), "--scope", "infra"]
+ else:
+ arguments = ["make-diff-rank-input", "--repo", str(repo), "--base", base, "--mode", mode]
+ if mode == "revisions":
+ git(repo, "add", ".")
+ git(repo, "commit", "-qm", "change")
+ arguments.extend(["--head", git(repo, "rev-parse", "HEAD")])
+ git(repo, "checkout", "-q", base)
+
+ run_cli(*arguments, "--out", str(output))
+
+ assert read_jsonl(output) == [
+ {"path": "infra/main.tf", "area": "infra" if mode == "repo" else "diff", "preview": changed}
+ ]
+
+
def test_make_repo_rank_input_rejects_scope_outside_repo(tmp_path: Path) -> None:
repo = tmp_path / "repo"
repo.mkdir()
diff --git a/plugins/codex-security/tests/test_rank_preview.py b/plugins/codex-security/tests/test_rank_preview.py
index c606da5ad..d1fd3a01d 100644
--- a/plugins/codex-security/tests/test_rank_preview.py
+++ b/plugins/codex-security/tests/test_rank_preview.py
@@ -527,10 +527,13 @@ def test_fallback_preview_omits_marker_when_no_lines_are_skipped(tmp_path: Path)
assert "..." not in preview
-def test_preview_byte_budget_preserves_sampled_tail_and_valid_unicode(tmp_path: Path) -> None:
[email protected]("filename", ["styles.css", "main.tf"])
+def test_preview_byte_budget_preserves_sampled_tail_and_valid_unicode(
+ tmp_path: Path, filename: str
+) -> None:
source = "\n".join(f"line_{index:02d} {'😀' * 20}" for index in range(40))
- preview = generate_preview(tmp_path, "styles.css", source, preview_bytes=220)
+ preview = generate_preview(tmp_path, filename, source, preview_bytes=220)
assert len(preview.encode("utf-8")) <= 220
assert "..." in preview