Skip to content

OpenAI's Codex Security CLI and TypeScript SDK for finding, validating, and fixing security vulnerabilities. npm: https://www.npmjs.com/package/@openai/codex-security

fix(cli): clarify the post-scan findings review prompt (#2255)

Michael D'Angelo4959826a32bb
diff --git a/sdk/typescript/src/cli.ts b/sdk/typescript/src/cli.ts
index d61e7ef5d..bddc23e63 100644
--- a/sdk/typescript/src/cli.ts
+++ b/sdk/typescript/src/cli.ts
@@ -10522,7 +10522,7 @@ async function executeScan(
(await (
dependencies.confirmPatchReview ??
createTerminalPrompt(errorOutput).confirm
- )("Review and patch these findings?"));
+ )("Open findings for review?"));
if (confirmed) {
const selectPatches =
dependencies.patchEditor ??
diff --git a/sdk/typescript/tests-ts/cli-patch.test.ts b/sdk/typescript/tests-ts/cli-patch.test.ts
index 6808e9913..d36148e42 100644
--- a/sdk/typescript/tests-ts/cli-patch.test.ts
+++ b/sdk/typescript/tests-ts/cli-patch.test.ts
@@ -2049,11 +2049,9 @@ describe("scan and patch workflow", () => {
...expected,
]);
if (argv[1] === "--patch") {
- expect(outcome.stderr).not.toContain(
- "Review and patch these findings?",
- );
+ expect(outcome.stderr).not.toContain("Open findings for review?");
} else {
- expect(outcome.stderr).toContain("Review and patch these findings?");
+ expect(outcome.stderr).toContain("Open findings for review?");
}
}
});
@@ -2086,7 +2084,7 @@ describe("scan and patch workflow", () => {
expect(outcome.exitCode).toBe(0);
expect(outcome.stderr.indexOf("FINDINGS")).toBeLessThan(
- outcome.stderr.indexOf("Review and patch these findings? (y/N)"),
+ outcome.stderr.indexOf("Open findings for review? (y/N)"),
);
expect(opened).toBe(review);
expect(patched).toBe(review);
@@ -2114,7 +2112,7 @@ describe("scan and patch workflow", () => {
expect(outcome.exitCode).toBe(0);
expect(outcome.stderr).toContain(`FINDINGS ${severities.length}`);
- expect(outcome.stderr).not.toContain("Review and patch these findings?");
+ expect(outcome.stderr).not.toContain("Open findings for review?");
expect(confirmPatchReview).not.toHaveBeenCalled();
expect(patchEditor).not.toHaveBeenCalled();
}