Skip to content

OpenAI's Codex Security CLI and TypeScript SDK for finding, validating, and fixing security vulnerabilities. npm: https://www.npmjs.com/package/@openai/codex-security

fix(sarif): normalize location paths before deduplicating (#1867)

wj53da0ecc80df
diff --git a/plugins/codex-security/scripts/finalize_scan_contract.py b/plugins/codex-security/scripts/finalize_scan_contract.py
index 8442910fa..84c50abf9 100644
--- a/plugins/codex-security/scripts/finalize_scan_contract.py
+++ b/plugins/codex-security/scripts/finalize_scan_contract.py
@@ -2528,7 +2528,7 @@ def _sarif_locations(finding: dict[str, Any]) -> list[dict[str, Any]]:
unique: dict[tuple[str, int, int], dict[str, Any]] = {}
for location in locations:
key = (
- location["path"],
+ PurePosixPath(location["path"]).as_posix(),
location["startLine"],
location.get("endLine", location["startLine"]),
)
diff --git a/plugins/codex-security/tests/test_finalize_scan_contract.py b/plugins/codex-security/tests/test_finalize_scan_contract.py
index ec2980c48..48de0b9c2 100644
--- a/plugins/codex-security/tests/test_finalize_scan_contract.py
+++ b/plugins/codex-security/tests/test_finalize_scan_contract.py
@@ -2917,6 +2917,25 @@ The extraction root is not enforced.
)
self.assertNotIn("relatedLocations", result)
+ def test_sarif_deduplicates_dot_prefixed_location_paths(self) -> None:
+ sarif_finding = self.sarif_finding("fingerprint")
+ sarif_finding["locations"] = [{"path": "./src/write.py", "startLine": 30, "role": "sink"}]
+ sarif_finding["codeEvidence"] = [
+ {
+ "id": "duplicate-sink",
+ "label": "Duplicate sink",
+ "path": "src/write.py",
+ "startLine": 30,
+ "code": "write(user_input)",
+ "explanation": "Already present in locations.",
+ }
+ ]
+
+ result = FINALIZER._sarif_result(sarif_finding, 0)
+
+ self.assertEqual(len(result["locations"]), 1)
+ self.assertEqual(result["locations"][0]["message"], {"text": "sink"})
+
@pytest.mark.cross_platform
def test_sarif_includes_legacy_code_evidence_locations(self) -> None:
sarif_finding = self.sarif_finding("fingerprint")