Skip to content

OpenAI's Codex Security CLI and TypeScript SDK for finding, validating, and fixing security vulnerabilities. npm: https://www.npmjs.com/package/@openai/codex-security

perf(imports): reuse Wiz replay projections for package reports (#2193)

Michael D'Angelo5b987f25e1ef
diff --git a/sdk/typescript/src/wiz-findings.ts b/sdk/typescript/src/wiz-findings.ts
index 684e7ffa4..40a3e698e 100644
--- a/sdk/typescript/src/wiz-findings.ts
+++ b/sdk/typescript/src/wiz-findings.ts
@@ -510,12 +510,21 @@ export async function readVendorFindingsForPublication(
const input = await readFindingInput(path);
const normalized = new WeakSet<VendorFinding>();
const current = normalizeFindings(input, target, normalized);
- const legacy = normalizeFindings(
- { ...input, repositories: input.legacyRepositories ?? input.repositories },
- target,
- normalized,
- true,
+ // Only repository finding families use historical inventory and branch mapping.
+ const hasRepositoryFindings = input.records.some(
+ ({ kind }) => kind === "sast" || kind === "secret" || kind === "iac",
);
+ const legacy = hasRepositoryFindings
+ ? normalizeFindings(
+ {
+ ...input,
+ repositories: input.legacyRepositories ?? input.repositories,
+ },
+ target,
+ normalized,
+ true,
+ )
+ : current;
const identity = (parsed: VendorFindings) =>
parsed.findings.map((finding) => {
if (normalized.has(finding)) return finding;
@@ -537,11 +546,12 @@ export async function readVendorFindingsForPublication(
},
};
});
+ const currentIdentity = identity(current);
return {
current,
legacy,
- currentIdentity: identity(current),
- legacyIdentity: identity(legacy),
+ currentIdentity,
+ legacyIdentity: legacy === current ? currentIdentity : identity(legacy),
sourceRepositories: current.findings.flatMap(({ evidence }) => {
const repository = evidence.details?.repository;
const inventory = input.repositories.get(repository?.id ?? "");
diff --git a/sdk/typescript/tests-ts/wiz-findings.test.ts b/sdk/typescript/tests-ts/wiz-findings.test.ts
index 73d2e8354..774909873 100644
--- a/sdk/typescript/tests-ts/wiz-findings.test.ts
+++ b/sdk/typescript/tests-ts/wiz-findings.test.ts
@@ -152,6 +152,40 @@ async function parse(payload: unknown) {
return readVendorFindings(file);
}
+test.each(["local", "cloud"] as const)(
+ "mixed Wiz reports preserve duplicate IDs found only in the historical projection (%s)",
+ async (target) => {
+ const row = { ...sast, repository: { id: repository.id } };
+ const { file } = await fixture({
+ data: {
+ vulnerabilityFindings: {
+ nodes: [
+ {
+ source_finding_id: "package",
+ evidence: { title: "Package", severity: "low" },
+ },
+ ],
+ },
+ sastFindings: { nodes: [row, row] },
+ versionControlResources: {
+ nodes: ["bad\0name", "good"].map((name) => ({
+ platform: "GITHUB",
+ repository: { ...repository, name, url: repositoryUrl },
+ })),
+ },
+ },
+ });
+ const current = await readVendorFindings(file, target);
+ expect(
+ current.findings.map((finding) => finding.source_finding_id),
+ ).toEqual(["package"]);
+ expect(current.excluded.map((finding) => finding.position)).toEqual([2, 3]);
+ await expect(
+ readVendorFindingsForPublication(file, target),
+ ).rejects.toThrow('Duplicate source finding id "sast:occurrence-1"');
+ },
+);
+
test("SAST maps source range, CWE, scanner verdict, and repository inventory without changing raw evidence", async () => {
const { file } = await fixture(envelope("sastFindings", [sast]), true);
const parsed = await readVendorFindings(file);