Skip to content

OpenAI's Codex Security CLI and TypeScript SDK for finding, validating, and fixing security vulnerabilities. npm: https://www.npmjs.com/package/@openai/codex-security

fix(windows): handle multiscan path aliases (#496)

faizan-oai63bc8df45e02
diff --git a/sdk/typescript/src/multiscan.ts b/sdk/typescript/src/multiscan.ts
index 07d37cec1..bbc4b3604 100644
--- a/sdk/typescript/src/multiscan.ts
+++ b/sdk/typescript/src/multiscan.ts
@@ -1,5 +1,6 @@
import { execFile as execFileCallback } from "node:child_process";
import { randomUUID } from "node:crypto";
+import { realpathSync } from "node:fs";
import {
lstat,
mkdir,
@@ -371,8 +372,18 @@ async function ensureOutputDirectory(path: string): Promise<string> {
if (metadata?.isSymbolicLink()) {
throw new Error("Multiscan output directories must not be symbolic links.");
}
- await mkdir(path, { recursive: true, mode: 0o700 });
- const canonical = await realpath(path);
+ if (metadata !== undefined && !metadata.isDirectory()) {
+ throw new Error("Multiscan output paths must be directories.");
+ }
+ let prepared = path;
+ if (metadata === undefined) {
+ prepared =
+ process.platform === "win32"
+ ? await canonicalWindowsCreationPath(path)
+ : path;
+ await mkdir(prepared, { recursive: true, mode: 0o700 });
+ }
+ const canonical = await realpath(prepared);
const directory = await lstat(canonical, { bigint: true });
if (
metadata !== undefined &&
@@ -395,6 +406,20 @@ async function ensureOutputDirectory(path: string): Promise<string> {
return canonical;
}
+async function canonicalWindowsCreationPath(path: string): Promise<string> {
+ let ancestor = dirname(path);
+ for (;;) {
+ try {
+ return resolve(await realpath(ancestor), relative(ancestor, path));
+ } catch (error) {
+ if ((error as NodeJS.ErrnoException).code !== "ENOENT") throw error;
+ const parent = dirname(ancestor);
+ if (parent === ancestor) throw error;
+ ancestor = parent;
+ }
+ }
+}
+
async function appendReceipt(path: string, receipt: string): Promise<void> {
const file = await open(path, "a", 0o600);
try {
@@ -768,7 +793,15 @@ function normalizeRepository(repository: string, directory: string): string {
);
}
if (/^[^@\s/:]+@[^:\s/]+:.+$/u.test(repository)) return repository;
- if (!repository.includes("://")) return resolve(directory, repository);
+ if (!repository.includes("://")) {
+ const path = resolve(directory, repository);
+ if (process.platform !== "win32") return path;
+ try {
+ return realpathSync.native(path);
+ } catch {
+ return path;
+ }
+ }
let url: URL;
try {
url = new URL(repository);
diff --git a/sdk/typescript/tests-ts/multiscan.test.ts b/sdk/typescript/tests-ts/multiscan.test.ts
index 873b5cb47..390988965 100644
--- a/sdk/typescript/tests-ts/multiscan.test.ts
+++ b/sdk/typescript/tests-ts/multiscan.test.ts
@@ -1592,6 +1592,31 @@ describe("multiscan", () => {
expect(calls).toBe(2);
});
+ test.skipIf(process.platform !== "win32")(
+ "resumes campaigns across Windows repository path aliases",
+ async () => {
+ const paths = await fixture();
+ const source = await repository(paths.root, "resume-alias");
+ const inventory = (repositoryPath: string) =>
+ `id,repository,revision\nresume,${repositoryPath},${source.revision}\n`;
+ let calls = 0;
+ const security = client(async (_repository, scanOptions = {}) => {
+ calls += 1;
+ return await completedScan(scanOptions.outputDir!);
+ });
+
+ await writeFile(paths.input, inventory(source.path));
+ await runMultiscan(options(paths, security));
+ await writeFile(paths.input, inventory(source.path.toUpperCase()));
+
+ expect(await runMultiscan(options(paths, security))).toMatchObject({
+ completed: 1,
+ skipped: 1,
+ });
+ expect(calls).toBe(1);
+ },
+ );
+
test("ignores repository-local Git shims while preserving credential configuration", async () => {
if (
runTestInSubprocess(