OpenAI's Codex Security CLI and TypeScript SDK for finding, validating, and fixing security vulnerabilities. npm: https://www.npmjs.com/package/@openai/codex-security
TypeScript ai-securityapplication-securityclicode-scanningcodexcodex-securitycybersecuritydevsecopsnodejsnpmopenaisdksecuritytypescriptvulnerability-scanning
fix(native): read sealed artifacts in searchable Linux directories (#2564)
Michael D'Angelo6993830d5d8b
diff --git a/plugins/codex-security/native/proof-scan-read.mts b/plugins/codex-security/native/proof-scan-read.mtsindex 0e76d99ac..4b65d24a9 100644--- a/plugins/codex-security/native/proof-scan-read.mts+++ b/plugins/codex-security/native/proof-scan-read.mts@@ -1,12 +1,14 @@import assert from "node:assert/strict";import { spawnSync } from "node:child_process";import {+ chmodSync,mkdirSync,mkdtempSync,realpathSync,renameSync,rmSync,symlinkSync,+ unlinkSync,writeFileSync,} from "node:fs";import { tmpdir } from "node:os";@@ -65,6 +67,20 @@ export function scanReadProof(): Record<string, boolean> {renameSync(scan, moved);renameSync(moved, scan);}+ if (process.platform === "linux") {+ chmodSync(artifacts, 0o100);+ chmodSync(scan, 0o100);+ try {+ const searchable = openRoot(scan);+ assert.deepEqual(+ chunks(openFile(searchable, "artifacts/receipt.json")),+ payload,+ );+ } finally {+ chmodSync(scan, 0o700);+ chmodSync(artifacts, 0o700);+ }+ }const root = openRoot(scan);assert.deepEqual(chunks(openFile(root, "artifacts/receipt.json")), payload);assert.equal(root.openFile("missing.json"), null);@@ -97,7 +113,7 @@ export function scanReadProof(): Record<string, boolean> {assert.deepEqual(chunks(held), payload);assert.throws(() => root.openFile("artifacts/receipt.json"));held.close();- rmSync(artifacts);+ unlinkSync(artifacts);renameSync(moved, artifacts);}assert.throws(() => held.read(1), /closed/i);diff --git a/plugins/codex-security/native/src/scan_read_unix.rs b/plugins/codex-security/native/src/scan_read_unix.rsindex 31690413d..e87a9ddaf 100644--- a/plugins/codex-security/native/src/scan_read_unix.rs+++ b/plugins/codex-security/native/src/scan_read_unix.rs@@ -11,6 +11,12 @@ use std::{path::PathBuf,};+// These descriptors anchor named lookups and metadata checks without listing the directory.+#[cfg(target_os = "linux")]+const DIRECTORY_ACCESS: i32 = libc::O_PATH;+#[cfg(not(target_os = "linux"))]+const DIRECTORY_ACCESS: i32 = libc::O_RDONLY;+pub(crate) struct ScanReadRootBackend {path: PathBuf,directory: Option<File>,@@ -93,7 +99,7 @@ impl ScanReadRootBackend {let directory = open_at(libc::AT_FDCWD,path.as_os_str(),- libc::O_RDONLY | libc::O_DIRECTORY | libc::O_NOFOLLOW,+ DIRECTORY_ACCESS | libc::O_DIRECTORY | libc::O_NOFOLLOW,).map_err(|error| failure("Cannot open scan directory", error))?;let opened = directory@@ -139,7 +145,7 @@ impl ScanReadRootBackend {let directory = match open_at(parent,OsStr::new(part),- libc::O_RDONLY | libc::O_DIRECTORY | libc::O_NOFOLLOW,+ DIRECTORY_ACCESS | libc::O_DIRECTORY | libc::O_NOFOLLOW,) {Ok(directory) => directory,Err(error) if error.kind() == io::ErrorKind::NotFound => return Ok(None),