Skip to content

OpenAI's Codex Security CLI and TypeScript SDK for finding, validating, and fixing security vulnerabilities. npm: https://www.npmjs.com/package/@openai/codex-security

fix(cli): send the app-server initialized notification (#1282)

mldangelo-oai6d0d06be56b9
diff --git a/sdk/typescript/src/cli.ts b/sdk/typescript/src/cli.ts
index 9cbb27751..fb0ef3c7d 100644
--- a/sdk/typescript/src/cli.ts
+++ b/sdk/typescript/src/cli.ts
@@ -7685,7 +7685,7 @@ export async function readSkillCommandOutput(
appServer.input.end();
} else if (value["id"] === 1 || value["id"] === "login") {
if (value["id"] === 1) {
- send({ method: "notifications/initialized" });
+ send({ method: "initialized" });
if (appServer.apiKey !== undefined) {
send({
id: "login",
diff --git a/sdk/typescript/tests-ts/cli-authentication.test.ts b/sdk/typescript/tests-ts/cli-authentication.test.ts
index 6d116fa56..d51ec4f94 100644
--- a/sdk/typescript/tests-ts/cli-authentication.test.ts
+++ b/sdk/typescript/tests-ts/cli-authentication.test.ts
@@ -2158,7 +2158,7 @@ describe("skill authentication", () => {
}
expect(methods).toEqual([
"initialize",
- "notifications/initialized",
+ "initialized",
...(usesSessionKey ? ["account/login/start"] : []),
...(loginFailure && usesSessionKey ? [] : ["thread/start"]),
...(loginFailure ? [] : ["command/exec", "turn/start"]),
diff --git a/sdk/typescript/tests-ts/cli-skills.test.ts b/sdk/typescript/tests-ts/cli-skills.test.ts
index 15ef41963..38930d3bb 100644
--- a/sdk/typescript/tests-ts/cli-skills.test.ts
+++ b/sdk/typescript/tests-ts/cli-skills.test.ts
@@ -1361,6 +1361,7 @@ process.stdout.write(JSON.stringify({
const assert = require("node:assert/strict");
const lines = require("node:readline").createInterface({ input: process.stdin });
const send = (message) => process.stdout.write(JSON.stringify(message) + "\\n");
+let initialized = false;
const item = (threadId, turnId, text, phase = "final_answer") =>
send({ method: "item/completed", params: { threadId, turnId, item: { type: "agentMessage", text, phase } } });
const complete = (threadId, id) =>
@@ -1372,7 +1373,10 @@ lines.on("line", (line) => {
} else if (request.id === 1 && !request.method) {
assert.equal(request.error.code, -32601);
send({ id: 1, result: {} });
+ } else if (request.method === "initialized") {
+ initialized = true;
} else if (request.method === "thread/start") {
+ assert.equal(initialized, true);
assert.equal(process.cwd(), ${JSON.stringify(process.cwd())});
assert.deepEqual(request.params, { threadSource: "security_remediation", approvalPolicy: "never", sandbox: "workspace-write" });
send({ id: 2, result: { thread: { id: "parent", source: "vscode", ephemeral: false }, sandbox: { type: "workspaceWrite", writableRoots: [], networkAccess: false, excludeTmpdirEnvVar: false, excludeSlashTmp: false } } });