OpenAI's Codex Security CLI and TypeScript SDK for finding, validating, and fixing security vulnerabilities. npm: https://www.npmjs.com/package/@openai/codex-security
TypeScript ai-securityapplication-securityclicode-scanningcodexcodex-securitycybersecuritydevsecopsnodejsnpmopenaisdksecuritytypescriptvulnerability-scanning
fix: reject merge advice with critical regression likelihood (#1728)
Michael D'Angelo6f12d998d4da
diff --git a/plugins/codex-security/mcp-app/src/helpers/validate-patch-risk-assessment.ts b/plugins/codex-security/mcp-app/src/helpers/validate-patch-risk-assessment.tsindex db655b262..19833c35e 100644--- a/plugins/codex-security/mcp-app/src/helpers/validate-patch-risk-assessment.ts+++ b/plugins/codex-security/mcp-app/src/helpers/validate-patch-risk-assessment.ts@@ -60,6 +60,8 @@ export function validatePatchRiskAssessment(assessment: unknown): string[] {errors.push("merge cannot retain a failed validation");if (evidencePlan.length)errors.push("merge cannot retain an evidence plan");+ if (assessment.regressionLikelihood.rating === "critical")+ errors.push("merge cannot retain critical regression likelihood");} else if (workflowLabel !== recommendation) {errors.push("non-merge workflow label must match the recommendation");}diff --git a/sdk/typescript/tests-ts/patch-risk-contract.test.ts b/sdk/typescript/tests-ts/patch-risk-contract.test.tsindex bafe86c16..8c3755163 100644--- a/sdk/typescript/tests-ts/patch-risk-contract.test.ts+++ b/sdk/typescript/tests-ts/patch-risk-contract.test.ts@@ -246,6 +246,35 @@ describe("patch risk assessment contract", () => {expect(result.status, result.stderr).toBe(0);});+ test("rejects critical regression likelihood for every merge workflow", () => {+ for (const workflowLabel of [+ "human_review_required",+ "auto_merge_candidate",+ ]) {+ const payload = assessment();+ payload.workflowLabel = workflowLabel;+ payload.impact.rating = "low";+ payload.regressionLikelihood.rating = "critical";++ const result = validate(payload);+ expect(result.status).toBe(1);+ expect(result.stderr).toContain(+ "merge cannot retain critical regression likelihood",+ );+ }+ });++ test.each(["low", "moderate", "high"])(+ "accepts critical-impact human-review merge with %s regression likelihood",+ (rating) => {+ const payload = assessment();+ payload.impact.rating = "critical";+ payload.regressionLikelihood.rating = rating;+ const result = validate(payload);+ expect(result.status, result.stderr).toBe(0);+ },+ );+test("compares JSON numeric constants by value", () => {const serialized = JSON.stringify(assessment()).replace('"schemaVersion":1',@@ -480,6 +509,7 @@ describe("patch risk assessment contract", () => {test("keeps all merge errors in their established order", () => {const payload = assessment();+ payload.regressionLikelihood.rating = "critical";payload.workflowLabel = "block";payload.applicability.status = "wrong_owner";payload.unknowns = [@@ -504,6 +534,7 @@ describe("patch risk assessment contract", () => {"merge requires every material boundary to be supported","merge cannot retain a failed validation","merge cannot retain an evidence plan",+ "merge cannot retain critical regression likelihood","only hold_for_evidence may include an evidence plan","an established non-applicable disposition requires no_op",]);