OpenAI's Codex Security CLI and TypeScript SDK for finding, validating, and fixing security vulnerabilities. npm: https://www.npmjs.com/package/@openai/codex-security
TypeScript ai-securityapplication-securityclicode-scanningcodexcodex-securitycybersecuritydevsecopsnodejsnpmopenaisdksecuritytypescriptvulnerability-scanning
test: separate pagination from oversized finding fixtures (#747)
mldangelo-oai79265de39152
diff --git a/plugins/codex-security/tests/test_finding_preview.py b/plugins/codex-security/tests/test_finding_preview.pyindex ebae3d47f..4b094b49d 100644--- a/plugins/codex-security/tests/test_finding_preview.py+++ b/plugins/codex-security/tests/test_finding_preview.py@@ -7,6 +7,20 @@ from pathlib import PathFINDING_PREVIEW_SCRIPT = Path(__file__).resolve().parents[1] / "scripts" / "finding_preview.py"+def test_nested_attack_path_stays_within_its_preview_budget() -> None:+ preview = runpy.run_path(str(FINDING_PREVIEW_SCRIPT))+ attack_path = {+ f"branch-{branch}": {f"node-{node}": "\n😀" * 40 for node in range(3)}+ for branch in range(3)+ }++ bounded = preview["bounded_finding_details"]({"attackPath": attack_path})["attackPath"]++ assert bounded["branch-0"]["node-0"] == "\n😀" * 40+ assert len(json.dumps(bounded, separators=(",", ":")).encode()) <= 4_000+ assert attack_path["branch-2"]["node-2"] == "\n😀" * 40++def test_bounded_finding_details_normalizes_scalar_attack_path_assessments() -> None:preview = runpy.run_path(str(FINDING_PREVIEW_SCRIPT))scalar_finding = {@@ -149,6 +163,7 @@ def test_bounded_finding_details_reserves_core_sections() -> None:"reportPath": "findings/archive-traversal/archive-traversal.md","untrustedExtra": "x" * 20_000,},+ "evidenceExcerpt": "x" * 20_000,})diff --git a/plugins/codex-security/tests/test_workbench_db_exports.py b/plugins/codex-security/tests/test_workbench_db_exports.pyindex 59c5ed957..b731ed974 100644--- a/plugins/codex-security/tests/test_workbench_db_exports.py+++ b/plugins/codex-security/tests/test_workbench_db_exports.py@@ -876,66 +876,90 @@ def test_completed_findings_are_returned_in_bounded_pages(tmp_path: Path) -> Nonassert completed["findingsTruncated"] is Trueassert len(completed["findings"]) == 20embedded_occurrence_ids = {finding["occurrenceId"] for finding in completed["findings"]}- with sqlite3.connect(state_dir / "workbench.sqlite3") as connection:- rows = connection.execute(- "SELECT id, details_json FROM finding_occurrences WHERE scan_id = ?", (scan_id,)- ).fetchall()- off_prefix_occurrence_id = next(- occurrence_id- for occurrence_id, _ in rows- if occurrence_id not in embedded_occurrence_ids- )- for index, (occurrence_id, details_json) in enumerate(rows):- details = json.loads(details_json)- details["evidenceExcerpt"] = "x" * 300_000- if index == 0:- details["attackPath"] = {- f"outer-{outer:02d}-{'x' * 120}": {- f"middle-{middle:02d}-{'x' * 120}": {- f"inner-{inner:02d}-{'x' * 120}": {- f"leaf-{leaf:02d}-{'x' * 120}": leaf for leaf in range(20)- }- for inner in range(20)- }- for middle in range(20)- }- for outer in range(20)- }- connection.execute(- """- UPDATE finding_occurrences- SET details_json = ?, title = ?, summary = ?, remediation = ?,- severity = ?, confidence = ?- WHERE id = ?- """,- (- json.dumps(details),- "t" * 100_000,- "s" * 100_000,- "r" * 100_000,- "v" * 100_000,- "c" * 100_000,- occurrence_id,- ),- )- connection.execute(- "UPDATE finding_locations SET relative_path = ?, role = ? WHERE occurrence_id = ?",- ("p" * 100_000, "o" * 100_000, occurrence_id),- )- selected = run_workbench(+ second_page = run_workbench(state_dir,- "get-scan",+ "list-findings","--scan-id",scan_id,- "--occurrence-id",- off_prefix_occurrence_id,+ "--offset",+ "20",+ "--limit",+ "50",+ )["findingsPage"]+ assert second_page["offset"] == 20+ assert second_page["nextOffset"] == 40+ assert second_page["total"] == 75+ assert len(second_page["findings"]) == 20+ assert embedded_occurrence_ids.isdisjoint(+ finding["occurrenceId"] for finding in second_page["findings"]+ )+ off_prefix_occurrence_id = second_page["findings"][0]["occurrenceId"]+ selected = run_workbench(+ state_dir, "get-scan", "--scan-id", scan_id, "--occurrence-id", off_prefix_occurrence_id)["scan"]assert any(finding["occurrenceId"] == off_prefix_occurrence_id for finding in selected["findings"])- refreshed = run_workbench(state_dir, "get-scan", "--scan-id", scan_id)- assert len(json.dumps(refreshed)) < 4 * 1024 * 1024- finding = refreshed["scan"]["findings"][0]+++def test_embedded_and_paged_findings_bound_large_stored_fields(tmp_path: Path) -> None:+ state_dir = tmp_path / "state"+ target = tmp_path / "target"+ target.mkdir()+ saved = create_saved_workspace(state_dir, target)+ started = run_workbench(+ state_dir,+ "start-scan",+ "--workspace-id",+ str(saved["id"]),+ "--scan-root",+ str(tmp_path / "scans"),+ )+ scan_id = str(started["results"]["scanId"])+ scan_dir = Path(str(started["results"]["scanDir"]))+ with sqlite3.connect(state_dir / "workbench.sqlite3") as connection:+ connection.execute("UPDATE scans SET handoff_status = 'delivered' WHERE id = ?", (scan_id,))+ write_completed_contract(scan_dir, scan_id, target)+ completed = run_workbench(state_dir, "complete-scan", "--scan-id", scan_id)["scan"]+ occurrence_id = completed["findings"][0]["occurrenceId"]+ with sqlite3.connect(state_dir / "workbench.sqlite3") as connection:+ details = json.loads(+ connection.execute(+ "SELECT details_json FROM finding_occurrences WHERE id = ?", (occurrence_id,)+ ).fetchone()[0]+ )+ details["evidenceExcerpt"] = "x" * 8_001+ details["attackPath"] = {"nested": {"value": "\n😀" * 300}}+ connection.execute(+ """+ UPDATE finding_occurrences+ SET details_json = ?, title = ?, summary = ?, remediation = ?,+ severity = ?, confidence = ?+ WHERE id = ?+ """,+ (+ json.dumps(details),+ "t" * 513,+ "s" * 2_001,+ "r" * 2_001,+ "v" * 129,+ "c" * 129,+ occurrence_id,+ ),+ )+ connection.execute(+ "UPDATE finding_locations SET relative_path = ?, role = ? WHERE occurrence_id = ?",+ ("p" * 4_097, "o" * 129, occurrence_id),+ )+ embedded = run_workbench(state_dir, "get-scan", "--scan-id", scan_id)["scan"]["findings"]+ paged = run_workbench(state_dir, "list-findings", "--scan-id", scan_id)["findingsPage"][+ "findings"+ ]+ assert embedded == paged+ assert len(embedded) == 1+ finding = embedded[0]+ assert finding["attackPath"]["nested"]["value"]+ assert len(json.dumps(finding["attackPath"], separators=(",", ":")).encode()) <= 4_000assert len(finding["evidenceExcerpt"].encode()) <= 8_000assert len(finding["title"].encode()) <= 512assert len(finding["summary"].encode()) <= 2_000@@ -947,26 +971,10 @@ def test_completed_findings_are_returned_in_bounded_pages(tmp_path: Path) -> Nonassert len(finding["locations"][0]["absolutePath"].encode()) <= 4_096with sqlite3.connect(state_dir / "workbench.sqlite3") as connection:connection.execute(- "UPDATE finding_locations SET role = NULL WHERE occurrence_id = ?",- (finding["occurrenceId"],),+ "UPDATE finding_locations SET role = NULL WHERE occurrence_id = ?", (occurrence_id,))roleless = run_workbench(state_dir, "get-scan", "--scan-id", scan_id)assert roleless["scan"]["findings"][0]["locations"][0]["role"] is None- second_page = run_workbench(- state_dir,- "list-findings",- "--scan-id",- scan_id,- "--offset",- "20",- "--limit",- "50",- )["findingsPage"]- assert len(json.dumps(second_page)) < 4 * 1024 * 1024- assert second_page["offset"] == 20- assert second_page["nextOffset"] == 40- assert second_page["total"] == 75- assert len(second_page["findings"]) == 20def test_embedded_and_paged_findings_normalize_scalar_attack_path_assessments(