Skip to content

OpenAI's Codex Security CLI and TypeScript SDK for finding, validating, and fixing security vulnerabilities. npm: https://www.npmjs.com/package/@openai/codex-security

refactor: reuse workbench finding projection metadata (#1442)

mldangelo-oai8dc3614f87c2
diff --git a/plugins/codex-security/scripts/workbench_publication.py b/plugins/codex-security/scripts/workbench_publication.py
index 411f3f81a..d873cb411 100644
--- a/plugins/codex-security/scripts/workbench_publication.py
+++ b/plugins/codex-security/scripts/workbench_publication.py
@@ -423,30 +423,13 @@ def write_csv_export(
candidate_id = finding_candidate_id(finding)
if isinstance(occurrence_id, str) and isinstance(candidate_id, str):
candidate_ids_by_occurrence[occurrence_id] = candidate_id
- writer.writerow(finding_csv_columns(deep_scan))
+ columns = finding_csv_columns(deep_scan)
+ writer.writerow(columns)
for row in finding_export_rows(connection, scan["id"]):
- writer.writerow(
- (
- csv_cell(row["occurrence_id"]),
- csv_cell(row["finding_id"]),
- *(
- (csv_cell(candidate_ids_by_occurrence.get(row["occurrence_id"])),)
- if deep_scan
- else ()
- ),
- csv_cell(row["title"]),
- csv_cell(row["summary"]),
- csv_cell(row["severity"]),
- csv_cell(row["confidence"]),
- csv_cell(row["status"]),
- csv_cell(row["close_reason"]),
- csv_cell(row["note"]),
- csv_cell(row["remediation"]),
- csv_cell(row["relative_path"]),
- row["start_line"],
- row["end_line"],
- )
- )
+ values = dict(row)
+ values["path"] = row["relative_path"]
+ values["candidate_id"] = candidate_ids_by_occurrence.get(row["occurrence_id"])
+ writer.writerow(csv_cell(values[column]) for column in columns)
destination = scan_dir / "exports" / "findings.csv"
try:
write_export_output(
diff --git a/plugins/codex-security/scripts/workbench_scan_history.py b/plugins/codex-security/scripts/workbench_scan_history.py
index bceebb044..c3d035399 100644
--- a/plugins/codex-security/scripts/workbench_scan_history.py
+++ b/plugins/codex-security/scripts/workbench_scan_history.py
@@ -1097,6 +1097,9 @@ def finding_occurrence_rows(
conditions, values = finding_occurrence_conditions(
scan_id, query=query, severity=severity, status=status
)
+ severity_order = " ".join(
+ f"WHEN '{level}' THEN {rank}" for level, rank in SEVERITY_ORDER.items()
+ )
return connection.execute(
f"""
SELECT
@@ -1113,14 +1116,7 @@ def finding_occurrence_rows(
LEFT JOIN finding_triage AS triage ON triage.occurrence_id = occurrences.id
WHERE {conditions}
ORDER BY
- CASE occurrences.severity
- WHEN 'critical' THEN 0
- WHEN 'high' THEN 1
- WHEN 'medium' THEN 2
- WHEN 'low' THEN 3
- WHEN 'informational' THEN 4
- ELSE 5
- END,
+ CASE occurrences.severity {severity_order} ELSE 5 END,
occurrences.created_at,
occurrences.id
LIMIT ? OFFSET ?